Okay, so I am working on this as a project (somewhat for school, but not totally). But, I have run into a bit of trouble with Java running out a heap space (which I am not exactly sure of the reason for as I don't know of any memory leaks that the program has (or really can have) and am gc-ing and flushing everything (I think) each time through the loop.

Here is the code:

import java.awt.Graphics2D;
import java.awt.geom.AffineTransform;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;

import javax.imageio.ImageIO;
import javax.swing.*;

public class Runner{
	public static JFrame gui;
	public static LinkedList<File> files;
	public static int totalFiles;
	public static int percentage;
	public static void main(String args[]){
		gui = new JFrame();
		percentage = 0;
		totalFiles = 0;
		files = new LinkedList<File>();
		gui.setTitle("Thumbnail Maker v1.0");
		gui.setResizable(false);
		gui.setSize(300, 70);
		gui.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);		
		gui.setVisible(true);
		writeLine("Initializing...", 5, 15);
		File dir = new File("C:/Users/Jamedon/Pictures/da2/");
		getFilesBegin(dir);
		makeThumbs();
	}
	public static void clearScreen(){
		clearBox(0, 0, 300, 300);
	}
	public static void clearBox(int x, int y, int width, int height){
		gui.getContentPane().getGraphics().clearRect(x, y, height, width);
	}
	public static void writeLine(String str, int x, int y){
		gui.getContentPane().getGraphics().drawString(str, x, y);
	}
	public static void makeThumbs(){
		for(int i=1; !files.isEmpty(); i++){
			String op = files.pop().getAbsolutePath();
			clearScreen();
			writeLine(op, 5, 15);
			writeLine("Percentage completed: "+percentage+"%", 5, 30);
			percentage = (int)((((double)i+1)/totalFiles)*100);
			try{
				scale(op, 100, "G:/Documents/Pictures/thumbnails/thumb_"+i+".jpg");
			}
			catch (IOException e){
				clearScreen();
				writeLine("Fatal Error, IO exception.", 5, 15);
				return;
			}
			System.gc();
		}
	}
	public static void scale(String srcFile, int destWidth, String destFile) throws IOException {
		BufferedImage src = ImageIO.read(new File(srcFile));
		AffineTransform at;
		if(src.getWidth() > src.getHeight()){ // scale correctly
			at = AffineTransform.getScaleInstance((double)destWidth/src.getWidth(), (double)destWidth/src.getWidth());
		}
		else{
			at = AffineTransform.getScaleInstance((double)destWidth/src.getHeight(), (double)destWidth/src.getHeight());
		}
		BufferedImage dest = new BufferedImage((int)(at.getScaleX()*src.getWidth()), (int)(at.getScaleY()*src.getHeight()), BufferedImage.TYPE_INT_RGB);
		Graphics2D g = dest.createGraphics();
		g.drawRenderedImage(src, at);
		ImageIO.write(dest, "JPG", new File(destFile));
		g.dispose(); // clean up.
		dest.flush();
		src.flush();
	}
	public static void getFilesBegin(File dir){
		clearScreen();
		writeLine("Loading files from "+dir, 5, 15);
		writeLine("Percentage completed: "+percentage+"%", 5, 30);
		getFiles(dir);
	}
	public static void getFiles(File dir){
		String[] children = dir.list();
	    if(children == null){
	    	return;
	    }
	    for(int i=0; i<children.length; i++){
	       	getFiles(new File(dir.getAbsolutePath()+children[i]));
	       	String filename = children[i];
	       	try{
	       		String ext = filename.split("\\.")[1];
	       		if(isImageExtension(ext)){
	       			files.push(new File(dir.getAbsolutePath()+"\\"+filename));
	       			totalFiles++;
	       		}
	       	}
	       	catch(Exception e){
	       		getFiles(new File(dir.getAbsolutePath()+"\\"+filename+"\\"));
	       	}
	    }
	    System.gc();
	}
	public static boolean isImageExtension(String ext){
		return ext.toLowerCase().matches("(png|bmp|jpeg|jpg|gif|tiff)");
	}
}

public class LinkedList<E>{
	private Node<E> head;
	int length;
	public LinkedList(){
		head = new Node<E>(null, head, head);
		head.setPrev(head);
		length = 0;
	}
	public E pop(){
		E temp = head.getNext().getItem();
		head.getNext().getNext().setPrev(head);
		head.setNext(head.getNext().getNext());
		length--;
		System.gc();
		return temp;
	}
	public void push(E item){
		Node<E> newNode = new Node<E>(item, head, head.getPrev());
		head.getPrev().setNext(newNode);
		head.setPrev(newNode);
		length++;
	}
	public boolean isEmpty(){
		return length==0;
	}
	public String toString(){
		String ret = new String("Length: "+length+"\n");
		Node<E> cNode = head.getNext();
		for(int i=0; cNode!=head; i++, cNode = cNode.getNext()){
			ret += "Item: "+i+", contains: "+cNode.getItem()+"\n";
		}
		return ret;
	}
}

The above class is for school. I am have stripped out most of the functions it orignally had to make it easier on the eyes (and act more like a queue).

public class Node<E>{
	private E payload;
	private Node<E> next;
	private Node<E> prev;
	public Node(E item, Node<E> n, Node<E> p){
		payload = item;
		next = n;
		prev = p;
	}
	public E getItem(){
		return payload;
	}
	public void setNext(Node<E> n){
		next = n;
	}
	public void setPrev(Node<E> p){
		prev = p;
	}
	public Node<E> getNext(){
		return next;
	}
	public Node<E> getPrev(){
		return prev;
	}
}

At this point I am having it go through about 50 images, which it gets to 61% complete, and then I get the following error:


Just wondering if there is anything obvious that I could do to improve preformance or at least get the program to finish (without limiting the number of images it can have in the linked list at one time).

Any help would be appreciated.

For a reason I don't know I cannot cut & paste your code to test it... there is no linefeed

You are in an infinite loop... I suspect your pop() method not retrieving the node from the LinkedList

also replace that:

by


You can remove all your System.gc();

This post has been edited by pbl: 30 Apr, 2009 - 06:32 PM

Hm, I don't think there is an infinite loop problem. When I change the scale() function call out with System.out.println(op); it outputs all the file paths in the linked list (and uses the pop() function to get them).

I have attached the project source (zipped):
 src.zip ( 2.18k ) Number of downloads: 2


I have removed all gc() calls as well.

- bump -

sorry BetaWar can't still cut & paste your code to test it
must be Linux to Windows issue... but this does not happens often
what did you do wrong ?

I don't know, I don't believe any of the calls I am using are Windows only... It is using the standard java libraries, so I have no idea. Does linux not allow swing?

Did you tried my System.out.println() ? ... sorry I posted "printf" was probably just out of the office

Ya, I tried the println. It never outputs the same file twice (which is like i should, as it is a queue).

And the size of the queue decreses ?

Yes. At this point it looks like it has problems with images over 5 MB, so if there is an easy way to check file size (accurately) and compare it, I have tried the getTotalSize() method that Files have, but that doesn't seem to work correctly, not sure why.