OK, on to my next challenge. The counter for the number of shots fired is not working. Any idea what is wrong? It is supposed to fire up to 5 shots then say it is empty.



Thanks again,

Michael Walden
mgwalden@gmail.com

ammo=kill()
kill() doesn't return anything, but you're setting ammo equal to the return of kill(), so ammo becomes 'NoneType'. Just call kill() by istelf and you're fine.

OK, I must have missed something. When I run the code it works fine the first time I fire but gives the following error. First is the revised program, then the run results.



Run Results:



All hints are welcome.

Michael Walden

...You didn't revise the code I suggested, it still says ammo=kill() instead of just kill()...

OK, you have a number of problems here. Don't be insulted, you are learning, and this is a good learning opportunity.
1 - Don't cast 0 as an int, it already is
2 - Don't cast 200 to a float, just declare it as 200.0 and it will be
3 - Don't cast choice to a float, you are testing on ints
4 - If the choice is 1, then call fire(ammo), don't insert the code here
5 - Don't count up to 5, this isn't very intuitive. Set ammo to 5 and count down every time you fire.
6 - Use booleans to test on when you can
7 - If user didn't enter 1-4, it's wrong then, so just use "else"

Here are some changes I would make (just for main() and fire()):

okei..i have the same program working on...i've got the fire ammo part working and it works great with the same code you have...but im having problem with the fuel...i cant seem to get my bot stop when it reaches that 200.0 fuel limit..do i have to float (fuel) and added to fuel = 0 ? help please...tnx

def main():
    endProgram = 'no'
    ammo=int(0)
    while endProgram == 'no':
        fuel = 200.0
        fuel = float (fuel)
        print
        


    #Display Menu

        print ' Menu Selections: '
        print '1 - Fire Weapon '
        print '2 - Move Forward '
        print '3 - Move Backward '
        print '4 - Exit '

        choice = input('Enter your selection')
        if choice == 1:
            print ammo
            ammo = ammo + 1
            print ammo
            if ammo <= 5:
                kill()
            elif ammo >= 5:
                print 'You are out of ammunition'
                print ammo
                return ammo
        elif choice == 2:
            move = moveBot(fuel)
        elif choice == 3:
            move = moveBot(fuel)
        elif choice == 4:
            Exit = end()
        elif choice >= 5:
            print 'Not a valid action'
            print 'Please try again'
        else:
            endProgram = raw_input('Do you want to end program?')
        ('Enter yes or no):')
    while not (endProgram == 'yes' or endProgram == 'no'):
        print 'Please enter yes or no'
        endProgram == raw_input('Do you want to end program?')




def moveBot(fuel):
    fuel = input('How far would you like to move? ')
    print fuel
    fuel = fuel + float(fuel)
    if fuel <= 200.0:
        'no'
    elif fuel >= 200.0:
        print 'You are out of fuel'
        return
main()

def kill():
    print
    print'How far is the enemy? '
    killDis = input('Enter distance in feet now! ')
    if killDis <= 20:
        print 'Enemy has been destroyed!'
        return
    elif killDis <= 40:
        print 'Enemy has been partially disabled. '
        return
    elif killDis >= 41:
        print 'The enemy has been unharmed! '
        return


main()



def fire(ammo):
    print ammo
    ammo = ammo + 1
    print ammo
    if ammo <= 5:
        fire = kill(ammo)
    elif ammo >= 5:
        print 'You are out of ammunition'
        return

main()
    

def end():
    endProgram = raw_input('Do you want to end program? yes or no? ')

main()

*** MOD EDIT: Added code tags. Please ***

This post has been edited by JackOfAllTrades: 16 May, 2009 - 07:01 AM

Here how i made my battle bot. Try to look at yours then mine to see what ya did wrong. I'm new to programming and this page helped me out alot...

def main():

ammo = 5
fuel = 200.0
option = 0
distance = 0
feet = 0

while option !=4:
option = choice()
if option == 1:
kill()
ammo=ammo-1
if ammo<1:
print 'Out of ammo'
exit()



elif option == 2:
fuel =move(fuel)

if fuel < 0:
print "\n"*30
print ' You have ran out of fuel'
exit()
elif option == 3:
fuel = move(fuel)
if fuel < 0:
print "\n"*30
print ' You have ran out of fuel'
exit()
elif option == 4:
exit()


def choice():
print "\n"*30
print '1: Fire a weapon '
print '2: Move Foward '
print '3: Move Backward '
print '4: Exit '
option = input('Enter your choice: ')
return option




def kill():

distance = input('Enter how far you would like to fire in feet!')
if (distance <= 20):
print
print 'opponent is destroyed'

elif (distance <= 40):
print
print ' HIT, battlebot has partially been disabled'

elif (distance >= 41):
print "\n"*5
print ' Battlebot is unharmed '


return





def move(fuel):

feet = input('How far do you want to go in feet? ')

if feet >= 200:
print ' You have went off the map! Please try again.'
elif feet >= 100:
print ' You have move 50 feet but a landmind holds you from going any furthor.'
elif feet >= 50:
print ' The battle bot has been block by a landmind.'
elif feet <= 20:
print ' You have moved ' , feet ,'feet.'

fuel-=feet

return fuel





main()

Hey buddy. Saw your post about 2 or 3 weeks ago. Funny thing is my college just fuinished this. I have attached the perfect, 100% working, version. The password is 'battle' (no quotes). Have fun!

~Chris

Hello, I have also been assigned this project at my college and since you seem to have completed it i was wondering how i would go about writing the pseudocode for this using the python code.

Note that you really should be counting down:

>>> ammo = 5
>>> if choice == 1:
...     ammo -= 1

It would probably suit you better to write this in your independant function.

Also, if you would like to see another example program, see my webpage: http://theradclan.com/code_m