C# School Assignment? Project Due Tomorrow? Chat LIVE With A Programming Expert!

Dream.In.Code > Programming Help > C#

Welcome to Dream.In.Code
	Become a C# Expert! Join 300,406 C# Programmers for FREE! Get instant access to thousands of C# experts, tutorials, code snippets, and more! There are 1,641 people online right now. Registration is fast and FREE... Join Now! Chat LIVE With a C# Expert

If a method has more than 2 parameters is it bad?

If a method has more than 2 parameters is it bad?

papuccino1	1 Jul, 2009 - 03:37 PM Post #1
C# Programmer Joined: 2 Mar, 2008 Posts: 943 Thanked: 33 times Dream Kudos: 50 My Contributions	Read a post on Martyrs blog today and he mentioned that if any method you have has more than 2 parameters thats a red flag that you have to refactor your code. Is this true? On one of my programs I have a method that has 5 parameters, is this a bad programming practice?
	This Post Was Helpful!

Register for Free to Make These Ads Go Away!

Martyr2	RE: If A Method Has More Than 2 Parameters Is It Bad? 1 Jul, 2009 - 03:39 PM Post #2
Programming Theoretician Joined: 18 Apr, 2007 Posts: 7,245 Thanked: 820 times Expert In: C/C++, Java, VB, VB.NET, C#, PHP, Web Development, HTML & CSS, Javascript My Contributions	If more than 2 of the OUT OR REF parameters you should CONSIDER refactoring. There are of course multiple reasons to have more than 2 parameters. Edit: The reason is that if you find yourself passing it more than two out or ref parameters (which are designed to then be modified or used as return values your function) it is probably a bit too complex to be contained in a single function. But as for regular function parameters, having more than 2 is certainly common and nothing wrong with that. Look at the .NET framework, you will find tons of methods which have 2 or more. But there is a limit on those as well. If you find your functions taking upwards of 5 or 6 parameters then again you should look at refactoring the method because it is obviously doing more than it probably should. This post has been edited by Martyr2: 1 Jul, 2009 - 03:44 PM
	This Post Was Helpful!

papuccino1	RE: If A Method Has More Than 2 Parameters Is It Bad? 1 Jul, 2009 - 03:53 PM Post #3
C# Programmer Joined: 2 Mar, 2008 Posts: 943 Thanked: 33 times Dream Kudos: 50 My Contributions	Thanks for the hasty answer. Another question! For example, I have a method that receives the URL of a movie for the IMDB website, inside that method I filter out whatever it is I'm trying to find of the movie: Title, Release Year, Genre, etc. That method is inside the Movie.cs class. In my Form1.cs WinForm class I call that method and pass (textBox1, textBox2, etc). Am I using method properly or merely doing it wrong.
	This Post Was Helpful!

SixOfEleven	RE: If A Method Has More Than 2 Parameters Is It Bad? 1 Jul, 2009 - 05:52 PM Post #4
Code Guru Joined: 18 Oct, 2008 Posts: 2,910 Thanked: 165 times Dream Kudos: 725 Expert In: C, C#, XNA, Game Programming, Programming Concepts My Contributions	QUOTE(papuccino1 @ 1 Jul, 2009 - 05:53 PM) Thanks for the hasty answer. Another question! For example, I have a method that receives the URL of a movie for the IMDB website, inside that method I filter out whatever it is I'm trying to find of the movie: Title, Release Year, Genre, etc. That method is inside the Movie.cs class. In my Form1.cs WinForm class I call that method and pass (textBox1, textBox2, etc). Am I using method properly or merely doing it wrong. I would make a class that would hold the Tile, release, year, etc and pass that class the URL as a parameter.
	This Post Was Helpful!

Fast Reply

Reply to this topic

Start new topic

Display Mode: Standard · Switch to: Linear+ · Switch to: Outline

Track this topic · Email this topic · Print this topic · Subscribe to this forum

Time is now: 11/7/09 10:51PM

Invision Power Board v2.1.7 © 2009 IPS, Inc.

Licensed to: MediaGroup1

Advertising | Terms of Use | Privacy Policy | About Us | Site Map

Advertise on this site through Lake Quincy Media

Forum Index: Programming Help | C and C++ | VB6 | Java | VB.NET | C# | ASP.NET | PHP | ColdFusion | Perl and Python | Ruby | Databases | Other Languages | Game Programming | Mobile Development | Software Development | Computer Science | Industry News | Programming Tutorials | C++ Tutorials | Visual Basic Tutorials | Java Tutorials | VB.NET Tutorials | C# Tutorials | Linux Tutorials | PHP Tutorials | ColdFusion Tutorials | Windows Tutorials | HTML/JavaScript Tutorials | CSS Tutorials | Flash Tutorials | Web Promotion Tutorials | Graphic Design & Photoshop Tutorials | Software Development Tutorials | Database Tutorials | Other Language Tutorials | ASP.NET Tutorials | Game Programming Tutorials | WPF & Silverlight Tutorials |

Copyright 2001-2008 MediaGroup1 LLC, All Rights Reserved
A MediaGroup1 LLC Production - Version 6.0.2.1.36
Server: secure2

Search^Updated!w00t

Over 509,000 Pages! Advanced Forum Search

Live C# Help!

Be Social

C# Tutorials

Reference Sheets

C# Snippets

DIC Chatroom

Join our IRC Chat

Bye Bye Ads

Monthly Drawing

Top Contributors

Top 10 Kudos This Month