Hello all,

I've got a web page I'm making just for learning only. Today I decided to play with some IP address comparisons, for example making it viewable to only the two computers on my home network (192.168 range).


Eventually I might add the ability to see the sight from my work IP address.


Anyways, I've only been learning php for a few days and it's been a LONG time since I've programmed in Java or C++. Thus, I've forgotten some of the basics.


Can someone please advise me or give me some direction on why this is returning true?




Basically, it pulls the IP adress of the viewer of the website and if it's not 192.168.0.2 (my other computer) or the one I'm on now it should redirect to google.

It works fine with only 1 IP address listed ie (if ($ip ==$home)) or similar. So there's some problem with how i'm setting up the OR/comparison.


Ccan someone jar my memory?


EDIT: I should clarify. The rest of the webpage is under this code. All this does is echos 'did it' on top of the webpage if for some reason my IP isnt equal to $home or .0.2.

This post has been edited by chrisd234: 14 Jun, 2008 - 07:32 AM

you should have it display the IP it is getting...

and I usually don't use OR, but try this:

   if(($ip != $home || $ip != '192.168.0.2')){

Hmm well it's not just me, I've tried both of those and they both have the same result. If I leave out the || and just compare either of the two it works fine. When I try to add an OR it doesn't work. I may have to just write it another way.

for now I've just resorted to a nested if:




I knew I didnt forget THAT much. I'm just glad I'm not crazy!!!

the nested if may not be pretty but it works.

This post has been edited by chrisd234: 14 Jun, 2008 - 08:55 AM

If you're checking that neither one of the conditions is true, you want to use AND not OR. Editing your code to read



should fix your problem. This is because you are checking to see if the $ip is not equal to $home AND $ip is not equal to 192.168.0.2. You say 'or', when you're saying it outloud, but you should be saying 'and. Try that and see if it works.

It works when you nest your if statements becuase it is checking that the first condition is not true, AND the second condition is not true. Basically what you're saying is if the ip is not true, move on -> if the ip is not true -> redirect. This translates into AND, not OR. It's really easy to get the two confused, and it's a problem a lot of people have, even after they've been programming for a while. I've been programming for a good amount of time now, and even I get my logic confused on occasion.

This post has been edited by akozlik: 14 Jun, 2008 - 09:04 AM

That worked as well. Sadly, I thought of that after I posted I was going with a nested if. I should have caught that myself.

Cool, I'm glad it helped. Like I said, it's easy to cross up your 'and's and 'or's. Or is that ands or ors. Ha ha. Either way, if you listen closely you can hear people getting them confused in grammar too as their speaking. Just remember that if one piece of logic doesn't work, try the opposite and you might be surprised!

Let us know if you have any more PHP questions. We love to help.