[speedster545]

hey, so i've been trying for the past couple of hours to get this program to work and i think i've just run up against a wall. the program is supposed to give the prime factorization of any numbers that are input. multiple numbers can be put in at once, and the program is supposed to end when the user uses the number 0. it is also supposed to be able to use either a text file or user input as its input. any help would be appreciated, thanks!

here's my code thus far:

import java.util.*;

import java.io.*;

public class PrimeFactors
{

	  public static boolean isPrime(int n)
		{
			  if (n<0)
				{
					  n = -n;
				}
				
				
				for (int i = 2; i <= Math.sqrt(n); i++)
				{
					  boolean divisible = (n % i == 0);
						if (divisible)
						{
							  return false;
						}
						
				}
				return true;
		}
		


	  public static void factorize(int number)
		{
			  System.out.print(number + " = ");
				int count;
				for (int i = 2; i < number; i++)
				{
					  count = 0;
					  while (number % i == 0)
						{
							  count++;
								number /= i;
						}
						if (number % i == 0)
						{
							  String factors = "" + i + "^" +count;
								System.out.print(factors);
						}
				}
		}



	  public static void main(String[] arg) throws IOException
		{
			  // make a scanner
			  Scanner scanner = new Scanner(System.in);
				
				// find out the input source
			  System.out.print("What is the input filename:");
				String inputFileName = scanner.nextLine();
				inputFileName = inputFileName.trim();
				
				// if not from file then allow for user input
				if (inputFileName.isEmpty())
				{
					  System.out.print("\nReading input from keyboard.\nPlease provide numbers: ");						
						
						while (scanner.hasNextInt())
						{
							  int number = scanner.nextInt();
							  // test to see if number is prime
							  boolean primeOrNotPrime = isPrime(number);
						
							  // if prime, then factorize number
							  if ( primeOrNotPrime != true)
							  {
									factorize(number);
							  } 
								// if not prime, then say is equal to itself multiplied by one
								else
								{
									  System.out.print(number + " = " + number + " * 1");
								}
						}
						
						
						
						
				}else
				{
	//				  try
			//			{
							Scanner fileIn = new Scanner(new FileReader(inputFileName));
								while (fileIn.hasNextInt())
								{
									  int number = scanner.nextInt();
									// test to see if number is prime
									boolean primeOrNotPrime = isPrime(number);
						
									// if prime, then factorize number
									if ( primeOrNotPrime != true)
									{
										  factorize(number);
									} 
									  // if not prime, then say is equal to itself multiplied by one
									  else
									  {
											System.out.print(number + " = " + number + " * 1");
									  }
							  }
						
				}
				
		}
}

[mostyfriedman]

i have prime factorization in my code snippets..check it out and try to modify it to make it work as u want

[Dantheman]

Ok, so you said you want to create a prime factorization program. Then you gave us the code.

What am I supposed to do with it? Ask a specific question and we'll help,

This post has been edited by Dantheman: 09 June 2009 - 04:32 PM

[speedster545]

I tried using your snippet but I need the prime factorization to read more like this 8 = 2^3. Right now it reads 2 2 2. My code before would work fine for numbers that were a composite of only one number, i.e. 8 = 2^3 came out alright. But when I tried to do it with a number that had more than one composite number, it wouldn't work, it would only display the first number used (i.e. it would give me the out put "6 = 2^1").

[Dantheman]

I've always been using Euler's factorization method for this stuff. You can learn more about it - HERE. Good stuff.

[speedster545]

here's my current code:

import java.util.*;

import java.io.*;

public class PrimeFactors
{

	  public static boolean isPrime(int n)
		{
			  if (n<0)
				{
					  n = -n;
				}
				
				
				for (int i = 2; i <= Math.sqrt(n); i++)
				{
					  boolean divisible = (n % i == 0);
						if (divisible)
						{
							  return false;
						}
						
				}
				return true;
		}
		


	  public static void factorize(int number)
		{
			  System.out.print(number + " = ");
				int count;
				for (int i = 2; i < number; i++)
				{
					  count = 0;
					  while (number % i == 0)
						{
							  count++;
								number /= i;
					   }
						if (count==0)
							  continue;
								
						System.out.println(i + "^" + count);
						
						
				}
		}



	  public static void main(String[] arg) throws IOException
		{
			  // make a scanner
			  Scanner scanner = new Scanner(System.in);
				
				// find out the input source
			  System.out.print("What is the input filename:");
				String inputFileName = scanner.nextLine();
				inputFileName = inputFileName.trim();
				
				// if not from file then allow for user input
				if (inputFileName.isEmpty())
				{
					  System.out.print("\nReading input from keyboard.\nPlease provide numbers: ");						
						
						do
						{
							  int number = scanner.nextInt();
							  // test to see if number is prime
							  boolean primeOrNotPrime = isPrime(number);
						
							  // if prime, then factorize number
							  if ( primeOrNotPrime != true)
							  {
									factorize(number);
							  } 
								// if not prime, then say is equal to itself multiplied by one
								else if (primeOrNotPrime == true)
								{
									  System.out.print(number + " = " + number + " * 1");
								}
								
								System.out.println("Do you have anymore numbers?");
								String answer = scanner.next();
								char answerLetter = answer.charAt(0);
								if (answerLetter == 'y')
								{
									  System.out.print("Please provide numbers: ");
								} else if (answerLetter == 'n')
								{
									  break;
								}
								
						}while (scanner.hasNextInt());
						
						
						
						
				}else
				{
	//				  try
			//			{
							Scanner fileIn = new Scanner(new FileReader(inputFileName));
								while (fileIn.hasNextInt())
								{
									  int number = scanner.nextInt();
									// test to see if number is prime
									boolean primeOrNotPrime = isPrime(number);
						
									// if prime, then factorize number
									if ( primeOrNotPrime != true)
									{
										  factorize(number);
									} 
									  // if not prime, then say is equal to itself multiplied by one
									  else
									  {
											System.out.print(number + " = " + number + " * 1");
									  }
							  }
						
				}
				
		}
}

i'm still having the same problem as before, it can't factor any number that isn't a composite of one single number. also it needs to be able to take in multiple numbers at i time which i can't get it to do.

[speedster545]

Can someone please help me, I'm absolutely stuck.

[pbl]

Your factorization is wrong

When a factor is found you have to divide by it
and you also have to stop when you are done.... when the last factor is prime ....
fortunatly you already have a method to check that

	public static void factorize(int number)
	{
		System.out.print(number + " = ");
		int toTest = number;
		while(toTest > 1) {
			if(isPrime(toTest)) {
				System.out.println(" * " + toTest);
				return;
			}
			for(int i = 2; i < toTest; i++) {
				int count = 0;
				while(toTest % i == 0) {
					count++;
					toTest /= i;
				}
				if(count != 0) {
					System.out.print(" " + i + "^" + count);
				}
			}
		}
		
		System.out.println();
		
	}