[MntMan]

Hello all,
I haven't posted since I finished my C++ class. Now on to Java. Seems a bit easier...
Well here is my problem. I am trying to use the max and min method to determine the max and min number enterd by the user into an array. I could type out all the code to make a class, but want to keep it simple. The errors I get are:

FindAverage.java:31: cannot find symbol
symbol : method max(int)
location: class java.lang.Math
int maxNums = Math.max(0, Math.max( array[counter]));
^
FindAverage.java:32: cannot find symbol
symbol : method min(int)
location: class java.lang.Math
int minNums = Math.min(0, Math.min( array[counter]));
^
2 errors

Here is the code: any help is appreciated.

   import javax.swing.JOptionPane;
	public class FindAverage
	/* Main method */
   {
	   public static void main(String args[])
	  {
		 String strPrompt = "Enter integer values, enter 0 to mark end of file:";
		 int[] array = new int[10];//Amount entered from keyboard
		 int nums = 0;
		 int sum = 0;
		 int counter = 0;
		 float avg = 0;	
	  //Receive amount entered from keyboard
		 do
		 {
			String strData = JOptionPane.showInputDialog(strPrompt);
			nums = Integer.parseInt(strData);
			array[counter] = nums;
			sum += nums;
			counter++;
		 }
		 while (nums != 0);
		 counter -= 1;
		 avg = sum / counter;
		 int maxNums = Math.max(0, Math.max( array[counter]));
		 int minNums = Math.min(0, Math.min( array[counter]));
		 JOptionPane.showMessageDialog(null,
			"You entered " + counter + " numbers:\n" +
			" The sum is: " + sum + 
			"\n The avg is: " + avg + 
			"\n The largest value is: " + maxNums +
			"\n The smallest value is: " + minNums );
	  }
   }

[xclite]

Edited to reduce confusion.

This post has been edited by xclite: 17 June 2009 - 07:00 AM

[AbuJaFaR]

Hello there.
First of all,

int maxNums = Math.max(0, Math.max( array[counter]));


In the nested call of the function math u use a version of max that doesnt exist.
You call the function with one parameter.

Secondly, isnt the logical thing to do a loop to find the max value and the min value?

[pbl]

xclite, on 16 Jun, 2009 - 04:45 PM, said:

import java.lang.Math;

At the top of your program.

No the method is fully qualified: Math.max()
so the problem is not there

There are methods to return the max between 2 numbers:
Math.max(int, int);
Math.max(float, float);
Math.max(double, double);
....
but there is no method Max() with a single element so it is

Math.max(0, array[counter]);
not
Math.max(0, Math.max(array[counter]));

[AbuJaFaR]

xclite, on 16 Jun, 2009 - 04:45 PM, said:

import java.lang.Math;

At the top of your program.

All classes in the java.lang package are visible without an import.

[xclite]

Ug you are, of course, correct. That's what I get for working in other languages all week.

[MntMan]

Thanks that did solve my compile errors. I don't get the max or min to come out right though. I get a "0" for both. Do you think that subtracting the last entry from the counter is doing that?

[pbl]

This will mnake you exit after the first input

while (nums != 0);

you probably mean

while(counter < array.length);

[Fuzzyness]

Your max will be the last value you check, and min will always be 0. You dont compare the two as an "updated" variable. Something like what follows may be better:

int maxNums = 0;
int minNums = array[0]; // after the while loop
//following can replace what you have
maxNums = Math.max(maxNums, array[counter]);
minNums = Math.min(minNums, array[counter]);

This post has been edited by Fuzzyness: 16 June 2009 - 07:04 PM

[MntMan]

That does change it, now I get 2 for both the max and the min. ??
I have the while statement because I am forced to use "0" as a setinal to stop the loop.

[jcmaster2]

Here is some code snippets to help...maybe (hope) you can put it together...

Entering values into an array:

Scanner keyboard = new Scanner(System.in)

System.out.println("How may values to input into the array/ ");
int values = keyboard.nextInt();

int[] tests = new int[values];

for (int i = 0; i < tests.length; i++)   //could use a while loop here....
   {

	  System.out.print("Enter test score " + (index + 1) );
	 tests[i] = keyboard.nextInt();

}

To find min and max array values:

int highest = tests[0];
for (int j = 1; index < tests.length; j++)
{   if (tests[j] > highest)
	  highest = tests[j];
}

The lowest is similar in scope..now go do it...

[MntMan]

Works great thanks allot for the help! This lang is so much easier than C++ was...