[Pipey85]

I dont understand why it goes past the 4000000 when I tell it to check to see if goes higher that this to stop the loop? could one of you coding gurus please explain why this is the case?

#include "stdafx.h"
#include <iostream>
using namespace std;


int main()
{

unsigned long Sum = 0;
unsigned long InitialNum = 0;
unsigned long SecNum = 1;
unsigned long Temp =1;
bool Continue = true;

while (Continue) {

	cout << endl << InitialNum;
	if (InitialNum % 2 == 0)
	{
		cout << "even";
		Sum += InitialNum;
		if (InitialNum >= 4000000)
			Continue = false;
			
	}

	cout << endl << SecNum;
	if (SecNum % 2 == 0){
		cout << "even";
		Sum += SecNum;
		if (SecNum >= 4000000)
			Continue = false;
		
	}

	cout << endl << Temp;
	if (Temp % 2 == 0){
		cout << "even";
		Sum += Temp;
		if (Temp >= 4000000)
			Continue = false;
			
	}




	InitialNum = (SecNum + Temp);
	SecNum = (InitialNum + Temp);
	Temp = (InitialNum + SecNum);
} //end of while



cout << "\nThe sum of all the even numbers is >>>> " << Sum;


	char f;
	cin >> f;
	return 0;
}

Thanks in advance guys and gals!

[xPurplex]

sorry.... the code makes no sense to me what are u trying to do here?

[Pipey85]

xPurplex, on 12 Jul, 2009 - 02:35 PM, said:

sorry.... the code makes no sense to me what are u trying to do here?

im trying to write out the fibonacci sequence and add up all the even numbers that are below 4,000,000
but it keeps going way past 4,000,000.

[xPurplex]

two things...

1. proper syntax:

if(condition){code}

2. the above 4,000,000 check is within the check if the # is even, so it will only check if it's over 4,000,000 if the number is even.

Hope I helped

[NickDMax]

The code does exactly what you told it to, when it reaches 4000000 it ends the loop... whats the problem?

Well, look at where you placed your exit condition -- at the very top if the loop you place Continue = false -- and so it completes that loop and prints numbers that are > exit condition -- but then it ends.

You could use 'break' rather than using the sentinel value. Or, you could put your if-condition at the bottom of the loop (after the next values have been calculated).

[Pipey85]

Ahhhhhhh thankyou! im gunna blame it on the fact its getting late but thanks dude