[Will38]

I was reading my book on C++ (for Dummies) and I came across a part on calculating the average of three integers. The source-code seemed simple enough so i tried to edit it a little bit. Basically it looked like this:

int main(void)
{
int nValue1;
nValue1 = 1;

int nValue2;
nValue2 = 2;

int nValue3;
nValue3 = 2;

int nAverage;
nAverage = (nValue1 + nValue2 + nValue3) / 3;

cout << nAverage;
cin.get();

return(0);
}

keep in mind that this is just a snippet of the code, and it works properly how it is.

The thing is, i was trying to change the code so that the application would ask you for the values instead of imbedding them
within the code itself.

I tried something like this

int nValue1;
cout << "Please input the value of Value1"
cin >> nValue1;

// as soon as i input the value, the program just closes,
// even when that was the only thing i changed. 

And one other problem i ran into was when i tried to use the endl function, my IDE said
statement cannot resolve address of overloaded function.

int nAverage = (nValue1 + nValue2 + nValue3) / 3; endl;
cout << nAverage;
cin.get()

sorry for making such a long post, but if you could answer any of my questions i would appreciate it

[William_Wilson]

cout << "Please input the value of Value1"
missing ; here

int nAverage = (nValue1 + nValue2 + nValue3) / 3; endl;
why the endl; ? this isn't an output statement.

[ericr2427]

Is this what you wanted? endl must be within an output statement.

int nAverage = (nValue1 + nValue2 + nValue3) / 3;
cout << nAverage << endl;
cin.get();

This post has been edited by ericr2427: 03 August 2009 - 06:01 PM

[kidicarus]

Was the window closing because you didn't keep it open?

int main()
{
	using namespace std;
	 int c, d, e;
	 
	char name[30];
	cout << "Enter three values: ";
	int nValue1, nValue2, nValue3;
	cin >> nValue1 >> nValue2 >> nValue3;


	int nAverage;
	nAverage = (nValue1 + nValue2 + nValue3) / 3;

				cout << nAverage;
				cin.get();
				return 0;
}

Input: Enter three values: 3 3 3
Output: 3

[Will38]

hmm. I think i might have mis typed the code. If not thanks, that was a stupid mistake lol...

I thought the window shouldn't close because i used the cin.get() function. I thought cin.get() waited for user input before moving on? That's how it worked before i used endl; in the code.

In your modified version of the code, kidicarus, can you explain to me these parts of the code?

 using namespace std;	  // i thought you were supposed to write this before 
									  // int main()

 int c, d, e;	  // what are these for?

 char name[30]; // also what does this mean?

Sorry for asking, i just started C++ and I'm a noob at it =/

[mono15591]

Will38, on 3 Aug, 2009 - 06:31 PM, said:

hmm. I think i might have mis typed the code. If not thanks, that was a stupid mistake lol...

I thought the window shouldn't close because i used the cin.get() function. I thought cin.get() waited for user input before moving on? That's how it worked before i used endl; in the code.

In your modified version of the code, kidicarus, can you explain to me these parts of the code?

 using namespace std;	  // i thought you were supposed to write this before 
									  // int main()

 int c, d, e;	  // what are these for?

 char name[30]; // also what does this mean?

Sorry for asking, i just started C++ and I'm a noob at it =/

using namespace std; outside of the main function justgives it a global scope so when you create other functions you don't have to keep writing using namespace std;

A char is a single letter,number,symbol etc... so here you can enter numbers 30 digits long

I don't know why he put int c,d,e; it works without it

[Will38]

Why use char name[30]; ?
it works fine without it? also, the window still closes right after it shows the average, without giving me time to see it, which only solves half my problem.

[pakkuman_shinde]

Shouldn't it be more like:

#include <iostream>
#include <stdio.h>
int main(){
	using namespace std;
	cout << "Enter three values: ";
	int nValue1, nValue2, nValue3;
	cin >> nValue1 >> nValue2 >> nValue3;
	nValue1 = (nValue1 + nValue2 + nValue3) / 3;

				cout << nValue1;
				cin.get();
				return 0;
}

[kidicarus]

I help other people on this forum and sometimes I test my suggestions before I submit them, and in this case I acidentally had some code left over from helping somebody else.

Sorry about that I didn't mean to cause any confusion.

Anyway, as mentioned you can use "using namespace std;" within the main function. Some books actually recommend this practice for various reasons.

[Will38]

thanks guys for all your help! Not a problem kidicarus, you still helped me a lot

[IngeniousHax]

pakkuman_shinde, on 3 Aug, 2009 - 07:57 PM, said:

Shouldn't it be more like:

#include <iostream>
#include <stdio.h>
int main(){
	using namespace std;
	cout << "Enter three values: ";
	int nValue1, nValue2, nValue3;
	cin >> nValue1 >> nValue2 >> nValue3;
	nValue1 = (nValue1 + nValue2 + nValue3) / 3;

				cout << nValue1;
				cin.get();
				return 0;
}

No, it should look like this, i'm pretty sure. Atleast this is how I have been taught.

#include <iostream>
#include <stdio.h>

using namespace std;
int main() {
/* code goes here */
return 0;
}

The using namespace std; Should be outside the main function.

This post has been edited by IngeniousHax: 04 August 2009 - 12:41 PM

[jjl]

after you figure out a solution, its good practice to look into new methods.

#include <iostream>
#include <vector>

using namespace std;
class average
{
 public:
	 int input(int size)
	 {
		vector<int>index(size);
		int total = 0;
		for(int i=0; i<size; i++)
		{
			  cin>>index[i];
			  total +=index[i];
		}
		return total/size;
	 }
}; average avg;

int main()
{
	int amount; 
	cout <<"Amount of Numbers :";
	cin>>amount;
	cout<<"Average :"<<avg.input(amount);

	cin.sync();
	cin.get();
	return 0;
}

[Will38]

haha ok... that's pretty confusing to me (i only started this a few days ago) but i agree it's good to always look for new ways to solve the same problem.

and @ ingenioushax,

Quote

Anyway, as mentioned you can use "using namespace std;" within the main function. Some books actually recommend this practice for various reasons.

[dwayne]

You can totally omit the "using namespace x;" and just add and "std::" prefix to the commands (e.g. "std::cin.get();".

[jjl]

oh my bad lol, i didnt read your hole post. But the next step is try to create a function. Its very simple.

#include <iostream>

// global namespace
using namespace std;

// You must always declare the function before you use it,
// Just like any other variable.
int average(int Num1, int Num2, int Num3) // you Parameters 
{
	// the Nums are replace with the values you passed in

	int total = (Num1 + Num2 + Num3)/3; // the math

	//you return value is always the same type as your funciton type
	// in this case its an int, so you return back an int

	return total; // this is what you return back to the main()
}
int main()
{
	cout << "Enter three values: ";
	int nValue1, nValue2, nValue3;
	cin >> nValue1 
		 >> nValue2 
		 >> nValue3;
	cout<<"Total :"<<average(nValue1,nValue2,nValue3);
	
				//Just to pause the window
				cin.sync();
				cin.get();
				return 0;
}

This post has been edited by ImaSexy: 04 August 2009 - 02:04 PM