[bhuelsman]

Here is the problem I'm having. Below is my code and yes it is for a hw assignment. It is actually a failry easy program and for the life of me can't figure out what I'm doing wrong with my while loop. Basically its the last assigment right before out final so the instructor told us just to write a simple program that takes a string from the user and converts all the lower case to upper case. Well that part work just fine. The second part of the assignment was that we we need to use a while loop that will exit when the user inputs Q or q. And for some reason this is the part that is giving me trouble. For one I can not get it to exit on with the Q or q and for some other reason it's showing all my output statements if the user inputs something other then q or either Q or q. Then it will let them input a string and it will just show the result. Its kind of confusing to explain but hopefully someone gets what I mean. [/size]

#include <iostream>
#include <string.h>
#include <ctype.h>
using namespace std;
char quit='q';
void cStringToUpper(char *s1);

char s1[11];
int main()
{
while (quit !='q' || quit != 'Q')								
{
cout<<"Enter your string to be converted without any spaces:"<<endl;		
cin.getline(s1,10);															stores it into s1

cStringToUpper(s1);														to uppercase
cout<<"The converted string is:"<<endl;
cout<<s1;					
cout<<endl;

cout<<"Press (q or Q) to quit:"<<endl;		
cin>>quit;


}		
cin.ignore(2);
return 0;

}	

void cStringToUpper(char *s1)				
{
int i;
int length = strlen(s1);			
for (i=0;i< length; i++)		
s1[i]= toupper(s1[i]);		
} 

[no2pencil]

Since you already have included ctype, I suggest the following

First, if you define quit to already equal the letter 'q', then how do you expect to enter the while loop if the condition is while the variable quit is not equal to the letter 'q'? So we take the or logic out of your while statement, & just check the upper case value of quit. That's all that I altered, & it works just like you described it.

#include <iostream>
#include <string.h>
#include <ctype.h>
using namespace std;
char quit='\0';
void cStringToUpper(char *s1);

char s1[11];
int main(void) {
  while(toupper(quit)!='Q') {
	cout<<"Enter your string to be converted without any spaces:"<<endl;
	cin.getline(s1,10);
	cStringToUpper(s1);
	cout<<"The converted string is:"<<endl;
	cout<<s1;
	cout<<endl;

	cout<<"Press (q or Q) to quit:"<<endl;
	cin>>quit;
  }
  cin.ignore(2);
  return 0;
}

void cStringToUpper(char *s1) {
  int i;
  int length = strlen(s1);
  for (i=0;i< length; i++)
  s1[i]= toupper(s1[i]);
}

[bhuelsman]

Cool thanks I get what you're saying with the quiting the loop part. That part now works but what about the part that when the loop continues it prints all the cout statements to the screen? You have any idea why it's doing that?

no2pencil, on 20 Aug, 2009 - 01:49 AM, said:

Since you already have included ctype, I suggest the following

First, if you define quit to already equal the letter 'q', then how do you expect to enter the while loop if the condition is while the variable quit is not equal to the letter 'q'? So we take the or logic out of your while statement, & just check the upper case value of quit. That's all that I altered, & it works just like you described it.

#include <iostream>
#include <string.h>
#include <ctype.h>
using namespace std;
char quit='\0';
void cStringToUpper(char *s1);

char s1[11];
int main(void) {
  while(toupper(quit)!='Q') {
	cout<<"Enter your string to be converted without any spaces:"<<endl;
	cin.getline(s1,10);
	cStringToUpper(s1);
	cout<<"The converted string is:"<<endl;
	cout<<s1;
	cout<<endl;

	cout<<"Press (q or Q) to quit:"<<endl;
	cin>>quit;
  }
  cin.ignore(2);
  return 0;
}

void cStringToUpper(char *s1) {
  int i;
  int length = strlen(s1);
  for (i=0;i< length; i++)
  s1[i]= toupper(s1[i]);
}

[Elcric]

Hello,

I made a few very picky changes that were not really necessary.

The only problem you had was your while statement. It should have been && instead of ||.

#include <iostream>
#include <string.h>
#include <ctype.h>
using namespace std;

void cStringToUpper( char *s1 );

int main( int argc, char* argv[] )
{
	char quit = ' ';
	char s1[ 11 ];

	while ( quit != 'q' && quit != 'Q' )								
	{
		cout << endl << endl << endl;
		cout << "  Enter your string to be converted without any spaces" << endl;
		cout << "  then press Enter  ==> ";		
		cin.getline( s1, 10 );															//stores it into s1

		cStringToUpper(s1);															   //to uppercase

		cout << endl << endl;
		cout << "  The converted string is:" << endl << "  ";

		cout << endl << endl << "  ";
		cout << s1 << endl; 

		cout << endl << endl << "  ";
		system("PAUSE");

		cout << endl << endl;
		cout << "  Press ( q or Q ) to quit then press Enter  ==> ";		
		cin >> quit;
		cout << endl << endl;
	} 

	return EXIT_SUCCESS;
}	

void cStringToUpper( char *s1 )				
{
	int i;
	int length = strlen( s1 );			
	for ( i = 0; i < length; i++ )		
	s1[ i ]= toupper( s1[ i ]);		
}

//Your program would not compile.  It had 14 errors.
//You wrote comments but did not use the // for the comments.
//I added the // for the comments and the 14 errors went away.

[bhuelsman]

Why would you want &&? If you put that it will keep looping when they enter just q or just Q. For && to work quit would have to equal both q and Q. The || (or) lets it equal either one to get a true so that the loop will end.

Elcric, on 20 Aug, 2009 - 02:44 AM, said:

Hello,

I made a few very picky changes that were not really necessary.

The only problem you had was your while statement. It should have been && instead of ||.

#include <iostream>
#include <string.h>
#include <ctype.h>
using namespace std;

void cStringToUpper( char *s1 );

int main( int argc, char* argv[] )
{
	char quit = ' ';
	char s1[ 11 ];

	while ( quit != 'q' && quit != 'Q' )								
	{
		cout << endl << endl << endl;
		cout << "  Enter your string to be converted without any spaces" << endl;
		cout << "  then press Enter  ==> ";		
		cin.getline( s1, 10 );															//stores it into s1

		cStringToUpper(s1);															   //to uppercase

		cout << endl << endl;
		cout << "  The converted string is:" << endl << "  ";

		cout << endl << endl << "  ";
		cout << s1 << endl; 

		cout << endl << endl << "  ";
		system("PAUSE");

		cout << endl << endl;
		cout << "  Press ( q or Q ) to quit then press Enter  ==> ";		
		cin >> quit;
		cout << endl << endl;
	} 

	return EXIT_SUCCESS;
}	

void cStringToUpper( char *s1 )				
{
	int i;
	int length = strlen( s1 );			
	for ( i = 0; i < length; i++ )		
	s1[ i ]= toupper( s1[ i ]);		
}

//Your program would not compile.  It had 14 errors.
//You wrote comments but did not use the // for the comments.
//I added the // for the comments and the 14 errors went away.

[AntonWebsters]

Let's me try to convert this into English, maybe it'll be easier to understand it.

While quit is NOT 'q' AND NOT 'Q', the loop goes on.

That means, other than entering 'q' AND 'Q', any other kinds of input will make the while loop go on.
Can you understand what I'm trying to explain? =)

This post has been edited by AntonWebsters: 20 August 2009 - 05:45 AM

[Mrafcho001]

nvm

This post has been edited by Mrafcho001: 20 August 2009 - 11:44 AM

[no2pencil]

AntonWebsters, on 20 Aug, 2009 - 06:44 AM, said:

While quit is NOT 'q' AND NOT 'Q', the loop goes on.

At what point will the variable quit equal both lowercase q and upper case q? The loop would run forever.

If it's lower case q, then the 2nd and logic fails. If it's upper case q, then the 1st logic fails.

[trixt.er]

HA! That's the funniest thing I've seen all day. haha
Don't worry, I don't it once a year to.