[yuuske]

#include<stdio.h>
#include<conio.h>
main()
{
clrscr();
char *str;
int ind,pos,nw=0;
printf("\nEnter string: ");
gets(str);
printf("Enter position of character you want to delete(start with 0): ");
scanf("%d:,&pos);
for (ind=0;str[ind]!='\0';ind++)
				{
				if (ind!=pos)
					   {
					   str[nw]=str[ind];
					   nw++;
					   }
				}
str[nw-1]='\0';
printf("%s",str);
getch();
return 0;
}

This is my code for the program that deletes a character from a string.

#include<stdio.h>
#include<conio.h>
main()
{
clrscr();
char *str,nwch;
int ind,pos,nw=0;
printf("\nEnter string: ");
gets(str);
printf("\nEnter character you want to insert: ");
nwch=getchar();
printf("\nEnter position where you want to insert new character(start with 0): ");
scanf("%d",&pos);
for (ind=0;str[ind]!='\0';ind++) //sorry got a typo here XD
		  {
		  if (ind!=pos)
				  {
				  str[nw]=str[ind];
				  nw++;
				  }
		  else if (ind==pos)
				 {
				  str[nw]=nwch;
				  nw++;
				 }
		   }
printf("\n%s",str);
getch();
return 0;
}

my codes for the character program insertion

.....my character deleting program works just fine...and the insertion program is just its opposite twin...problem is my insertion program doesnt work the way i want it to if i typed in "dta" and i want to insert "a" at index "1" its supposed to output "data"
but it doesnt

any advise from the masters?and yea this has to be done in turbo c using old fashion looping

This post has been edited by yuuske: 03 September 2009 - 05:40 AM

[horace]

should the test in your for()

for (ind=0;str[ind]='\0';ind++)

be !=

for (ind=0;str[ind]!='\0';ind++)

[dgirdhar]

Still this will not solve the problem,

You are incrementing the varaibles 'ind' in case you found the position.

In first iteration
Str[ind/0] = 'd'

In Second iteration
Str[ind/1] = 'a' // using else condition.
(Error: Here you are overriding 't'.)
Here 't' is lost and string will be now ('daa')

Solution Suggestion
1) Take new empty string and store data their or
2) First store new character at end and shift according to position.

yuuske, on 3 Sep, 2009 - 04:20 AM, said:

#include<stdio.h>
#include<conio.h>
main()
{
clrscr();
char *str;
int ind,pos,nw=0;
printf("\nEnter string: ");
gets(str);
printf("Enter position of character you want to delete(start with 0): ");
scanf("%d:,&pos);
for (ind=0;str[ind]!='\0';ind++)
				{
				if (ind!=pos)
					   {
					   str[nw]=str[ind];
					   nw++;
					   }
				}
str[nw-1]='\0';
printf("%s",str);
getch();
return 0;
}

This is my code for the program that deletes a character from a string.

#include<stdio.h>
#include<conio.h>
main()
{
clrscr();
char *str,nwch;
int ind,pos,nw=0;
printf("\nEnter string: ");
gets(str);
printf("\nEnter character you want to insert: ");
nwch=getchar();
printf("\nEnter position where you want to insert new character(start with 0): ");
scanf("%d",&pos);
for (ind=0;str[ind]='\0';ind++)
		  {
		  if (ind!=pos)
				  {
				  str[nw]=str[ind];
				  nw++;
				  }
		  else if (ind==pos)
				 {
				  str[nw]=nwch;
				  nw++;
				 }
		   }
printf("\n%s",str);
getch();
return 0;
}

my codes for the character program insertion

.....my character deleting program works just fine...and the insertion program is just its opposite twin...problem is my insertion program doesnt work the way i want it to if i typed in "dta" and i want to insert "a" at index "1" its supposed to output "data"
but it doesnt

any advise from the masters?and yea this has to be done in turbo c using old fashion looping

[yuuske]

TPAM you got me lost with the first suggestion

how do i make a new one when an arrays memory tends to be a fixed value compared to that of a singly linked list?

sorry im really slow but im trying hard

[horace]

yuuske, on 3 Sep, 2009 - 11:52 AM, said:

TPAM you got me lost with the first suggestion

how do i make a new one when an arrays memory tends to be a fixed value compared to that of a singly linked list?

sorry im really slow but im trying hard

you could move the characters in the string to make space then insert the new character

for (ind=0;str[ind]!='\0';ind++) //sorry got a typo here XD
		  {
		   if (ind==pos)
				 {
				  int i;
				// make room in string for character
				  for(i=strlen(str)+2;i>=pos;i--) str[i+1]=str[i];
				  str[pos]=nwch;
				 }
		   }

in fact you don't need the outer loop you can insert directy

if(strlen(str)>=pos)
	{
	   int i;
	   // make room in string for character
	   for(i=strlen(str)+2;i>=pos;i--) str[i+1]=str[i];
	   str[pos]=nwch;
	 }

[yuuske]

ack! ....

i failed to amuse myself ahaha

tnx i'll take that into account

tnx alot

[yuuske]

hi im back again...i tried the solution that mr horace gave me but i get an output of "daaa"

Enter string: dta
Enter character to insert: a
Enter position where to: 1

Output:
daaa

[horace]

yuuske, on 4 Sep, 2009 - 11:59 AM, said:

hi im back again...i tried the solution that mr horace gave me but i get an output of "daaa"

Enter string: dta
Enter character to insert: a
Enter position where to: 1

Output:
daaa

strange, using my example

#include<stdio.h>
#include<conio.h>
main()
{
//clrscr();
char *str,nwch;
int ind,pos,nw=0;
printf("\nEnter string: ");
gets(str);
printf("\nEnter character you want to insert: ");
nwch=getchar();
printf("\nEnter position where you want to insert new character(start with 0): ");
scanf("%d",&pos);
if(strlen(str)>=pos)
	{
	   int i;
	   // make room in string for character
	   for(i=strlen(str)+2;i>=pos;i--) str[i+1]=str[i];
	   str[pos]=nwch;
	 }

printf("\n%s",str);
getch();
return 0;
}

i run it it works

Enter string: dta
Enter character you want to insert: a
Enter position where you want to insert new character(start with 0): 1
data

[yuuske]

i get it now...my brackets placing was wrong demn...sry for the trouble and tnx again mr horace