[mabaton]

Create a C++ console application that generates a random number that must be guessed by a user. The program will indicate to the user if their guess is correct, too high or too low. It will also report the number of guesses the user has made. The game ends when the user enters a negative one (-1) or has guessed the number. The program should include a do while loop, decision statements, constants and variables.

Here is what I have but it does not work properly.....what am I doing wrong?

 #include <iostream>
#include <time.h>

using namespace std;

int main(void)
{
	srand(static_cast<int> (time(NULL)));

	int upperLimit = 10;
	int lowerLimit = 1;
	int userGuess = 0;
	int count = 0;
	int randNum = 0;
	const int exit = -1;

	cout << "***Welcome to the Guessing Game!***\n";
	srand (int(time(NULL)));
	randNum = (rand() % (upperLimit - lowerLimit + 1)) + lowerLimit;
	cout << "Pick a number between 1-10 (-1 to Exit): ";
	cin >> userGuess;
	
	do
	{ 		
		if (userGuess < randNum)
			cout << endl << "Too low, try again." << endl;
		else if (userGuess > randNum)
			cout << endl << "Too high, try again." << endl;
				
		else if (userGuess == randNum)
			cout << endl << "You've guessed wisely" << endl;
		else
		cout << "The number was " << randNum << " you gave up after " << count << " guesses.\n";	
		count++;
		cin >> userGuess;	
	}
	while(userGuess != randNum && userGuess > 0);
	
	
	cout << "The number was " << randNum << " it took you " << count << " guesses.\n";
	return 0;
}

[eker676]

I would put the input in the do while loop so the user can continue playing.

[gabehabe]

http://www.dreaminco...h...st&p=773393

[Crunch]

I agree with eker676. Other that that i see no error? How are you expecting the code to behave?

[mabaton]

snowflakes, on 20 Sep, 2009 - 09:00 AM, said:

I agree with eker676. Other that that i see no error? How are you expecting the code to behave?

Here is my updated code. Everything works except the count when the number is guessed correctly....its one less than it should be. But the count is correct if I choose -1 to exit after a few guesses. Not sure how to fix it. When I put the count at the top of the loop it throws off both counts ( -1 and guessing correctly)

#include <iostream>
#include <time.h>

using namespace std;

int main(void)
{
	srand(static_cast<int> (time(NULL)));

	int upperLimit = 10;
	int lowerLimit = 1;
	int userGuess = 0;
	int count = 0;
	int randNum = 0;
	const int exit = -1;

	cout << "***Welcome to the Guessing Game!***\n";
	srand (int(time(NULL)));
	randNum = (rand() % (upperLimit - lowerLimit + 1)) + lowerLimit;
	
	
	do
	{ 	
		
		cout << "Pick a number between 1-10 (-1 to Exit): ";
		cin >> userGuess;	
		if (userGuess < randNum && userGuess != exit)
			cout << endl << "Too low, try again." << endl;
		else if (userGuess > randNum)
			cout << endl << "Too high, try again." << endl;			
		else if (userGuess == randNum)
		cout << endl << "You've guessed wisely" << endl 
			<< "The number was " << randNum << " it took you " << count << " guesses.\n";
		else 
			cout << "The number was " << randNum << " you gave up after " << count << " guesses.\n";
		count++;	
	}
	while(userGuess != randNum && userGuess > 0);
		
	
	
	return 0;
}

[aks29921]

instead of using

do
{//your code here}
while(userGuess != randNum && userGuess > 0);

try

while(userGuess != randNum && userGuess > 0)
{//your code here
};

This post has been edited by aks29921: 20 September 2009 - 11:34 PM

[gabehabe]

No, don't. do is the better option since you always want to run the code at least once. Just increment it again before you output it.

count++;

Or start from 1 instead of 0.

This post has been edited by gabehabe: 20 September 2009 - 10:46 AM

[poncho4all]

Cant it be changed to ++count; i think it would work.

[aks29921]

gabehabe, on 20 Sep, 2009 - 09:46 AM, said:

No, don't. do is the better option since you always want to run the code at least once. Just increment it again before you output it.

count++;

Or start from 1 instead of 0.

he is getting the correct count when he is exiting by pressing -1....

i think i have got the exact problem....

in do-while, the code runs first and then the count increments.
so, when the user guesses correctly the count that is getting printed is not updated at the last step (the step when the user guesses correctly) and this is happening all the time.
however on pressing -1, then there is no need of the count getting updated hence the correct answer..

the above problem can be removed by:

cout << endl << "You've guessed wisely" << endl
			<< "The number was " << randNum << " it took you " << count+1 << " guesses.\n";
 

This post has been edited by aks29921: 20 September 2009 - 11:43 PM

[gabehabe]

The count increments in the do loop.

Just initialise count to = 1 instead of 0 and that'll sort it.

[AGRAC393]

ha there's another thread with the same question by different people... Same class?

[poncho4all]

I still think that the ++count will work fine f3

[aks29921]

++count won't work as it is not the problem of prefix and postfix operators changing the count just after an operation, rather its the problem of count getting updated in the loop..

hence as mentioned in my above post, replacing count by count+1 at that one place will do the trick and the game will work f9.....