[Racer X]

c

lass Palindrome
{
	static boolean checkpalindrome(char[] A)
	{
		boolean palin=true;
		for(int i=0;i<=A.length/2;i++)
		{
			if (A[i]!=A[A.length-i-1])
			{
				palin=false;
				break;
			}
		}
		return palin;
	}
	public static void main(String args[])
	{
		BufferedReader bf=new BufferedReader(new inputStreamReader(System.in));
		System.out.print("Enter a word");

		String inpStr=bf.readline(); 
		inpStr=inpStr.toUpperCase();
		char[] inpass=inpStr.toCharArray();
	
		if(checkpalindrom(inpass))
		System.out.print("Yes the string is palindrome");
		else
		System.out.print("No, the string is not palindrome");

	}
}

//i get 4 errors and dont know the problem can anyone help me

This post has been edited by JackOfAllTrades: 10 July 2011 - 07:55 AM
Reason for edit:: Added code tags

[Fuzzyness]

Also please post the errors that you are getting along with the Line of code that it is reffering to.

Thanks

[Racer X]

error is
Palindrome.java:18: cannot find symbol
it shows the same 3 errors

[Aligator301]

Hey buddy,

I can't see the file you have there but you're missing the import at the top, so that is a bad start (you need to import the packages or files you intend to use)

Also, your spelling and capitalization is letting you down!
you spelled your own function incorrectly, error
you used an 'i' for inputStreamReader instead of InputStreamReader

Go and get yourself a copy of Netbeans (http://www.netbeans.org/) to do your work in so that it can highlight your errors in the code as you work or if you can wait, get IntelliJ 9 basic edition (which will be free)

import java.io.*;

public class Palindrome
{
	public static boolean checkpalindrome(char[] A)
	{
		// always sanity check.
		if (A!=null && A.length % 2 == 0)
		{
			for (int i=0; i<=A.length/2; i++)
			{
				if (A[i]!=A[A.length-i-1])
				{
					return false;
				}
			}
			return true;
		}
		
		return false;
	}
	
	public static void main(String args[])
	{
		BufferedReader bf = new BufferedReader(new InputStreamReader(System.in));
		System.out.print("Enter a word");

		String inpStr=null;

		try
		{
			inpStr = bf.readLine();
		}
		catch (Exception e)
		{
			e.printStackTrace();
		}

		if (inpStr!=null && inpStr.length()>0)
		{
			inpStr=inpStr.toUpperCase();
			char[] inpass=inpStr.toCharArray();

			if (checkpalindrome(inpass))
				System.out.print("Yes the string is palindrome");
			else
				System.out.print("No, the string is not palindrome");
		}
		else
		{
			System.out.print("input not well formed.");
		}


	}
}

A.

[y2161994]

this program is only syntatically correct.logically it is not correct.when I gave radar,this produce output that,"No, the string is not palindrome".
But radar is a palindrome string.

[supercorey]

Why are you using such as complex method for determining if it is a palindrome?
All you would have to do is reverse the string and see if it equals the original string.

public boolean checkPalindrome(String toCheck){
    String reverse = new StringBuffer(toCheck).reverse().toString();
    if(toCheck.equals(reverse)){
        return true;
    }
    return false;
}

Or do you have to use a char array for some reason?

Note: I coded that from the hip straight into the post. I might have some minor syntactical errors.

[y2161994]

Quote

Thank you.
Your code works.
I m very happy after doing this program .

Quote

Thank you.
Your code works.
I m very happy after doing this program .

[javabrijon]

Dont you have to close your BufferedReader after its finished?

P.s. if you read below under related topics there are a few more topics on Palindromes which could give you code hints.

[cfoley]

I actually prefer the opening poster's solution to the reverse() method. The code becomes clearer when you use two variables for the loop through.

boolean isPalindrome(String str) {
  char[] ch = str.toLowerCase().toCharArray();
  int start = 0;
  int end = ch.length - 1;

  while (end > start) {
    if (ch[start] != ch[end])
      return false;
    start++;
    end--;
  }
  return true;
}

This post has been edited by cfoley: 11 July 2011 - 04:57 AM

[CasiOo]

I like the way racer x was thinking about doing it in the first place. There really isn't any more code lines, and it is faster than reversing the String. I don't see how it can be any simpler.

	public boolean isPalindrom( String word ) {
		for ( int i = 0; i < word.length() / 2; i++ ) 
			if ( word.charAt( i ) != word.charAt( word.length() - i - 1 ) )
				return false;
		return true;
	}

This post has been edited by CasiOo: 11 July 2011 - 05:36 AM

[cfoley]

If we are talking lines of code, the reverse() method IS smaller:

	boolean isPalindrome(String str) {
		return new StringBuffer(str).reverse().toString().equals(str);
	}

But I don't like it because it requires a relatively in-depth knowledge of the Java API for a task that's very simple with a small loop. I don't like all the arithmetic in the original solution. It's confusing to look at and if there was a bug, it could take some figuring out. The arithmetic is easily factored out by using two variables. It looks like it should be slower, but actually there are less calculations going on.

[macosxnerd101]

@cfoley: Being a little anal here, the StringBuilder class is more efficient b/c it isn't synchronized, while StringBuffer is.

[cfoley]

You know, I looked up the API for StringBuilder and then typed StringBuffer.