[chris_s_22]

ive got a upload photo script and im just trying to make more secure currently it limits size and as you can see from my code below it limits only gif and php files

how do i edit my code to limit all these or do i have to copy and paste the same code and change the file extention?
jpg, jpeg, pjpeg, PJPEG, JPG, JPEG, gif, GIF, png, PNG

if (!($uploaded_type=="image/gif")) {
	echo "You may only upload GIF files.<br>";
	$ok=0;
	}  

also ive restricted php is there anything else i need to restrict?

if ($uploaded_type =="text/php") 
{ 
	echo "No PHP files<br>"; 
	$ok=0; 
	} 

[noorahmad]

you can store all types in array and using in_array

Example:

$types = array("type/jpg", "type/jpeg", "type/pjpeg", "type/PJPEG", "type/JPG", "typ/JPEG", "type/gif", "type/GIF", "type/png", "type/PNG");
if(!in_array($uploaded_type,$types)){
 echo "Invlaid file type";
 $ok = 0;
}

[picnframes]

if you want to set the limit than u can also send a hidden input type having size limit as value:
input type="hidden" name="MAX_FILE_SIZE" value="2000000
input name="userfile" type="file" id="userfile
input name="upload" type="submit" class="box" id="upload" value=" Upload">
<input type="file" name="" >


if(!$con)
{
die("conection failed".mysql_error());
}
$sql=mysql_select_db("photo",$con);if(!$sql){die("database failed".mysql_error());}
$uploadDir = 'C:/webroot/upload/';
if(isset($_POST['upload']))
{
$fileName = $_FILES['userfile']['name'];
$tmpName = $_FILES['userfile']['tmp_name'];
$fileSize = $_FILES['userfile']['size'];
$fileType = $_FILES['userfile']['type'];
$filePath = $uploadDir . $fileName;
$result = move_uploaded_file($tmpName, $filePath);
if (!$result)
{
echo "Error uploading file";exit;}

if(!get_magic_quotes_gpc())
{$fileName = addslashes($fileName);
$filePath = addslashes($filePath);}
$query = "INSERT INTO upload2 (name, size, type, path ) "."VALUES ('$fileName', '$fileSize', '$fileType', '$filePath')";
mysql_query($query) or die('Error, query failed : ' . mysql_error());
mysql_close($con);
echo "
Files uploaded
";
}?>
picnframes.com
sco-16
sec-34
chandigarh

[chris_s_22]

thx people ive gone with something more simple bit more like this and just added each exeption like so

if ((($_FILES["photo"]["type"] == "image/gif") 
	|| ($_FILES["photo"]["type"] == "image/jpeg") 
	|| ($_FILES["photo"]["type"] == "image/pjpeg"))
	&& ($_FILES["photo"]["size"] < 51000))
	{