[ritsybitsy]

Hi, I'm sorry in advance if this is inappropriate. I'm not asking for code, I actually have a question and it's probably going to be really dumb, but I'm kind of stuck.
I'm doing a, I guess simple if...then...else.
It's supposed to calculate and display the number of gallons of water used and the total charge for the water, which is .00175/gal. It should only make the calculations when the current meter reading is >= the previous meter reading, or else it should print an error message.

	Private Sub calculateButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles calculateButton.Click
		If (Val)currentTextBox < (val)previousTextBox 
		Then badlabel.text = "Error"
		Else
			totalgallonsLabel = Val(currentTextBox) + Val(previousTextBox)
			totalchargeLabel = totalgallonsLabel * 0.00175
		End If

	End Sub

But it's giving errors which I've attatched. Is there an/many obvious mistake/s that I'm making?
Thank you.

Attached image(s)

• 

This post has been edited by ritsybitsy: 14 December 2009 - 01:57 PM

[JackOfAllTrades]

First problem: you posted in VB6, but this code is VB.NET. I'll move it for you, and let the VB gurus answer for you.

[ZRonZ]

ritsybitsy, on 14 Dec, 2009 - 12:55 PM, said:

Hi, I'm sorry in advance if this is inappropriate. I'm not asking for code, I actually have a question and it's probably going to be really dumb, but I'm kind of stuck.
I'm doing a, I guess simple if...then...else.
It's supposed to calculate and display the number of gallons of water used and the total charge for the water, which is .00175/gal. It should only make the calculations when the current meter reading is >= the previous meter reading, or else it should print an error message.

	Private Sub calculateButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles calculateButton.Click
		If (Val)currentTextBox < (val)previousTextBox 
		Then badlabel.text = "Error"
		Else
			totalgallonsLabel = Val(currentTextBox) + Val(previousTextBox)
			totalchargeLabel = totalgallonsLabel * 0.00175
		End If

	End Sub

But it's giving errors which I've attatched. Is there an/many obvious mistake/s that I'm making?
Thank you.

First off, look up the proper use of the Val function. You had the right idea but you didn't execute it correctly in the If statement. Follow through with the Else code.

Second, totalgallonslabel isn't a value, it's a label. Labels have properties like value. You got it right with badlabel.text, do the same for the other labels.

Correct those and you'll at least have a good start at it and should be able to fix the math.

[EndLessMind]

If you did´nt understand what said.. when this is that he meant

this code

 totalchargeLabel = totalgallonsLabel * 0.00175

returns a error because it´s a label. So this´s a string unless you convert it first.
And you cant do string = string * dubble/decimal/singel or any other value holder.
it´s simple. what till you get if you do like this for example: Hello = Hello * 0.43.
Well, you get error
Sure that´s to much explanation, but that was just to make sure you understand

[thalorre]

So you need to say:

 Private Sub calculateButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles calculateButton.Click

dim totalcharge as Integer
dim totalgallons as Integer

totalgallonsLabel.text = totalgallons
totalchargeLabel.text = totalcharge

If (Val)currentTextBox < (val)previousTextBox 
		Then badlabel.text = "Error"
		Else
			totalgallons = Val(currentTextBox) + Val(previousTextBox)
			totalcharge = totalgallonsLabel * 0.00175
 End If
   End Sub

it's been a while that i used VB but i think that's it.

Grtz.

[EndLessMind]

thalorre, on 16 Dec, 2009 - 01:22 PM, said:

So you need to say:

 Private Sub calculateButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles calculateButton.Click

dim totalcharge as Integer
dim totalgallons as Integer

totalgallonsLabel.text = totalgallons
totalchargeLabel.text = totalcharge

If (Val)currentTextBox < (val)previousTextBox 
		Then badlabel.text = "Error"
		Else
			totalgallons = Val(currentTextBox) + Val(previousTextBox)
			totalcharge = totalgallonsLabel * 0.00175
 End If
   End Sub

it's been a while that i used VB but i think that's it.

Grtz.

Well. yes, that sould work because you convert it to a integer befor using it.