[ahaykal]

I have a homework which states that I should do a class called course. It has several data members such as course name and the credits etc... Everything worked except when i want to pass an array to the member function. I get an error and the program exits. I will post the class:

class course
{
	private:
        char Type;
		int Credit;
		int maxStud;
		char Title[29];
		char crsName[7];
	   
	     
	
public:
		course();
	    void set_Credit(int);
	    void get_Credit();
	    
	    void set_maxStud(int);
	    void get_maxStud();
	   
		void set_Type(char);
		void get_Type();
		

		

        void set_crsName(char []);
        void get_crsName();
};

Constructor:

course::course()
{
	Credit = 3;
	maxStud = 20;
	Type = 'U';
	Title[0] = '\0';
	
}

These are the functions :

The set_crsName and get_crsName are the functions that are not working:

void course::set_crsName(char name[])
{
     strncpy(crsName , name, 7);
     name[2] = '\0';
}


void course::get_crsName()
{
     for (int i = 0; i <29 ; i++)
         cout<<crsName[i];
         
}

The main function:

course math;

math.set_crsName("MAT");

Could you guide me on the problem please.

Thank you

[Tapas Bose]

Is it necessary in your homework to use a char array?

This post has been edited by Tapas Bose: 13 March 2010 - 02:43 AM

[Anarion]

Quote

Everything worked except when i want to pass an array to the member function. I get an error and the program exits.

Please mention the error.

[ahaykal]

I could also use a string.

Thanks for your help!

Also the error is this :

Attached image(s)

• 

This post has been edited by ahaykal: 13 March 2010 - 03:41 AM

[Ferencn]

From reading the code, two errors:

void course::set_crsName(char name[])
{
     strncpy(crsName , name, 7);
     // you are acessing the argument, not your own array
     name[2] = '\0';   //
}


void course::get_crsName()
{
     // crsName is only 7 bytes long, you are accessing past the array boundary
     for (int i = 0; i <29 ; i++)
         cout<<crsName[i];
         
}

and:
From the screenshot I get the idea that you are not testing your program in Debug mode.
Please try to run the program in Debug, you will get much more helpful errors, and the debugger will show you where things go wrong.

This post has been edited by Ferencn: 13 March 2010 - 03:55 AM

[ahaykal]

Ferencn, on 13 March 2010 - 02:53 AM, said:

From reading the code, two errors:

void course::set_crsName(char name[])
{
     strncpy(crsName , name, 7);
     // you are acessing the argument, not your own array
     name[2] = '\0';   //
}


void course::get_crsName()
{
     // crsName is only 7 bytes long, you are accessing past the array boundary
     for (int i = 0; i <29 ; i++)
         cout<<crsName[i];
         
}

and:
From the screenshot I get the idea that you are not testing your program in Debug mode.
Please try to run the program in Debug, you will get much more helpful errors, and the debugger will show you where things go wrong.

I still Do not know how to debug .