[jokertin92]

Hi, I've created a login form where I've some problem,.. Can any one help me please...

My username password is (Location = Hyderabad, Password=Hydd)

private void btnlogin_Click(object sender, EventArgs e)
        {
            using ( con = new SqlConnection(Helper.ConnectionString))
            {
                SqlCommand cmd = new SqlCommand();
                cmd.CommandText = "Select Location, Password FROM UserAccounts WHERE Location=" + "@location AND Password = @password";
                cmd.Connection = con;
                cmd.Parameters.AddWithValue("@location",cmbLocation.Text.ToString());
                cmd.Parameters.AddWithValue("@password",txtPassword.Text.ToString());
                con.Open();
                SqlDataReader dr = cmd.ExecuteReader();
                if (dr.Read())
                {

====> This statement is not executed...
---------------------------------------------------------------------------
                    if(cmbLocation.Text==null||txtPassword.Text==null)
---------------------------------------------------------------------------

                    {
                        MessageBox.Show("Location / Password must not be Empty");
                    }

===> This statement is created for checking case sensitive, it shows error if the password is "hydd", but other than this if i give any thing like "hyd" it doesn't show any error like password wrong etc.
---------------------------------------------------------------------------
                    else if (dr["Location"].ToString() == cmbLocation.Text && dr["Password"].ToString()==txtPassword.Text)
---------------------------------------------------------------------------
                    {
                        MessageBox.Show("Logged in Successfully");
                        //this.Hide();
                    }
                    else
                    {
                        MessageBox.Show("!!! Please Check the Password");
                        txtPassword.Clear();
                        cmbLocation.Focus();
                    }
                }                                          
            } //con.Dispose() method would be called automatically
        }

[eclipsed4utoo]

you aren't doing your login form very efficiently.

try this instead...

private void btnlogin_Click(object sender, EventArgs e)
{
    // checks the combobox and textbox.  This should
    //    be done before you even do the database query.
    if (string.IsNullOrEmpty(cmbLocation.Text) || string.IsNullOrEmpty(txtPassword.Text))
    {
         MessageBox.Show("Location / Password must not be Empty");
         return;
    }

    using (SqlConnection con = new SqlConnection(Helper.ConnectionString))
    {
        using (SqlCommand cmd = con.CreateCommand())
        {
             // The query will return the number of record that match the location 
             //    and password.  If it's 0, then the password was incorrect.
             cmd.CommandText = "Select COUNT(*) FROM UserAccounts WHERE Location = @location AND Password = @password";
 
             // No need to use .ToString() since the Text properties are
             //    already strings.
             cmd.Parameters.AddWithValue("@location",cmbLocation.Text);
             cmd.Parameters.AddWithValue("@password",txtPassword.Text);

             con.Open();

             // ExecuteScalar returns only the first column of the first row
             //    from the query.  We are only returning one column and one row
             //    so ExecuteScalar fits our needs.
             int count = (int)cmd.ExecuteScalar();

             if (count > 0)
                MessageBox.Show("Logged in Successfully");
             else
               MessageBox.Show("!!! Please Check the Password");
        }
    }
}

This post has been edited by eclipsed4utoo: 25 March 2010 - 05:43 AM

[jokertin92]

eclipsed4utoo, on 25 March 2010 - 04:40 AM, said:

you aren't doing your login form very efficiently.

try this instead...

private void btnlogin_Click(object sender, EventArgs e)
{
    // checks the combobox and textbox.  This should
    //    be done before you even do the database query.
    if (string.IsNullOrEmpty(cmbLocation.Text) || string.IsNullOrEmpty(txtPassword.Text))
    {
         MessageBox.Show("Location / Password must not be Empty");
         return;
    }

    using (SqlConnection con = new SqlConnection(Helper.ConnectionString))
    {
        using (SqlCommand cmd = con.CreateCommand())
        {
             // The query will return the number of record that match the location 
             //    and password.  If it's 0, then the password was incorrect.
             cmd.CommandText = "Select COUNT(*) FROM UserAccounts WHERE Location = @location AND Password = @password";
 
             // No need to use .ToString() since the Text properties are
             //    already strings.
             cmd.Parameters.AddWithValue("@location",cmbLocation.Text);
             cmd.Parameters.AddWithValue("@password",txtPassword.Text);

             con.Open();

             // ExecuteScalar returns only the first column of the first row
             //    from the query.  We are only returning one column and one row
             //    so ExecuteScalar fits our needs.
             int count = (int)cmd.ExecuteScalar();

             if (count > 0)
                MessageBox.Show("Logged in Successfully");
             else
               MessageBox.Show("!!! Please Check the Password");
        }
    }
}

but, it doesn't check the case sensitive...

[eclipsed4utoo]

this should work for you

private void btnlogin_Click(object sender, EventArgs e)
{
    // checks the combobox and textbox.  This should
    //    be done before you even do the database query.
    if (string.IsNullOrEmpty(cmbLocation.Text) || string.IsNullOrEmpty(txtPassword.Text))
    {
         MessageBox.Show("Location / Password must not be Empty");
         return;
    }

    using (SqlConnection con = new SqlConnection(Helper.ConnectionString))
    {
        using (SqlCommand cmd = con.CreateCommand())
        {
             // The query will return the password of the location chosen
             cmd.CommandText = "Select Password FROM UserAccounts WHERE Location = @location";
 
             // No need to use .ToString() since the Text properties are
             //    already strings.
             cmd.Parameters.AddWithValue("@location",cmbLocation.Text);

             con.Open();

             // ExecuteScalar returns only the first column of the first row
             //    from the query.  We are only returning one column and one row
             //    so ExecuteScalar fits our needs.
             string dbPassword = Convert.ToString(cmd.ExecuteScalar());

             if (dbPassword == txtPassword.Text)
                MessageBox.Show("Logged in Successfully");
             else
                MessageBox.Show("!!! Please Check the Password");
        }
    }
}

[jokertin92]

eclipsed4utoo, on 25 March 2010 - 05:36 AM, said:

this should work for you

private void btnlogin_Click(object sender, EventArgs e)
{
    // checks the combobox and textbox.  This should
    //    be done before you even do the database query.
    if (string.IsNullOrEmpty(cmbLocation.Text) || string.IsNullOrEmpty(txtPassword.Text))
    {
         MessageBox.Show("Location / Password must not be Empty");
         return;
    }

    using (SqlConnection con = new SqlConnection(Helper.ConnectionString))
    {
        using (SqlCommand cmd = con.CreateCommand())
        {
             // The query will return the password of the location chosen
             cmd.CommandText = "Select Password FROM UserAccounts WHERE Location = @location";
 
             // No need to use .ToString() since the Text properties are
             //    already strings.
             cmd.Parameters.AddWithValue("@location",cmbLocation.Text);

             con.Open();

             // ExecuteScalar returns only the first column of the first row
             //    from the query.  We are only returning one column and one row
             //    so ExecuteScalar fits our needs.
             string dbPassword = Convert.ToString(cmd.ExecuteScalar());

             if (dbPassword == txtPassword.Text)
                MessageBox.Show("Logged in Successfully");
             else
                MessageBox.Show("!!! Please Check the Password");
        }
    }
}

That's fine, but I don't get answer for doubt..

Anybody clear why does the if state is not working in Application?..

[eclipsed4utoo]

can you explain what your problem is? Are you getting an error message? If so, what error? If not, what is the application doing vs. what you expect it to do. Have you tried breakpointing and debugging to see what the values of the variables are?

[eclipsed4utoo]

are you still using your original code, or my code?