[Precaseptica]

Hey guys.

Trying to work out how best to output different variables in my while-loop. This is what I have so far:

	
<?php			
$i	=	1;
				
while($att_count < 4)
{
?>
<p>#<?php echo $i ?>:
<input type="file" name="<?php echo "pic" .$i ?>" /></p>
<?php
$att_count++;
$i++;
?>

The point here is obviously to change the $_POST (or rather $_FILES, as in this case) value for the file-input-box every time the while loop runs through, but this does not work.

Any suggestions?

This post has been edited by Precaseptica: 07 June 2010 - 11:43 AM

[CTphpnwb]

That hurts my eyes! Why not do something simpler, like this?

for($att_count = 0; $att_count < 4; $att_count++)
{
	echo '<p>#'.$att_count.'<input type="file" name="pic'.$att_count.' /></p>';
}

[mahcuz]

You can do many things in the different parts of a for loop. For example:

for ($a = 0, $b = 10; $a < $b; ++$a, --$B)/>
{
   print "a: $a - b: $b\n";
}

[Precaseptica]

CTphpnwb, on 07 June 2010 - 10:57 AM, said:

That hurts my eyes! Why not do something simpler, like this?

for($att_count = 0; $att_count < 4; $att_count++)
{
	echo '<p>#'.$att_count.'<input type="file" name="pic'.$att_count.' /></p>';
}

Because my variable $att_count is not 0 from the start, but a value between 1 and 4, because I don't like echoing out forms within php tags, and because it still doesn't solve the issue. Your name="pic'.$att_count'" will attempt to do the same thing I'm doing, and it won't work.

There should be no difference to that and [name="x<?php echo $incremented_value ?>"]

[Precaseptica]

mahcuz, on 07 June 2010 - 11:15 AM, said:

You can do many things in the different parts of a for loop. For example:

for ($a = 0, $b = 10; $a < $b; ++$a, --$B)/>
{
   print "a: $a - b: $b\n";
}

Indeed, but it's a name-value within a form I need to create as a posted value, different from the last time it ran through, and I can't quite figure out how your advice should help me do that.

What I have is, let's say 3 different pictures that will be uploaded, and the name="whatever" within the form needs to have a new name for each time it runs through the loop. So with that in mind, I have to crack the issue of how to make the name be different in each loop. I guess I could just make it with numbers, I don't know.

[webpeater]

Precaseptica, on 07 June 2010 - 07:24 PM, said:

mahcuz, on 07 June 2010 - 11:15 AM, said:

You can do many things in the different parts of a for loop. For example:

for ($a = 0, $b = 10; $a < $b; ++$a, --$B)/>
{
   print "a: $a - b: $b\n";
}

Indeed, but it's a name-value within a form I need to create as a posted value, different from the last time it ran through, and I can't quite figure out how your advice should help me do that.

What I have is, let's say 3 different pictures that will be uploaded, and the name="whatever" within the form needs to have a new name for each time it runs through the loop. So with that in mind, I have to crack the issue of how to make the name be different in each loop. I guess I could just make it with numbers, I don't know.

I guess you want the html attribute name = "" to be different for every image ?
Yould add them in an array

$img_names = array('test img 1', 'test img 2');
for($i = 1; $i < $numberOfImages; $i++) {
    echo '<img src="img'.$i.'.jpg" name="'. $img_names[$i-1]. '" />';
}

Is this something you mean ?

This post has been edited by webpeater: 07 June 2010 - 12:33 PM

[Precaseptica]

webpeater, on 07 June 2010 - 11:32 AM, said:

I guess you want the html attribute name = "" to be different for every image ?
Yould add them in an array

$img_names = array('test img 1', 'test img 2');
for($i = 1; $i < $numberOfImages; $i++) {
    echo '<img src="img'.$i.'.jpg" name="'. $img_names[$i-1]. '" />';
}

Is this something you mean ?

Right, this seems like it would work. But how do I call the values out with $_FILES?

$_FILES['img_names'][0] ?

[webpeater]

Precaseptica, on 07 June 2010 - 07:44 PM, said:

webpeater, on 07 June 2010 - 11:32 AM, said:

I guess you want the html attribute name = "" to be different for every image ?
Yould add them in an array

$img_names = array('test img 1', 'test img 2');
for($i = 1; $i < $numberOfImages; $i++) {
    echo '<img src="img'.$i.'.jpg" name="'. $img_names[$i-1]. '" />';
}

Is this something you mean ?

Right, this seems like it would work. But how do I call the values out with $_FILES?

$_FILES['img_names'][0] ?

The filename of an uploaded file is always $_FILES['name_of_input_where_file_uploaded']['name']
I don't know how you are storing your files ?

Give us the code you are using now

This post has been edited by webpeater: 07 June 2010 - 12:52 PM

[Precaseptica]

webpeater, on 07 June 2010 - 11:51 AM, said:

Precaseptica, on 07 June 2010 - 07:44 PM, said:

webpeater, on 07 June 2010 - 11:32 AM, said:

I guess you want the html attribute name = "" to be different for every image ?
Yould add them in an array

$img_names = array('test img 1', 'test img 2');
for($i = 1; $i < $numberOfImages; $i++) {
    echo '<img src="img'.$i.'.jpg" name="'. $img_names[$i-1]. '" />';
}

Is this something you mean ?

Right, this seems like it would work. But how do I call the values out with $_FILES?

$_FILES['img_names'][0] ?

The filename of an uploaded file is always $_FILES['name_of_input_where_file_uploaded']['name']
I don't know how you are storing your files ?

Give us the code you are using now

I don't see how that would help, but sure:

<input type="file" name="<?php echo $img[$i-1] ?>" />

Calling it with:

$pic1 = $_FILES['img'];

Try and examplify how you would call your own name-tag, with your prior example img_names[$i-1]

[webpeater]

Precaseptica, on 07 June 2010 - 07:57 PM, said:

I don't see how that would help, but sure:

<input type="file" name="<?php echo $img[$i-1] ?>" />

Calling it with:

$pic1 = $_FILES['img'];

Try and examplify how you would call your own name-tag, with your prior example img_names[$i-1]

You can not call one image in that way.
You have $_FILES['img1'], $_FILES['img2'], ... depends on how many inputs you display and how many are filled in.

But can you explain to us, what you are trying to do ?

You want to upload images, and than output all the names of these images ?

[Precaseptica]

webpeater, on 07 June 2010 - 12:05 PM, said:

Precaseptica, on 07 June 2010 - 07:57 PM, said:

I don't see how that would help, but sure:

<input type="file" name="<?php echo $img[$i-1] ?>" />

Calling it with:

$pic1 = $_FILES['img'];

Try and examplify how you would call your own name-tag, with your prior example img_names[$i-1]

You can not call one image in that way.
You have $_FILES['img1'], $_FILES['img2'], ... depends on how many inputs you display and how many are filled in.

But can you explain to us, what you are trying to do ?

You want to upload images, and than output all the names of these images ?

Well, what I did was I created a forum, with the option to attach images to posts. Now that's working fine, but it's a bit tricker to add the same functionality to the "edit post" feature. First of all, the amount of images you can upload has to be restricted by how many are already attached to that post. This is the reason for the $acc_count variable.
So what I'm doing with this exact piece is to try and create a loop, restricted by how many images are already attached to the post, running as many times as there are spots available for pictures, and then posting the pictures uploaded into the db, storing them in an upload folder and thereby making them a part of the shown material in the thread.

I think I see how you're doing it now, though. So I will try and tinker a bit with what information I have from here, and make it work. The code is MASSIVE because of lack of structuring on my behalf, so I wouldnt want to expose you to all of it.

[webpeater]

Go a head and play with the info you got.

But you can use the $acc_count in a different way.
You did
while($acc_count < $some_number {

$acc_count++;
}

But you could make it easier:
for($i = 1; $i <= ($some_number-$acc_count); $i++) { ... }

In that way you could loop easy over input1, input2, ... like you read in other posts.

[mahcuz]

BTW, naming your file inputs numerically isn't the best way to go about this. Instead, name them all the same and append "[]" to them. When you do that, PHP will treat them as an array. You can then:

foreach($_FILES as $key => $file) {
    print $file['name']; // etc
}

[Precaseptica]

webpeater, on 07 June 2010 - 12:51 PM, said:

Go a head and play with the info you got.

But you can use the $acc_count in a different way.
You did
while($acc_count < $some_number {

$acc_count++;
}

But you could make it easier:
for($i = 1; $i <= ($some_number-$acc_count); $i++) { ... }

In that way you could loop easy over input1, input2, ... like you read in other posts.

Yeah, this seemed smarter, so I followed your advice.

My code is still not working though. I'm using:

<input type="file" name="<?php echo $img[$i-1] ?>" />

And calling with:

$pic1		=	$_FILES['img0'];

But it's returning nothing when I killed the script with die($pic1)

[Precaseptica]

mahcuz, on 07 June 2010 - 01:27 PM, said:

BTW, naming your file inputs numerically isn't the best way to go about this. Instead, name them all the same and append "[]" to them. When you do that, PHP will treat them as an array. You can then:

foreach($_FILES as $key => $file) {
    print $file['name']; // etc
}

Agreed.

So I changed it to:

<input type="file" name="pic[]" />

Calling it with:

$pic1		=	$_FILES['pic'];

Still doesn't output anything though.