[aaron1178]

Hey all,
i have these pages right:
Classes.php

<?php
class attack
{
function bow()
{
include "/attack_bow.php";
$bow = new bow;
$i = $bow->calc_distance();
return $i;
}
}
?>

attack_bow.php

<?php
class bow
{
function calc_distance()
{
function stuff goes here
return $variable
}
function him()
{
function stuff goes here;
return $variable;
}
}
?>

test.php

<?php
include "classes.php";
$h = new attack;
$h->bow();
?>

Now my question is, can i call the him function with like

$h->bow()->$bow->him();

or will i have to add variables.if statements and all that

Thanks Aaron1178

[CTphpnwb]

Wouldn't it be better to let the controller decide what methods of what object to call?

[aaron1178]

well no, because i want to be able to choose witch funtions to control lol,
i want to choose for example

$h->bow()->calc_distance();
$h->bow()->him();

and like that, but im unable to know how

Please help, i have tryed heaps of ways, but Unsuccessful.

Thanks Aaron1178

[mahcuz]

If you return the $bow instance from your attack::bow() method, you could.

class attack {
    function bow() {
        $bow = new bow;
        return $bow;
    }
}

/** bow's class definition [...] */

$h = new attack;
$h->bow()->him();

Mark.

[aaron1178]

Ah ok Cheers,
But what if i wanted to add perameters to bow() function, to parse on to him() function.
Like if bow() was to construct my thing

Thanks Aaron1178

[mahcuz]

Then pass them as you would normally.

class attack {
    function bow($param1, $param2) {
        $bow = new bow($param1, $param2);
        return $bow;
    }
}

/** bow's class definition [...] */

$h = new attack;
$h->bow()->him();

I must say, though, this design is somewhat lacking.

[aaron1178]

ah ok, thanks,
What do you mean, lacking,
like in code or what?
because if you mean with code, this is a beta of it and im not displaying the full code, e,g: im not showing the function guts lol. But im only new to OOP, i cant expect to be the best(Not yet anyway).

My idea when its finished, its going to quit sophisticated.

As i said, im only new to OOP and there are no "Good" tutorials on this matter.

Thanks Aaron1178

[mahcuz]

Well, for one, I don't understand why the 'attack' class has a 'bow' function that returns an object of type 'bow'. Seems a little convoluted. Plus, what happens when you add more attacks? You have to keep adding code. In this instance, you might want to check out what we call a Factory Method; it decides for you which object should be instantiated, based on some information you give it.

class AttackFactory {
    public static function create($type) {
        if (!class_exists($type)
             trigger_error("Attack class $type does not exist", E_USER_ERROR);
        return new $type;
    }
}

/** rest of code */

$bow = AttackFactory::create('bow');

However, I don't really know what's going on with your code, so I'm implying a few things.

Mark.

P.S. There are lots of good books on OOP. OOP is a concept, a paradigm, and, as such, is not tied to a specific language or syntax - the skills are transferable.

[aaron1178]

Ahk cool
but i was goin to have it like this

<?php
class attack
{
function bow()
{
include "/attack_bow.php";
$bow = new bow;;
return $bow;
}
function spell()
{
include "/attack_spell.php";
$spell = new spell;
return $spell;
}
}
?>

Something like that, im totally new to OOP, but im and Php-Master(So i reckon )
So im just trying to make the code as easy to read by me lol

I like the factory method, but im trying to use my own style of coding

Thanks Aaron1178

[aaron1178]

sorry internet timed out

This post has been edited by aaron1178: 14 June 2010 - 05:45 AM

[aaron1178]

\sorry, my internet is going real slow and it timed out

This post has been edited by aaron1178: 14 June 2010 - 05:44 AM

[mahcuz]

Having your own style is cool. Ignoring tried-and-tested methods of programming (design patterns), however, is counter-productive. But if you want to reinvent the wheel...

[aaron1178]

ahk, i didnt ignore it, i just dont understand it
only write what i understand lol, dont get me wrong, i know its good code, but to write code you must first understand code,
if you get my point of view.

Thanks Aaron1178