[sh1n3]

Factorial.java:19: 'void' type not allowed here
return n*fact(n-1);
       ^
1 error
Press any key to continue . . .

That is the error message that I am getting. It's the first time I've ever seen anything like it!
The code is right below.

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
class Factorial {
  public static void fact(int x) {
    int f=1;
    for (int i=1;i<x;i++){
      f*=i;
    }
    System.out.println(f);
  }
  public static int factr(int n) {
    if (n==1)
    {
      return n;
    }
    else
    {
      return n*fact(n-1);
    }
  }
  public static void main(String[] args)throws IOException {
    BufferedReader br=new BufferedReader(new InputStreamReader(System.in));
    System.out.print("Enter a Number : ");
    int input=Integer.parseInt(br.readLine());
    fact(input);
    int output=factr(input);
  }
}

[bcranger]

Your problem is that you are trying to return n * fact

fact is of type void...you need a number type

you declared the fact method as void so it doenst return anything

[Locke]

On that line, you want to call factr, not fact.

return n*factr(n-1);

That should do it.

[sh1n3]

WOW solved, thanks....problems of a letter!!

[Dogstopper]

yah fact() is your iterative solution. factr() is your recursive solution. Both should be independent and not reference the other as Locke pointed out.

[jeremejazz]

good!