[eiarzate]

I'm having a hard time sorting the random array for shuffling cards. Here is my code.
Any help is appreciated thank you.

public void shuffle() {

        boolean check[] = new boolean[52];

        for (int i = 0; i < check.length; i++) {
            check[i] = false;
        }


        for (int i = 0; i < cards.length; i++) {

            int random = (int) Math.random() * 52;

            if (check[random] == true) {

                random = (int) Math.random() * 52;

            }

            check[random] = true;

            System.out.println(cards[random].getSuit() + " " + cards[random].getValue());
            shuffledCards[random].setSuit(cards[random].getSuit());
            shuffledCards[random].setValue(cards[random].getValue());

        }
    }

[macosxnerd101]

Perhaps it would be easier to utilize the Collections.shuffle() method by converting your array to a List and back:

List<Integer> list = Arrays.asList(new Integer[]{1,2,3,4,5});
Collections.shuffle(list);
Integer[] x = list.toArray(new Integer[list.size()]);

[Codebug]

macosxnerd offers a nice, clean solution. However if you want, you could also use a Random number generator from the Random class to generate a number between 0 and 51 which are your array bounds. For each iteration, swap the value of the array at the loop variable with the value of the array at the random number:

swap array[ loopVariable ] with array[ randomNumber ]

I haven't sat down and tried this, because I'm in a hurry, but I'm pretty sure it will work. Just another possible way of doing it.

[pbl]

or use can use an ArrayList of cards
put all your cards into it
and randomly retreive cards from it

// Deck of cards
Cards[] card = new Cards[52];
// init it and put it in an ArrayList
ArrayList<Cards> al = new ArrayList<Card>();
for(int i = 0; i < 52; i++) {
   card[i] = new Card(....
   al.add(card[i]);
}

// Random
Randon ran = new Random();
// get a deck of five cards
Cards[] deck = new Card[5];
for(int i = 0; i < deck.length; i++) {
   int index = ran.nextInt(al.size());    .. random pos in the 52, 51, 50... lasting cards
   deck[i] = al.remove(index);
}

[x68zeppelin80x]

[Deleted by Unknown]

This post has been edited by x68zeppelin80x: 22 September 2010 - 05:11 PM

[Dogstopper]

x68zeppelin80x, how can you expect the OP to learn if you just HAND them code? Rule number 1 says "We will not do your homework for you! Do not ask us to give you code!". If you are going to just give code like that, don't just say "Here it is"; make sure you explain it.

[pbl]

And having the String[] suits and faces in the Deck class rather than in the Card class is a very poor design as far as I am concerned