[seawolf275]

I am having some difficulty with this program . I am to creat a pupkin shoot program and I thought I have it figured out. I can't seem to get out of main loop to get the equation to work out. I don't expect the answer...just some guidance. thanks
Seawolf

(attached file included)

#include <iostream>
#include <iomanip>
#include <fstream>
#include <cmath>
using namespace std;


int attempts = 0;
double computeDistance(double &Velocity , double &toRadians); // loop
double toRadians(double Angle, const double PI = acos(-1.));
double TargetDistance;
double Velocity;
double Angle;
double YourHit;
double radians;
double TargetRange;
double HiTargetRange;
double LoTargetRange;

int main() {
   cout << "Program for The Granbde Pumpkin Shoot.\n\n";
   cout << "Program by John M. Grow Cs-07-1.\n\n";

   cout<<"Enter the Target Distance.\n";
   cin >> TargetDistance;
   HiTargetRange = (TargetDistance + (TargetDistance * .001));
   LoTargetRange = (TargetDistance - (TargetDistance * .001));

   cout<<"\nYou only have 5 chances to get this right.\nSo think carefully before you enter you data.\n\n\n";

   while (attempts < 5){
   cout <<"\nEnter the velocity (speed) of the pumpkin:   ";
   cin >> Velocity;
   cout <<"Now enter the angle of the cannon:		   ";
   cin >>Angle;
   attempts ++;
   
   double YourHit = computeDistance(Velocity , toRadians); // loop

   cout << YourHit;

   }

   // end of program results   win try again lose 
   if (YourHit <= HiTargetRange && YourHit >= LoTargetRange ){
	  cout <<"\n\n	  GOOD JOB........YOU WIN\n\n";
	  return 1;
   }
	else if (attempts >= 6){
	  cout <<"\a\n\n\aGAME OVER. INSERT ANOTHER QUARTER TO CONTINUE.";
	  return 2;
	}   
}

double computeDistance(double &Velocity , double toRadians ){

   double YourHit;
   double speed;
 
   speed = pow(Velocity, 2);
   YourHit = (speed * sin(2*radians))/32.2;
   return YourHit;
}

double toRadian(double Angle, const double PI = acos(-1.)){
   double radians;
   radians = (Angle*PI)/180;
   return radians;
}

[dragonlady]

Forgive me, but I'm not sure I understand the question. I see you do have a loop in the main function, but from within that loop you are calling computeDistance, which seems to be the answer to your question (?).

However I do see a potential compiler error. In the line:
double YourHit = computeDistance(Velocity , toRadians);
you don't have a variable called toRadians. Do you mean to pass Angle.toRadians? Also, you have some inconsistencies where you're saying that the computeDistance function takes in references as parameters, but you're not actually passing it references. You might get some compiler errors from that.

[seawolf275]

What I was trying to accomplish was have the loop within main, give me a distance. The loops calls for a conversion of angles into radians; hence the second loop toRadians.

I redid the code and it works...somewhat now. For some reason when you hit attemp #6 is just ends, It doesn't cout the "END OF GAME". And my formula doesn't seem to be working well. I have attached the new code. If you could take a look at it and tell me what I am doing wrong I would appreciate it.

Thanks
seawolf

#include <iostream>
#include <iomanip>
#include <fstream>
#include <cmath>
using namespace std;

int attempts = 0;
double computeDistance(double &Velocity , double &Angle); // loop
const double PI = acos(-1.);
double toRadians(double Angle, double PI);
double TargetDistance;
double Velocity;
double Angle;
double YourHit;
double radians;
double TargetRange;
double HiTargetRange;
double LoTargetRange;

int main() {
   cout << "Program for The Granbde Pumpkin Shoot.\n\n";
   cout << "Program by John M. Grow Cs-07-1.\n\n";

   cout<<"Enter the Target Distance.\n";
   cin >> TargetDistance;
   HiTargetRange = (TargetDistance + (TargetDistance * .001));
   LoTargetRange = (TargetDistance - (TargetDistance * .001));

   cout<<"\nYou only have 5 chances to get this right.\nSo think carefully before you enter you data.\n\n\n";

   while (attempts < 5){

   cout <<"\nEnter the velocity (speed) of the pumpkin:   ";
   cin >> Velocity;
   cout <<"Now enter the angle of the cannon:		   ";
   cin >>Angle;
   attempts ++;

   if (attempts > 5){
	  cout <<"\a\n\n\aGAME OVER. INSERT ANOTHER QUARTER TO CONTINUE.";
	  return 2;
   }
   if (YourHit <= HiTargetRange && YourHit >= LoTargetRange ){
	  cout <<"\n\n\a\a	  GOOD JOB........YOU WIN\n\n";
	  return 1;
   }
   
   double YourHit = computeDistance(Velocity , Angle); // loop
   cout << YourHit;

   double angle = toRadians(Angle, PI);
   cout << angle;
   
   if (TargetDistance > YourHit){
	  YourHit = TargetDistance - YourHit;
	  cout <<"\nYou missed by:  "<<YourHit<<"\a\ntry again.\n";
   }
   if (TargetDistance < YourHit){
	   YourHit = YourHit - TargetDistance;
	   cout <<"\nYou missed by:  "<<YourHit<<"\a\ntry again.\n";
   }
   }
}	  

double computeDistance(double &Velocity , double &Angle ){

   double YourHit;
   double speed;
 
   speed = pow(Velocity, 2);
   YourHit = (speed * sin(2*radians))/32.2;
   return YourHit;
}

double toRadians(double Angle, double PI){
   double radians;
   radians = (Angle*PI)/180;
   return radians;
}

Edit: Added code tags. ~Videege

[Amadeus]

It's not printing your exit message becasue your while loop runs while the number of attempts is less than 5. Starting from a 0 point for the variable attempt, the value is 5 on the sixth attempt. As such, the loop is not run. The if statement you are using to check to see if the exit message should be displayed is inside the while loop...since the loop is not executed, the check is not performed, and the exit message not displayed. Even if the loop were run, the if statement is checking for a value greater than 5 - at that time, the value would be 5.

[seawolf275]

I finally got the program to work. Thanks for the help. If you are interested in how is looks/works it is in the attached file. Thanks again.

Seawolf