[zigurdis]

#include <iostream>

using namespace std;

int leftchild(int nodeindex) // returns the index of the left child
{
return  nodeindex *2 + 1 ;
}

int rightchild(int nodeindex) // returns the index of the right child
{
return nodeindex * 2 +2; 
}



int inorder(int *mas, int nodeindex, int i, int *arr) // a recursive function to print the nodes values, put in array
{
if (mas[nodeindex] == 0) return 0 ;
inorder(mas, leftchild(nodeindex), i, arr) ;
arr[i]=mas[nodeindex];

inorder(mas,  rightchild(nodeindex), i, arr);
}
     
     
int main () {

  
 int mas[93]={2,3,1,9,8,7,6,5};
 int arr[9];
inorder(mas, 0, 0, arr);

for (int k=0; k<10; k++)
cout <<"inorder " << arr[k] << endl;

    system("pause");
  return 0;
}

    

hey, all. this is my code for binary tree in array, for inorder traverse, i want put these nums in array, in inorder sequence,,,but it is not work
when i write cout, it works...there is somethink with i , i dont konow what

[r.stiltskin]

Your traversal of the tree is correct, but when you write to the output array you are always writing to the same element arr[0]. You can't send a constant array index to the recursive function. That index must be incremented by each node after it writes its own data. You need to send a reference (or pointer) to an index variable.

Added a few comments in the code below:

#include <iostream>

using namespace std;

int leftchild(int nodeindex) // returns the index of the left child
{
    return  nodeindex *2 + 1 ;
}

int rightchild(int nodeindex) // returns the index of the right child
{
    return nodeindex * 2 +2;
}


// changed i to a reference because left children must be able to increment it before node writes its own data
int inorder(int* mas, int nodeindex, int& i, int* arr) // a recursive function to print the nodes values, put in array
{
    if (mas[nodeindex] == 0) return 0 ;
    inorder(mas, leftchild(nodeindex), i, arr) ;
    arr[i]=mas[nodeindex];
                       
    inorder(mas,  rightchild(nodeindex), ++i, arr); // pre-incrementing the array index i for the right child
}


int main () {


    int mas[93]={2,3,1,9,8,7,6,5};  // only 8 non-zero elements
    int arr[9]={0}; // initializing arr; otherwise last element will be garbage
    int i = 0; // added index variable to pass to recursive function
    inorder(mas, 0, i, arr);

    for (int k=0; k<9; k++)   // k<9: you were overrunning the end of the array
        cout <<"inorder " << arr[k] << endl;

    system("pause");
    return 0;
}

[zigurdis]

thanks