[srijani]

Friendz i previously tried using the shortest code to reverse a string using c++ in the c-free ide and t worked fine but now i am trying it in gcc and i get a segmentation fault error. in windows, running the same in VS2010 gives a stack overflow error..

#include<stdio.h>

void revstr(char *s){
if(*s){
revstr(s+1);
putchar(*s);
}
}
int main(){
char *s;
gets(s);
revstr(s);
return 0;
}

$ ./a.out
srij
Segmentation fault

MOD EDIT: When posting code...USE CODE TAGS!!!

This post has been edited by JackOfAllTrades: 03 January 2011 - 05:59 AM

[Salem_c]

> char *s;
> gets(s);
1. Your pointer doesn't point anywhere (it is uninitialised).
2. You used gets() - NEVER use gets() -> http://sourceforge.n....php?title=Gets

[ButchDean]

There is a short way to do it (O(n/2)) that I posted not too long ago. I don't think using standard functions count.