[dominion_vortar]

Hi,

I've been doing Java for a little while, but all of my small programs so far have had just one class. I'm currently working on a project, and I would like to use one class called GUI for the interface, and others for various functions, in this case the login code.

Right now, the login code is in the GUI class, my main class.

public void actionPerformed(ActionEvent e)
	{
		if(e.getSource() == btnLogin)
		{
			String user = txtUser.getText();
			char[] pass = txtPass.getPassword();
			
			if (user.equals("John") && isPasswordCorrect(pass)) 
			{
				JOptionPane.showMessageDialog(null, "Access granted", "Login", JOptionPane.INFORMATION_MESSAGE);
				Tabs.setEnabledAt(0,false);
				Tabs.setEnabledAt(1,true);
				Tabs.setSelectedIndex(1);
            } 
			else 
			{
				txtUser.setText("");
				txtPass.setText("");
				txtUser.requestFocusInWindow();
				JOptionPane.showMessageDialog(null, "Login failed. Please check your username and password before trying again.", "Login Failed", JOptionPane.ERROR_MESSAGE);
            }

            //Zero out the possible password, for security.
            Arrays.fill(pass, '0');

		} 
	}
	
	private static boolean isPasswordCorrect(char[] pass) 
	{
        boolean isCorrect = true;
        char[] correctPassword = { 'h', 'o', 'n', 'e', 'y', 'c', 'o', 'm', 'b' };

        if (pass.length != correctPassword.length) 
		{
            isCorrect = false;
        } 
		else 
		{
            isCorrect = Arrays.equals (pass, correctPassword);
        }

        //Zero out the password.
        Arrays.fill(correctPassword,'0');

        return isCorrect;
    }

However, I would like this to be in the Login class to keep the GUI class strictly for the code of the interface itself. How do I take this action listener from GUI.class to Login.class so that is still functions when btnLogin is pressed? I'm not very well versed on using multiple classes.

Many thanks, any guidance would be appreciated.

[Dogstopper]

So, move it into another class and add an instance of that class as an actionListener.

class Handler implements ActionListener {
    // Your actionPerformed() method here
}

class GUI ... {
    ...
    public GUI() {
        ...
        addActionListener(new Handler());
        ...
    }
    ...
}

[ShaneK]

addActionListener(new Handler());

(correction )

Also, beware that trying to access anything created in the GUI class can't be easily accessed from other classes. (Though, that's not to say it's impossible...)

Yours,
Shane~

[Dogstopper]

Unless you make it an inner class. Then, that's certainly an option.

[dominion_vortar]

Ah ok, so if I had, say

class Login implements ActionListener 
{
	public void actionPerformed(ActionEvent e)
  {
        //code
  }
}

It would be able to do the same job it was doing in the main GUI class?

And then, am I correct in assuming that I would have to place the code

        addActionListener(new Login());

In the GUI class?

[Dogstopper]

Yes, assuming you didn't need any information from the GUI class. If you do, you can pass them into the constructor and handled in the Login class or in a subclass.

[dominion_vortar]

Ok, thanks.

So, if I needed, say "user" and "pass" from the GUI, I could pass them with...

addActionListener(new Login(text, pass));

And then use them in the other class? Makes enough sense!

[Dogstopper]

Precisely. If you ever needed to change those values, just put a method in the class to change it. Then, instead of making it an anonymous object, you can make a full object (normally created objects).

[dominion_vortar]

Dogstopper, on 13 January 2011 - 02:19 PM, said:

Precisely. If you ever needed to change those values, just put a method in the class to change it. Then, instead of making it an anonymous object, you can make a full object (normally created objects).

Ok, thanks for your help I appreciate it.

Will take a closer look at modifying what I have and get things working!

[Dogstopper]

You're welcome! Come back if you have any other questions.