[Azardokht]

hi there, I have 2 sorted int arrays and I wanna joint them in a way they remain sorted. here is a method in a class of my project, but it doesn't work:

public void Array_Set_Value()
        {
            int N=0;
            int [] finalarray = new int [Firstarray.Length + Secondarray.Length];
            for (int i = 0; i < Firstarray.Length; i++)
            { 
                for (int j=0; j<Secondarray.Length; j++)
                {
                    if (Firstarray[i]< Secondarray[j])
                    {
                        N=i+1;
                        Firstarray.CopyTo(finalarray, 0);
                        finalarray.SetValue(Secondarray[i], N);
                    }
                }
            }
        }

MOD EDIT: When posting code...USE CODE TAGS!!!

This post has been edited by JackOfAllTrades: 14 January 2011 - 08:45 AM

[Kilorn]

How exactly is to "not working". Are you getting any errors, or are the results just not what you'd expect?

[baavgai]

// fine, this makes sense
int [] finalarray = new int [Firstarray.Length + Secondarray.Length];
for (int i = 0; i < Firstarray.Length; i++) { 
	for (int j=0; j<Secondarray.Length; j++) {
	// you do understand that the code in here will get executed
	// Firstarray.Length * Secondarray.Length times?

You want something more like:

int pos=0, i=0, j=0;
while (i < Firstarray.Length && j<Secondarray.Length) {
	// find the smaller
	// add it to the list and inc i OR j
	pos++;
}
// add the left over from the array you didn't reach the end of

[tinase]

I am not experienced in C++, If you post the whole code with all the declaration and sorting codes then I will be able to help you right now

[Mitja Bonca]

Check out this code how to join arrays into one and sorting it:

        private void method()
        {
            int[] array1 = new int[] { 4, 3, 8, 12, 15, 6 };
            int[] array2 = new int[] { 5, 7, 2, 13, 9, 1 };
            //joining them:
            int[] array3 = new int[array1.Length + array2.Length];
            array1.CopyTo(array3, 0);
            array2.CopyTo(array3, array1.Length);

            //sortinng array3:
            Array.Sort(array3);
        }

[suckedforu]

tinase, on 14 January 2011 - 08:42 AM, said:

I am not experienced in C++, If you post the whole code with all the declaration and sorting codes then I will be able to help you right now

you are very helpfull you deserve a +

[skyhawk133]

suckedforu, on 15 January 2011 - 09:38 AM, said:

tinase, on 14 January 2011 - 08:42 AM, said:

I am not experienced in C++, If you post the whole code with all the declaration and sorting codes then I will be able to help you right now

you are very helpfull you deserve a +

Hey dumb ass... you're all posting from the same IP, don't be fucking stupid up-voting each other. I'll move you to the rep abuse group if you continue to do it. NO REP FOR YOU!!

[Mitja Bonca]

LOL... what ppl dont invent...