[Fungle]

Well, What I did is make an if statement, for the 30 day months, You could simply use three of these to cut down the amount of cases you have. there could be a better way of doing it though I guess..

if (month == 4 | month == 6 | month == 9 | month == 11 && day < 0 || day > 30)
            {
                Console.WriteLine("False Date");
            }

I tested it and it works just as well

This post has been edited by Fungle: 16 January 2011 - 07:04 AM

[Fungle]

Then you should always do as your teacher says

You could try to clean up your comments a bit to reduce the lines

This post has been edited by Fungle: 16 January 2011 - 07:08 AM

[JackOfAllTrades]

if (month == 4 | month == 6 | month == 9 | month == 11 && day < 0 || day > 30)

You're mixing bitwise-OR and boolean OR here.

[Sergio Tapia]

Disclaimer: Always do what your teacher says when you're in class.

You can also create an extension method that wraps all that fugly code away from your main train-of-thought-code:

public static bool IsValidDate(this int date)
{
    //Do your magic here and return true or false.
}

Then in your main code:

day = int.Parse(Console.ReadLine());
if(day.IsValidDate)
{
    //blabla
}

It would be best to just create a DateTime object and then check that. I even think the DateTime object even does that for you!

[JackOfAllTrades]

You could put all the 31-day months and 30-day months into one multi-case statement each:

switch(month)
{
    case 4:
    case 6:
    case 9:
    case 11:
        // Handle 30-day month
        break;
    etc.
}

[Tryparse]

One quick & easy way to shorten the code would be to use fall through with empty case labels:

case 4:
case 6:
case 9:
case 11:
    if (day < 0 || day > 30)
    {
    Console.WriteLine("False date");
    }
    break;

This will catch cases 4, 6, 9, and 11 in the code for case 11.

Edit: Doh! JackOfAllTrades typed faster than me

This post has been edited by Tryparse: 16 January 2011 - 07:47 AM

[Nick-Nurgen]

Actually I would suggest you to create an enumeration but i think u dont know it yet. And one more thing. By the way for now, correct the If method statement, day cannot be 0. Write <=0 or <1

[eclipsed4utoo]

Nick-Nurgen, on 16 January 2011 - 02:55 PM, said:

Actually I would suggest you to create an enumeration but i think u dont know it yet. And one more thing. By the way for now, correct the If method statement, day cannot be 0. Write <=0 or <1

Why would you use an enum to determine if a given month/day/year is a valid date?

The simplest way would be to use the DateTime constructor. If it's not a valid date, it will throw an exception.

[Nick-Nurgen]

Quote

The simplest way would be to use the DateTime constructor

Quote

Why would you use an enum to determine if a given month/day/year is a valid date?

I understand it is the simplest way and has already been suggested. And many efficient ways can be found by digging into the details. However this person said he's been programming for less than 1 month and the teacher will find it unacceptable if he/she sees the code he/she hasn't yet taught.
So the simplest solution is to forget about the sophisticated tools right now and help him find an efficient code within his collected knowledge. I also rejected enumeration, since im not sure if he's aware of.

This post has been edited by Nick-Nurgen: 16 January 2011 - 12:48 PM

[eclipsed4utoo]

He's already been given an efficient answer for what he has been required to use(switch statements).

I would like to know how I could use enum(s) to determine the validity of a month/day/year combination.

[JackOfAllTrades]

The best way to use an enum here would be to get rid of the magic numbers.

enum Months { January = 1, February, March, April, May, June, July, August, September, October, November, December };

switch(month)
{
    case Months.April:
    case Months.June:
    case Months.September:
    case Months.November:
        // Handle 30-day month
        break;
}