[dannybarh]

Hi all,

i have been trying to insert data into my db,but it wont work.

can anyone tell me why,pls.


HTML form

<form action="insert.php?nav=mail" method="post"  enctype=multipart/form-data>
                        <table width="100%" border="0" align="left" cellpadding="1" cellspacing="1" class="bodytxt">
                          <tr>
                            <td height="30" colspan="3" align="left" bgcolor="#999999"><strong><font color="#666666">&nbsp;&nbsp;</font><span class="style2"><font color="#FFFFFF">Compose Mail </font></span> </strong></td>
                          </tr>
                          <tr>
                            <td>&nbsp;</td>
                          </tr>
                          <tr>
                            <td><fieldset>
                              <legend><span class="style1">Recepent's Address </span></legend>
                              <table width="100%" border="0" cellpadding="1" cellspacing="1" class="bodytxt">
                                <tr>
                                  <td width="29%" align="right">To:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</td>
                                  <td width="71%"><label>
                                    <input name="username" type="text" id="username" class="bodytxt" size="60" maxlength="200" />
                                  </label></td>
                                  
                                </tr>
                                <tr>
                                  <td width="29%" align="right">Subject:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</td>
                                  <td><input name="title" type="text" id="title" class="bodytxt" size="60" /></td>
                                  
                                </tr>
                              </table>
                            </fieldset> </td>
                          </tr>
                          <tr>

                            <td height="203"><table width="90%" border="0" align="center" cellpadding="5" cellspacing="1" bordercolor="#666666" class="bodytxt" hspace="0">
                              <tr>
                               
                                <td width="45%" height="196" align="center" valign="top"><fieldset>
                                  <legend><span class="style1">Compose Mail Below</span></legend>
                                  <label>
                                  <textarea name="description" id="description" rows="10" cols="65"></textarea>
                                  </label>
                                </fieldset></td>
                              </tr>
                              <tr>
                                <td height="28" align="center" valign="top">&nbsp;</td>
                              </tr>
                              <tr>
                                <td height="28" align="center" valign="top"><input name="submit" type="submit" class="bodytxt"  value="Send Massage" />
&nbsp;
<input name="reset" type="reset" class="bodytxt" value="Cancel" /></td>
                              </tr>
                            </table>
							</td>
                          </tr>
                          <tr>
                           
                            <td></td>
                          </tr>
						   <tr>
						     
						     <td></td>
						     </tr>
						   <tr>
						     <td>&nbsp;</td>
						     </tr>
                        </table>
                        </form>

Below is my insert.php

<?php
session_start();
$navtype = $_GET['nav'];
include "config.php";
?>

<?php

	if($navtype == "mail")
	{
		 $username = $_POST['username'];
		 $title = $_POST['title'];
		 $description = $_POST['description'];
	 
		 $sql = ("INSERT INTO inbox (username, title, description, datesent, timesent) 
		 
		 VALUES('$username', '$title', '$description', NOW(), CURTIME(),") ;
		 mysql_query($sql);
		 
		 echo "<center><p><br><br><br><strong>The new $title has been added to the database</strong></p></form>";
	}
?>

MOD EDIT: When posting code, use CODE tags, not PHP tags or HTML tags!

This post has been edited by JackOfAllTrades: 19 February 2011 - 09:04 AM

[JackOfAllTrades]

Read this and get back to us.

[Valek]

Your insert query is malformed. You're building it as INSERT INTO inbox (username, title, description, datesent, timesent)VALUES('$username', '$title', '$description', NOW(), CURTIME(), when you should be building it as INSERT INTO inbox (username, title, description, datesent, timesent)VALUES('$username', '$title', '$description', NOW(), CURTIME()). Of course, you'd have known that if you had tested your query submission on line 18 of your presented insert.php. Most basic way to test this is changing that line to be mysql_query($sql) or die(mysql_error();, but it is generally inadvisable to leave it that way on a production server, as it presents identifying information about your database to any potential malicious users. Something like this is more advisable:

$qsuccess = mysql_query($sql);
if(!$qsuccess)
{
     error_log("Query failed.  MySQL error: " . mysql_error() . "\nQuery submitted: " . $sql . "\n", 3);
     die("There was an error with the database.  It has been logged.");
}

[dannybarh]

thanks Valek,

but when i run the code this is what i get

Parse error: syntax error, unexpected T_STRING in E:\xampp\htdocs\facelink\admin\userindex\insert.php on line 15

i check online,some think it could be a slach or something.
this is the insert.php after your replay to my problem.

am new to php/mysql,so please be ... and thanks for your help.

<?php
session_start();
$navtype = $_GET['nav'];
include "config.php";
?>

<?php

	if($navtype == "mail")
	{
		 $username = $_POST['username'];
		 $title = $_POST['title'];
		 $description = $_POST['description'];
	 
		 $sql = INSERT INTO inbox (username, title, description, datesent, timesent)VALUES('$username', '$title', '$description', NOW(), CURTIME());
		 $qsuccess = mysql_query($sql);
if(!$qsuccess)
{
     error_log("Query failed.  MySQL error: " . mysql_error() . "\nQuery submitted: " . $sql . "\n", 3);
     die("There was an error with the database.  It has been logged.");
	 
		 echo "<center><p><br><br><br><strong>The new $title has been added to the database</strong></p></form>";
	}
?>

[no2pencil]

I don't see a closing bracket for your test on the navtype variable.

[dannybarh]

no2pencil, on 20 February 2011 - 04:34 PM, said:

I don't see a closing bracket for your test on the navtype variable.

All the navtype is in the closing tag,
which one are u referring to?

[Valek]

Look at your conditionals. Count your brackets. You'll notice you have two opening brackets and one closing bracket, just as no2pencil told you.

You're also missing quotes around your query string from the looks of it.

This post has been edited by Valek: 20 February 2011 - 05:31 PM

[dannybarh]

Thanks for all your time, its been very useful and am very grateful.
Am learning very fast and am very grateful for the commitment Valek and no2pencil and others. I have gain some useful insight when it comes to these errors.

However,this is what i am getting

There was an error with the database. It has been logged.

when i run the code.

am very grateful for your concern.

<?php
session_start();
$navtype = $_GET["nav"];
include "config.php";
?>

<?php

	if($navtype == "mail")
	{
	
		 $username = $_POST['username'];
		 $title = $_POST['title'];
		 $description = $_POST['description'];
	 
		 $sql = "INSERT INTO inbox (username, title, description, datesent, timesent)
		 VALUES('$username', '$title', '$description', NOW(), CURTIME())";
		 
		 "$qsuccess = mysql_query($sql)";

		 
if(!$qsuccess)
{
     error_log("Query failed.  MySQL error: " . mysql_error() . "\nQuery submitted: " . $sql . "\n", 3);
     die("There was an error with the database.  It has been logged.");
}

		 echo "<center><p><br><br><br><strong>The new $title has been added to the database</strong></p></form>";
	
	}
?>

[no2pencil]

That's your own self coded error message.

Quote

if(!$qsuccess)
{
     error_log("Query failed.  MySQL error: " . mysql_error() . "\nQuery submitted: " . $sql . "\n", 3);
     die("There was an error with the database.  It has been logged.");
}

I would echo the $sql variable to see what the sql statement contained, & visually verify that it's correct. Most likely one of your input variables is empty, or there is a syntax error. Most likely the problem is that you THINK it should work, & have not validated the statement.

[Valek]

That error_log() line writes the actual SQL error to the log where all of your PHP errors are written (provided you have the log_errors directive on in php.ini, which you should, it will write to the error log specified in the error_log directive in php.ini). It will tell you both why the query failed, and what query it attempted to execute.

It's safe to echo the $sql variable's contents or mysql_error() when you're developing a site, but when other users are actually using it, it is unsafe because it reveals information about how your site/application is built. That is why I provided you the code I did for debugging the error, because that code is safe for a production website.

[dannybarh]

am very grateful for your concern.Thanks.

[CTphpnwb]

Ok, I'll post the obligatory warning about SQL injection attacks:
http://en.wikipedia....i/SQL_injection
http://www.dreaminco...duction-to-pdo/