[zem107]

I'm learning C#, and I created a windows forms application. Basically it's a very basic text editor called "Reiner Notes". Don't ask why I named it that because I don't know.
I know how to save a file, but I don't know how to open one. here's the code.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
using System.IO;
using System.Net;

namespace WindowsFormsApplication1
{
    public partial class ReinerNotes : Form
    {
        public ReinerNotes()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {


            if (DialogResult.OK == saveFileDialog1.ShowDialog())
            {



                string input = Text.Text;







                using (Stream stream = saveFileDialog1.OpenFile())
                {

                    saveFileDialog1.Filter = "Text Files|*.txt | All Files|*";

                    using (StreamWriter writer = new StreamWriter(stream))
                    {


                        
                        writer.Write(input);

                    }

                }
            }
        }
        private void richTextBox1_TextChanged(object sender, EventArgs e)
        {

        }

        private void saveFileDialog1_FileOk(object sender, CancelEventArgs e)
        {
           
        }

        private void button2_Click(object sender, EventArgs e)
        {

        }

        private void dateTimePicker1_ValueChanged(object sender, EventArgs e)
        {

        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }

        private void Open_Click(object sender, EventArgs e)
        {
 
        }

        private void openFileDialog1_FileOk(object sender, CancelEventArgs e)
        {

        }

        private void button1_Click_1(object sender, EventArgs e)
        {
            string Chosen_File = "";
            openFileDialog1.InitialDirectory = "C:";
            openFileDialog1.Title = "Open a File";
            openFileDialog1.FileName = "";
            openFileDialog1.Filter = "Text Files|*.txt";
            if (openFileDialog1.ShowDialog() != DialogResult.Cancel)
            {
                Chosen_File = openFileDialog1.FileName;
                richTextBox1_TextChanged.LoadFile(Chosen_File, RichTextBoxStreamType.PlainText);
            }
        }
    }
}

I am able to get the save working but I can't open up a text file.
Could you please give some that works then walk me through it. Thanks in advance.

[tlhIn`toq]

There are links below for read and write tutorials. This is a common topic/question.

I think it would be in your interest to work through a book, lessons, tutorials etc. before trying to rush out and build a program from scratch with no experience.

A person does not say "I've never played an instrument nor can I read sheet music: I think I'll go write an opera as a self-teaching experience."

---

Standard resources, references and suggestions for new programmers.

---

I would recommend you start with "Hello World" just like the other million+ coders out there. Then work your way up to the more advanced tasks like this.

The problem with taking on large, complex tasks like this when you are new to coding is that

• it will frustrate you to the point of quitting,
  
• you don't know enough about coding to know where to start or in what direction to design your program
  
• You risk learning via the 'Swiss cheese' method where you only learn certain bits and pieces for the one project but have huge holes in your education.

I am going to guess that you are trying to teach yourself C# without much guidance, a decent book or without knowing where to look. Sometimes just knowing where to look can make all the difference. Google is your friend.
Search with either "C#" or "MSDN" as the first word: "MSDN Picturebox", "C# Custom Events", "MSDN timer" etc.

But honestly, just typing away and seeing what pops up in Intellisense is going to make your self-education take 20 years. You can learn by trying to reverse engineer the language through banging on the keyboard experimentation - or you can learn by doing the tutorials and following a good "How to learn C#" book.

Free editions of Visual Studio 2010

May I suggest picking up a basic C# introductory book? There are so many great "How do I build my first application" tutorials on the web... There are dozens of "Learn C# in 21 days", "My first C# program" type books at your local book seller or even public library.

D.I.C. C# Resource page Start here
Intro to C# online tutorial then here...
C# control structures then here.
MSDN Beginner Developer video series
MSDN video on OOP principals, making classes, constructors, accessors and method overloading
MSDN Top guideline violations, know what to avoid before you do it.
Design patterns as diagrams

The tutorials below walk through making an application including inheritance, custom events and custom controls.
Bulding an application - Part 1
Building an application - Part 2
Quick and easy custom events
Passing values between forms/classes

Working with environmental variables
'Why do we use delegates?' thread

Debugging tutorial
Debugging tips
Debugging in detail
Great debugging tips
It still doesn't work, article

Build a Program Now! in Visual C# by Microsoft Press, ISBN 0-7356-2542-5
is a terrific book that has you build a Windows Forms application, a WPF app, a database application, your own web browser.

C# Cookbooks
Are a great place to get good code, broken down by need, written by coding professionals. You can use the code as-is, but take the time to actually study it. These professionals write in a certain style for a reason developed by years of experience and heartache.

Microsoft Visual Studio Tips, 251 ways to improve your productivity, Microsoft press, ISBN 0-7356-2640-5
Has many, many great, real-world tips that I use all the time.

Writing a text file is always one of the first things people want to do, in order to store data like high-scores, preferences and so on
Writing a text file tutorial.
Reading a text file tutorial.

And everyone always wants to connect to a database, right out of the gate so
Database tutorials right here on DIC

These are just good every-day references to put in your bookmarks.
MSDN C# Developers Center with tutorials
Welcome to Visual Studio

Have you seen the 500+ MSDN Code Samples? They spent a lot of time creating samples and demos. It seems a shame to not use them.

Let me also throw in a couple tips:

• You have to program as if everything breaks, nothing works, the cyberworld is not perfect, the attached hardware is flakey, the network is slow and unreliable, the harddrive is about to fail, every method will return an error and every user will do their best to break your software. Confirm everything. Range check every value. Make no assumptions or presumptions.
  
• Take the extra 3 seconds to rename your controls each time you drag them onto a form. The default names of button1, button2... button54 aren't very helpful. If you rename them right away to something like btnOk, btnCancel, btnSend etc. it helps tremendously when you make the methods for them because they are named after the button by the designer.
  btnSend_Click(object sender, eventargs e) is a lot easier to maintain than button1_click(object sender, eventargs e)
  
• You aren't paying for variable names by the byte. So instead of variables names of a, b, c go ahead and use meaningful names like Index, TimeOut, Row, Column and so on. You should avoid 'T' for the timer. Amongst other things 'T' is commonly used throughout C# for Type and this will lead to problems. There are naming guidelines you should follow so your code confirms to industry standards. It makes life much easier on everyone around you, including those of us here to help. If you start using the standards from the beginning you don't have to retrain yourself later.
  
• Try to avoid having work actually take place in GUI control event handlers. It is usually better to have the GUI handler call other methods so those methods can be reused and make the code more readible.
  

  btnSave(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  SaveMenuItem(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  SaveContextMenu(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  Form1_Closing(object sender, eventargs e)
  {
      if (IsDirty) SavePreferences();
  }
  

[scalt]

Alrighty, it looks like you might have a few excess methods in your code there, at this stage you should probably only have 3 - your constructor (public 'ReinerNotes()') and 2 button click event handlers. I think you need to start a new project and re-build your form because it looks like you have re-named your controls a few times over, and in fact I'm even sure why it is compiling in the first place ('richTextBox1_TextChanged.LoadFile(..' is confusing me especially'). Aside from the excess methods and muddled names your code essentially looks OK though. I have worked on it a little bit and have added it to the end of this post.

When re-creating your form I would HIGHLY recommend naming your controls (Buttons/TextBoxes etc) to something other than the default name. You can do this by clicking on your button/text box and going into the 'Properties' tab. I made an example project so i could show you some code set it up like this:
- Renamed form to 'frmReinerNotes'
- Added 2 buttons, named 1 'btnOpen', 1 named 'btnSave'
- Added 1 RichTextBox named 'rtxtText'

I tend to added 3-4 letters onto the beginning of the names of each one of my controls so I can easily tell which 'type' each one is. For example, a control called 'Open' is ambiguous, but a control called 'btnOpen' usually implies that the Control is actually a Button.

    public partial class frmReinerNotes : Form
    {
        public frmReinerNotes()
        {
            InitializeComponent();
        }

        private void btnSave_Click(object sender, EventArgs e)
        {
            //set the filter text for your dialog up here
            saveFileDialog.Filter = "Text Files|*.txt|All Files|*.*";
       
            if (saveFileDialog.ShowDialog() == DialogResult.OK)
            {
                //2 possible methods here - PICK ONE THEN DELETE THE OTHER

                //method 1 - use a StreamWriter to write the contents of the text box to the file
                using (StreamWriter writer = new StreamWriter(saveFileDialog.FileName))
                {
                    writer.Write(rtxtText.Text);
                }

                //method 2 - use the Rich Textbox's 'save' feature
                rtxtText.SaveFile(saveFileDialog.FileName);
            }
        }

        private void btnOpen_Click(object sender, EventArgs e)
        {
            //left this stuff alone (apart from renaming 'openFileDialog1' to 'openFileDialog' 
            openFileDialog.InitialDirectory = "C:";
            openFileDialog.Title = "Open a File";
            openFileDialog.FileName = "";
            openFileDialog.Filter = "Text Files|*.txt";
            if (openFileDialog.ShowDialog() == DialogResult.OK)
            {
                //as above there are 2 possible methods here - PICK ONE THEN DELETE THE OTHER
                //method 1 - use a StreamReader
                using (StreamReader reader = new StreamReader(openFileDialog.FileName))
                {
                    rtxtText.Text = reader.ReadToEnd();
                }

                //method 2 - use the Rich Textbox's 'open' feature
                rtxtText.LoadFile(openFileDialog.FileName, RichTextBoxStreamType.PlainText);
            }

        }
    }

As you can see I messed with your 'save' code a little as well. You were setting your filter in the wrong place and were using one too many Stream/StreamWriters. All you needed to do was set up a single StreamWriter using the '.FileName' property of saveFileDialog.

Does that all make sense?