[lolitacharm]

This method needs to return a random integer between int first and int second, inclusive. (first and second can be
positive or negative, and be in either order (smaller first, larger first, or equal)).

Here is my method, but one problem I noticed is that if I input 2 and 9, sometimes I get the output 10, which is clearly not between 2 and 9 inclusive. Also, what if int first and int second are equal? The method is not void, but I do not want to return a value, because there is no integer between them if they are equal?

 public static int randomNumber(int first, int second)
  {	
     int randomNum;
      if (first<second)
      {
          randomNum= (int)(second*Math.random()+first);
          return randomNum;
        }
      
      else if (second<first)
      {
          randomNum= (int)(first*Math.random()+second);
          return randomNum;
        }
     else // first and second are equal
          {
              System.out.println("The two numbers are equal");
              return first;
            }
  }

This post has been edited by lolitacharm: 11 July 2011 - 09:19 AM

[CasiOo]

randomNum= (int)(second*Math.random()+first);

Lets take the example with 2 and 9 and with Math.random() giving 0.9
randomNum = (int)(9*0.9+2) = 10.1

Your formula is wrong

[lolitacharm]

doesnt randomNum= (int)(second*Math.random()+first); return a random number between first and second, inclusive?

[lolitacharm]

CasiOo, on 11 July 2011 - 09:23 AM, said:

randomNum= (int)(second*Math.random()+first);

Lets take the example with 2 and 9 and with Math.random() giving 0.9
randomNum = (int)(9*0.9+2) = 10.1

Your formula is wrong

Could it be: (int)((second-1) * Math.random() + first);
or something like that?

[CasiOo]

I would simply just use the Random class instead

Random rnd = new Random();
randomNum = rnd.nextInt( second - first + 1 ) + first;

This post has been edited by CasiOo: 11 July 2011 - 10:01 AM

[jon.kiparsky]

As specified, randomNumber(4, 10) returns a number in the range (0..6), plus 4.

10* math.random() returns a float in the range (0..9.999....). Adding 4 and casting gives you an int in the range (4..13) (ie, (0..9), plus 4).

Does that help clarify?

This post has been edited by jon.kiparsky: 11 July 2011 - 10:02 AM

[g00se]

http://technojeeves....-value-in-range

[CasiOo]

g00se, on 11 July 2011 - 10:00 AM, said:

http://technojeeves....-value-in-range

But with that example you will never get the max value unless you round up?

EDIT: That example really should be

(int) Math.round( Math.random() * (max-min) + min )

or

(int) (Math.random() * (max-min + 1) + min)

This post has been edited by CasiOo: 11 July 2011 - 10:22 AM

[lolitacharm]

jon.kiparsky, on 11 July 2011 - 10:00 AM, said:

As specified, randomNumber(4, 10) returns a number in the range (0..6), plus 4.

10* math.random() returns a float in the range (0..9.999....). Adding 4 and casting gives you an int in the range (4..13) (ie, (0..9), plus 4).

Does that help clarify?

I do not want to use the random class, I want to use math.random. Sorry, I'm still confused. The numbers int first and int second are entered by the user, so what was wrong with my formulas? Why won't it return a random int between int first and int second inclusive?

[jon.kiparsky]

Quote

Why won't it return a random int between int first and int second inclusive?

Break it down. You're doing three things, or really four, when you call randomNumber(i,j). First, you generate a random number n, where 0 <= n < 1 . Then, you multiply it by the larger of the two numbers provided by the user - suppose that's j, you now have a float n where 0 <= n < j . Then you add i, so you have a float n where i <= n < i+j . Finally, you cast to an int, leaving you with an int in the range (i..i+j-1).

But what you want is a number in the range (i..j), inclusive, right?

According to the spec you provided, randomNumber(4, 10) should return a number in the range (4..10). That's equivalent to (0..6), plus 4, right? So your problem is with the range you're generating.

[lolitacharm]

Oh! Is it:

int randomNum;
      if (first<second)
      {
          randomNum= (int)((second-first)*Math.random()+first);
          return randomNum;
        }

??

[CasiOo]

lolitacharm, on 11 July 2011 - 10:31 AM, said:

Oh! Is it:

int randomNum;
      if (first<second)
      {
          randomNum= (int)((second-first)*Math.random()+first);
          return randomNum;
        }

??

Check my post above and you have your answer You will never the max

[lolitacharm]

but with this last code I provided, I tried input, say 2 and 9, and I get all numbers (2, 3,4,5,6,7,8,) except 9. Why is the highest number missing now?

AH! do I need to add something to first now, at the end of that?

int randomNum;

      if (first<second)

      {

          randomNum= (int)((second-first + 1)*Math.random()+first);

          return randomNum;

        }

?????????????????????????

Another problem I am having is that, what if two equal numbers are entered? The method is not void, so a number has to be returned, but what if I dont want a number to be returned because there is no number in between (i.e. the two numbers entered were equal)??

[CasiOo]

lolitacharm, on 11 July 2011 - 10:39 AM, said:

but with this last code I provided, I tried input, say 2 and 9, and I get all numbers (2, 3,4,5,6,7,8,) except 9. Why is the highest number missing now?

AH! do I need to add something to first now, at the end of that?

int randomNum;

      if (first<second)

      {

          randomNum= (int)((second-first + 1)*Math.random()+first);

          return randomNum;

        }

?????????????????????????

Another problem I am having is that, what if two equal numbers are entered? The method is not void, so a number has to be returned, but what if I dont want a number to be returned because there is no number in between (i.e. the two numbers entered were equal)??

You could make it throw an exception

public int randomNumber( int min, int max ) throws RandomNumberException {
	if (...)
	.....
	else if (...)
	.....
	else
		throw new RandomNumberException();
}

public class RandomNumberException extends Exception {

	public RandomNumberException() {
		super( "The two numbers were equal" );
	}
}

[lolitacharm]

OKAY, im running into another problem. I just tried -4 and -1 and the random number was 0. That is clearly not between -4 and -1!! Does this not work correctly for negative numbers??