[poncho4all]

I have this class

    class Variable
    {
        char ascii;
        double probabilidad;
        int codigo;

        public Variable()
        { }
        public void llenar(char letra, double prob)
        {
            ascii = letra;
            probabilidad = prob;
        }

        public double Probabiliada
        {
            get
            {
                return probabilidad;
            }
        }

        public int Codigo
        {
            set
            {
                codigo = value;
            }
            get
            {
                return codigo;
            }
        }

        public char Caracter
        {
            get
            {
                return ascii;
            }
        }
    }

I'm making a List<T>, with T being "Variable" but when I add an item to it, it overwrites the last one and also adds one. Basicly what happends is that

//tempVariable = char 'a', double 0.1, int 1
myListT.Add(tempVariable); //now i have an item type "Variable" in my list so I add another one
//tempVariable = char 'b', double 0.2, int 1
myListT.Add(tempVariable);//add a second "Variable"

what i have at the end is a list with alot of "variable" with values = char 'a', double '0.2', int 1 in every single value in my list, they all become the last one.

[darek9576]

I dont get what your problem is. T is the type parameter. Show the class that is the type parameter.

This post has been edited by darek9576: 22 July 2011 - 04:02 PM

[poncho4all]

Yes T is a Type the type is gonna be "Variable" which is the name of my class.

Thing is all the values i add to my list, it doesnt matter wich value, they all become the same as the last one that was added.

So the all the values of the list are the same. Of the List<Variable> all of them are the same.

[wiero]

i think that you do not create new tempVariable just change its values and then you add item to list. so you're adding same object all the time, but i may be wrong.please post more code of adding and creating classes

This post has been edited by wiero: 22 July 2011 - 03:56 PM

[poncho4all]

You were right i wasn't using the new Variable, now i can make the list, the problem now is that i cant use List.Sort(), it says that if fails to compare two values, but i would like it to be sorted according to the double variable in the class.

Any ideas how to do this?

@Curtis: yes i made the correction, noticed it as well, i think im tired and i missed that. Any ideas in the other problem?

This post has been edited by poncho4all: 22 July 2011 - 04:01 PM

[Curtis Rutland]

I'm also going to chime in and say post more code.

I think it's because Classes are reference types, you're actually modifying the instance that you added and adding it again, rather than adding a new instance. Basically, if you're still using tempVariable and not calling new between the adds, this is what's wrong.

[darek9576]

Good point. You need to create unique objects and add them to the collections. Give us teh code.

[Sergio Tapia]

Yep, you're adding the same object to the List<Variable> many times.

As for sorting goes, a quick cheap (kinda dirty) way to do this is by using a delegate:

myList.Sort(delegate(Variable v1, Variable v2) { return v2.Probabilidad.CompareTo(v1.Probabilidad); });

The more correct way is to implement IComparable in your custom types.

More info here: http://msdn.microsof...y/b0zbh7b6.aspx

Specifically, here: http://msdn.microsof...y/4d7sx9hd.aspx

This post has been edited by Sergio Tapia: 22 July 2011 - 04:04 PM

[wiero]

your class should implement IComparable<T> interface

This post has been edited by wiero: 22 July 2011 - 04:04 PM

[darek9576]

Check out IComparable<> interface and CompareTo() method.

[poncho4all]

Could you explain a bit how that works Sergio Tapia, i dont really understand. The Sort part please.

Edit: thank you all, I posted this one before i refreshed my page. Im gonna check the IComparable.

IComparable worked just fine, thanks all for the help.

This post has been edited by poncho4all: 22 July 2011 - 04:13 PM

[Curtis Rutland]

IComparable is fine. You can also do things the LINQ way with OrderBy.

[darek9576]

Do you know Google?

[Sergio Tapia]

Yeah, I'd say forget my delegate and use OrderBy, it's pretty darn useful and *easier to maintain.

myList.OrderBy(x => x.Probabilidad);

This post has been edited by Sergio Tapia: 22 July 2011 - 04:07 PM

[Curtis Rutland]

Of course, you can't do that in a vacuum. OrderBy returns a sorted IEnumerable, it doesn't modify the collection. So you'd have to .ToList it and assign it to the variable.

Also, you know you could use a lambda for your original delegate too, Sergio:

delegate(Variable v1, Variable v2) { return v2.Probabilidad.CompareTo(v1.Probabilidad); }

is the equivalent of

(v1, v2) => v2.Probabilidad.CompareTo(v1.Probabilidad)