[B13ZT]

Hello Forum,

I have this code. The idea is that i send a command and i want to get the output in a stringbuffer that i then return.
The problem is that it works untill "line = in.readline()"
When i debug i receive that the application is running, but nothing happens.

Does anybody know what can be wrong?
Thank you

public StringBuffer executeSystemProcess(String process) {
        String line = null;
        StringBuffer param = new StringBuffer();
        BufferedReader in = null;
        try {
            Process proc = Runtime.getRuntime().exec(process);
            InputStreamReader inputStreamReader = new InputStreamReader(proc.getInputStream());
            in = new BufferedReader(inputStreamReader);
            line = in.readLine();
            while (line != null) {
                param.append(line);
                param.append('\n');
            }

        } catch (Exception ex) {
            ex.printStackTrace();
        } finally {
            try {
                if (in != null)
                    in.close();
            }
            catch (IOException e) {
                e.printStackTrace();
            }
        }
        return param;
    }

This post has been edited by B13ZT: 16 August 2011 - 04:36 AM

[smohd]

How do you expect the line to change at this loop:

line = in.readLine();
while (line != null) {
                param.append(line);
                param.append('\n');
            }

??

[B13ZT]

smohd, on 16 August 2011 - 04:38 AM, said:

How do you expect the line to change at this loop:

line = in.readLine();
while (line != null) {
                param.append(line);
                param.append('\n');
            }

??

Thank you for your response. you are completly correct.
I changed it to "while ((line = in.readLine()) != null) {"
But the problem remains the same.

[smohd]

This should work, but some of the processes do not get to end(like cmd). To prove that it works try this:

 while ((line = in.readLine()) != null) {
                param.append(line);
                param.append('\n');
                System.out.println(param);//print what lines has been added
            }

For cmd, this loop will go 3 times and then go to an endless line!!

[cfoley]

Put something like this in the loop so you can see what is going on.
System.out.println(">" + line + "<");

Maybe it's that there is always something to read in, even if it's an empty string.

lol. Ninjaed by smohd

[g00se]

See http://technojeeves..../52-runtimeexec

For the theory

http://www.javaworld...1229-traps.html