[tdeprato]

I am getting the following error --

"T_ELSE in scorm_get_tracks.php on line 47"

In the code below. I have re-written the if-else a few times. This is a patch to a function for the Moodle platform and maybe I am just blind but I cannot find the solution it must be simple....

<?php
function scorm_get_tracks($scoid,$userid,$attempt='') {
/// Gets all tracks of specified sco and user
global $CFG;

if (empty($attempt)) {
if ($scormid = get_field('scorm_scoes','scorm','id',$scoid)) { $attempt = scorm_get_last_attempt($scormid,$userid); } else { $attempt = 1; }
}
$attemptsql = ' AND attempt=' . $attempt;
if ($tracks = get_records_select('scorm_scoes_track',"userid=$userid AND scoid=$scoid".$attemptsql,'element ASC')) {
$usertrack->userid = $userid;
$usertrack->scoid = $scoid; 
// Defined in order to unify scorm1.2 and scorm2004
$usertrack->score_raw = '';
$usertrack->status = '';
$usertrack->total_time = '00:00:00';
$usertrack->session_time = '00:00:00';
$usertrack->timemodified = 0;
$usertrack->firsttimemodified = time(); // josef
foreach ($tracks as $track) {
$element = $track->element;
$usertrack->{$element} = $track->value;
switch ($element) {
case 'cmi.core.lesson_status':
case 'cmi.completion_status':
if ($track->value == 'not attempted') { $track->value = 'notattempted'; } 
$usertrack->status = $track->value;
break; 
case 'cmi.core.score.raw':
case 'cmi.score.raw':
$usertrack->score_raw = $track->value;
break; 
case 'cmi.core.session_time':
case 'cmi.session_time':
$usertrack->session_time = $track->value;
break; 
case 'cmi.core.total_time':
case 'cmi.total_time':
$usertrack->total_time = $track->value;
break; 
} 
if (isset($track->timemodified) && ($track->timemodified > $usertrack->timemodified)) { $usertrack->timemodified = $track->timemodified; } 
if (isset($track->timemodified) && ($track->timemodified < $usertrack->firsttimemodified)) {	// josef $usertrack->firsttimemodified = $track->timemodified;	 // josef } // josef
}
if (is_array($usertrack)) { ksort($usertrack); }
return $usertrack;
} else { return false; }
}
?>

[JackOfAllTrades]

Perhaps if you had some sanity in your code indentation and formatting, it might be obvious! What the hell are you using to edit your code? Here's what it SHOULD look like (at least one minor variation):

<?php
function scorm_get_tracks($scoid,$userid,$attempt='') {
	/// Gets all tracks of specified sco and user
	global $CFG;

	if (empty($attempt)) {
		if ($scormid = get_field('scorm_scoes','scorm','id',$scoid)) { 
			$attempt = scorm_get_last_attempt($scormid,$userid); 
		} else { 
			$attempt = 1; 
		}
	}
	$attemptsql = ' AND attempt=' . $attempt;
	if ($tracks = get_records_select('scorm_scoes_track',
		"userid=$userid AND scoid=$scoid".$attemptsql,'element ASC')) {
		$usertrack->userid = $userid;
		$usertrack->scoid = $scoid; 
		// Defined in order to unify scorm1.2 and scorm2004
		$usertrack->score_raw = '';
		$usertrack->status = '';
		$usertrack->total_time = '00:00:00';
		$usertrack->session_time = '00:00:00';
		$usertrack->timemodified = 0;
		$usertrack->firsttimemodified = time(); // josef
		foreach ($tracks as $track) {
			$element = $track->element;
			$usertrack->{$element} = $track->value;
			switch ($element) {
				case 'cmi.core.lesson_status':
				case 'cmi.completion_status':
					if ($track->value == 'not attempted') { 
						$track->value = 'notattempted'; 
					} 
					$usertrack->status = $track->value;
					break; 
				case 'cmi.core.score.raw':
				case 'cmi.score.raw':
					$usertrack->score_raw = $track->value;
					break; 
				case 'cmi.core.session_time':
				case 'cmi.session_time':
					$usertrack->session_time = $track->value;
					break; 
				case 'cmi.core.total_time':
				case 'cmi.total_time':
					$usertrack->total_time = $track->value;
					break; 
			} 
			if (isset($track->timemodified) && 
				($track->timemodified > $usertrack->timemodified)) { 
				$usertrack->timemodified = $track->timemodified; 
			} 
			if (isset($track->timemodified) && 
				($track->timemodified < $usertrack->firsttimemodified)) {
					// josef $usertrack->firsttimemodified = $track->timemodified;	 // josef } // josef
			}
			if (is_array($usertrack)) { 
				ksort($usertrack); 
			}
			return $usertrack;
		} else { 
			return false; 
		}
	}
?>

[tdeprato]

I use Eclipse but I was working in GEDIT when I decided to paste the code in sorry. BUT
I still get the same error. I just used Eclipse and Jedit to check the bracket count. Still nothing.

Thanks for the feedback.

[JackOfAllTrades]

I didn't give you the answer, I formatted the code.

Check your brackets, look at the indentation. What bracket does the last } else { match up with?

[tdeprato]

} else {


the { --- closes the for-each at the top

the { opens the else.

I did two brackets checks already with it is when I do php -l I get the syntax report.

[JackOfAllTrades]

Is there such a thing as a foreach-else loop?

[tdeprato]

Yeah ForEach

JackOfAllTrades, on 29 October 2011 - 08:53 AM, said:

Is there such a thing as a foreach-else loop?

[JackOfAllTrades]

Dude...else matches up with ONE THING...if. Are you not getting that?

[tdeprato]

I have worked it 3-5 different ways, this code is in a large repository for Moodle developers. It is for an older version of the platform. It, at one time, was deployed in probably 10000 installations world wide. Anyway thanks I will ask others...Have you ever used a FOREACH loop before?

JackOfAllTrades, on 29 October 2011 - 09:40 AM, said:

Dude...else matches up with ONE THING...if. Are you not getting that?

[CTphpnwb]

tdeprato, on 29 October 2011 - 12:46 PM, said:

Have you ever used a FOREACH loop before?

All the time. How does that relate to your not knowing how to close braces?

[tdeprato]

What are you talking about?

I closed the BRACES. I ran the code through a syntax checking/bracket counting program.

I can run individual pieces of it. I am obviously missing something and cannot find it. So if you can solve it, please help. If not then I will sort it out later.

I have written it 5 different ways, this is the original code that is why I posted it, since it was the piece of code used most often in the repository.

That is why I asked for HELP in figuring out a simple and obvious problem..which is must be.

If you do not want to help PLEASE do not keep replying.

CTphpnwb, on 29 October 2011 - 10:03 AM, said:

tdeprato, on 29 October 2011 - 12:46 PM, said:

Have you ever used a FOREACH loop before?

All the time. How does that relate to your not knowing how to close braces?

[CTphpnwb]

Oh, sorry. I saw the missing brace and thought that was your only problem. As Jack has already pointed out, you can't put an 'else' with anything but an 'if'. Without giving you line numbers I don't see how it could be any clearer.

[Boy67]

ELSE can only be used with a IF statement like JackOfAllTrades said.

No-one can really go into much more depth to explain this. lol.

[tdeprato]

Here is a version..notice the IF and ELSE are connected....

error still - unexpected T_ELSE

I am aware there is a structural mistake..can you find it? I can paste all the versions where the if-else are re-written etc...but I still get the same error. And the foreach seems closed ... and I cannot find any lines that have been incorrectly terminated.

<?php
function scorm_get_tracks($scoid,$userid,$attempt='') {

    /// Gets all tracks of specified sco and user

    global $CFG;

 
    if (empty($attempt)) {

        if ($scormid = get_field('scorm_scoes','scorm','id',$scoid)) {

            $attempt = scorm_get_last_attempt($scormid,$userid);

        } else {

            $attempt = 1;

        }

    }

    $attemptsql = ' AND attempt=' . $attempt;

    if ($tracks = get_records_select('scorm_scoes_track',

        "userid=$userid AND scoid=$scoid".$attemptsql,'element ASC')) {

        $usertrack->userid = $userid;

        $usertrack->scoid = $scoid;

        // Defined in order to unify scorm1.2 and scorm2004

        $usertrack->score_raw = '';

        $usertrack->status = '';

        $usertrack->total_time = '00:00:00';

        $usertrack->session_time = '00:00:00';

        $usertrack->timemodified = 0;

        $usertrack->firsttimemodified = time(); // josef

        foreach ($tracks as $track) {

            $element = $track->element;

            $usertrack->{$element} = $track->value;

            switch ($element) {

                case 'cmi.core.lesson_status':

                case 'cmi.completion_status':

                    if ($track->value == 'not attempted') {

                        $track->value = 'notattempted';

                    }

                    $usertrack->status = $track->value;

                    break;

                case 'cmi.core.score.raw':

                case 'cmi.score.raw':

                    $usertrack->score_raw = $track->value;

                    break;

                case 'cmi.core.session_time':

                case 'cmi.session_time':

                    $usertrack->session_time = $track->value;

                    break;

                case 'cmi.core.total_time':

                case 'cmi.total_time':

                    $usertrack->total_time = $track->value;

                    break;

            }

            if (isset($track->timemodified) &&

                ($track->timemodified > $usertrack->timemodified)) {

                $usertrack->timemodified = $track->timemodified;

            }

            if (isset($track->timemodified) &&

                ($track->timemodified < $usertrack->firsttimemodified)) {

                    // josef $usertrack->firsttimemodified = $track->timemodified;     // josef } // josef

            }

            if (is_array($usertrack)) {

                ksort($usertrack);

            }

            return $usertrack;
            else {

            return false;

        }

        } 

    }

?>

[Duckington]

Yeah that sort of code sums up Moodle really.