[OttotheRobot]

Having a bit of trouble updating the counter clicks every time a button is clicked

Example of the code I have so far:

int counter = 0;
JButton click = new JButton("Click");
JLabel count = new JLabel("Score: " + counter);

count.add(click);

click.addActionListener(this);

if(e.getSource() instanceof JButton)
{
     if(e.getActionCommand().equals("Click"))
     {
          counter++;
          count.setText("Score: " + counter);
     }
}

Any help would be appreciated!

[macosxnerd101]

We'll need a little more information on what exactly is wrong? And did you setActionCommand() on the JButton?

[OttotheRobot]

I basically need the counter to increment by one every time the user clicks on the "click" button. No, I haven't set a setActionCommand(). I've seen this repaint() code around but not sure how to implement it to my GUI program. Something along the lines of this:

http://i.imgur.com/2tNOP.jpg

[macosxnerd101]

You shouldn't need to invoke repaint() for this yourself. Also, can I assume that this is all of your code or just a sample of it?

[OttotheRobot]

Oh okay. It's just a small snippet of a larger program. There are many buttons in my program but if I can implement a counter for just one then I think I'll be able to finish the rest of it.

[Fuzzyness]

if(e.getSource() instanceof JButton)
{
     if(e.getActionCommand().equals("Click"))
     {
          counter++;
          count.setText("Score: " + counter);
     }
}

This needs to be in an actionperformed method in the class. Cannot just have it in the constructor.

[OttotheRobot]

Fuzzyness, on 06 November 2011 - 04:11 PM, said:

if(e.getSource() instanceof JButton)
{
     if(e.getActionCommand().equals("Click"))
     {
          counter++;
          count.setText("Score: " + counter);
     }
}

This needs to be in an actionperformed method in the class. Cannot just have it in the constructor.

It already is. That code is just the basics to get my problem across. Thanks for the input.

public void actionPerformed(ActionEvent e)
{
     if(e.getSource() instanceof JButton)
     {
          if(e.getActionCommand().equals("Click"))
          {
               counter++;
               count.setText("Score: " + counter);
          }
     }
}

[pbl]

should work
counter will be incremented everytime the "Click" button is clicked

[OttotheRobot]

Okay I'm starting to see my problem now. I'm trying to get the click counter to increment by one when I select two buttons that are the same. Going to have to work a little harder on the code. Thanks!

[OttotheRobot]

While this topic is still alive, this code doesn't work and I'm not sure why:

if(e.getActionCommand().equals("Click") && e.getActionCommand().equals("Click"))
counter();

[pbl]

if(e.getActionCommand().equals("Click") && e.getActionCommand().equals("Click"))

why do you check twice if e.getActionCommand().equals("Click")
if it is true once it will be true forever

[OttotheRobot]

There's two buttons, one is "Click 1" and the other is "Click 2". I want the counter to increment by one when both of those buttons are clicked. So I was thinking the code for this would be:

if(e.getActionCommand().equals("Click 1") && e.getActionCommand().equals("Click 2"))

[pbl]

now you just added "Click 1" and "Click 2" in your question
How can an ActionEvent comes from Click1 AND Click2 ? It is impossible

[OttotheRobot]

Oh okay this is making more sense now. I have it figured out. Thanks for the help