[Jamey-Wright]

Hey guys! I need help, I'm creating a program (and no it's not homework before you ask ) and I have 6 players who type "roll" and I use the math random command to assign a random number between one and 6. How do I make it so that if a player already gets a number it's not repeated for the next player. I already tried

if (number1 == number2)

and it didn't work.Plus that only helps if there are 2 players.

Please help! Thanks!

[Mylo]

Maybe you could use an array

Roll dice
Add result to array
Roll dice
If array contains result
roll again

OR

You create an array of {1,2,3,4,5,6} and remove the index value from the list when it is rolled.

eg.

Roll dice
remove the index of the result, example : 5, remove the fifth element, which is five, now roll another random number up to 5
then to 4
then to 3
so on...

Edit, you'll want a list, not an array since a list can add or remove elements, preventing the need to resize arrays.

This post has been edited by Mylo: 18 January 2012 - 07:42 PM

[Jamey-Wright]

Mylo, on 18 January 2012 - 07:41 PM, said:

Maybe you could use an array

Roll dice
Add result to array
Roll dice
If array contains result
roll again

OR

You create an array of {1,2,3,4,5,6} and remove the index value from the list when it is rolled.

eg.

Roll dice
remove the index of the result, example : 5, remove the fifth element, which is five, now roll another random number up to 5
then to 4
then to 3
so on...

Edit, you'll want a list, not an array since a list can add or remove elements, preventing the need to resize arrays.

Could you possibly give me an example. I know it says not to give out code but believe me I've been trying.

[Mylo]

Something like this:

	public static void main(String[] args)
	{
		ArrayList<Integer> numbers = new ArrayList<Integer>();
		numbers.add(1);
		numbers.add(2);
		numbers.add(3);
		numbers.add(4);
		numbers.add(5);
		numbers.add(6);
		int[] playerscores = new int[6];
		
		for (int i = 0; i < playerscores.length; ++i)
		{
			int rnd = (int) (Math.random() * numbers.size());
			playerscores[i] = numbers.get(rnd);
			numbers.remove(rnd);
		}
		
		for (int x : playerscores)
		{
			System.out.println(x);
		}
	}

Or even another way is to just shuffle the list of possible values, and assign them to the respective player.

This post has been edited by Mylo: 18 January 2012 - 07:52 PM

[Jamey-Wright]

Mylo, on 18 January 2012 - 07:51 PM, said:

Something like this:

	public static void main(String[] args)
	{
		ArrayList<Integer> numbers = new ArrayList<Integer>();
		numbers.add(1);
		numbers.add(2);
		numbers.add(3);
		numbers.add(4);
		numbers.add(5);
		numbers.add(6);
		int[] playerscores = new int[6];
		
		for (int i = 0; i < playerscores.length; ++i)
		{
			int rnd = (int) (Math.random() * numbers.size());
			playerscores[i] = numbers.get(rnd);
			numbers.remove(rnd);
		}
		
		for (int x : playerscores)
		{
			System.out.println(x);
		}
	}

Or even another way is to just shuffle the list of possible values, and assign them to the respective player.

Thanks. I'll try this out.

[CasiOo]

I am following the same idea as Mylo's, but have changed it to how I would have implemented it

private ArrayList<Integer> numbers;
private Random rnd = new Random();

//Add the numbers 1-6 to the numbers arraylist
public void fillArrayList() {
	numbers = new ArrayList<Integer>();
	for (int i=1; i<=6; i++)
		numbers.add(i);
}

public int roll() {
	if (numbers.size() > 0)
		return numbers.remove(rnd.nextInt(numbers.size()));
	return -1; //The array is empty!
}

This post has been edited by CasiOo: 18 January 2012 - 08:03 PM

[Mylo]

That would be alot better ^ Didn't even know remove returned a value =)

[Jamey-Wright]

CasiOo, on 18 January 2012 - 08:03 PM, said:

I am following the same idea as Mylo's, but have changed it to how I would have implemented it

private ArrayList<Integer> numbers;
private Random rnd = new Random();

//Add the numbers 1-6 to the numbers arraylist
public void fillArrayList() {
	numbers = new ArrayList<Integer>();
	for (int i=1; i<=6; i++)
		numbers.add(i);
}

public int roll() {
	if (numbers.size() > 0)
		return numbers.remove(rnd.nextInt(numbers.size()));
	return -1; //The array is empty!
}

Thanks. I'm not amazing with Java. What I'm trying to create is a Russian roulette program. I need it so 6 users enter their names, type 'roll' and then are assigned a number between one and six. Then the players pull the trigger in ascending order. I'm finding it very difficult to make, because I am so new. So far I only have the code where users enter their name and then roll the dice.

[pbl]

It is there since almost 3 years and has been mentionned many times

http://www.dreaminco...snippet2992.htm

[CasiOo]

Jamey-Wright, on 18 January 2012 - 08:09 PM, said:

CasiOo, on 18 January 2012 - 08:03 PM, said:

I am following the same idea as Mylo's, but have changed it to how I would have implemented it

private ArrayList<Integer> numbers;
private Random rnd = new Random();

//Add the numbers 1-6 to the numbers arraylist
public void fillArrayList() {
	numbers = new ArrayList<Integer>();
	for (int i=1; i<=6; i++)
		numbers.add(i);
}

public int roll() {
	if (numbers.size() > 0)
		return numbers.remove(rnd.nextInt(numbers.size()));
	return -1; //The array is empty!
}

Thanks. I'm not amazing with Java. What I'm trying to create is a Russian roulette program. I need it so 6 users enter their names, type 'roll' and then are assigned a number between one and six. Then the players pull the trigger in ascending order. I'm finding it very difficult to make, because I am so new. So far I only have the code where users enter their name and then roll the dice.

Just keep on trying and working hard!
Don't expect every project to be a success, I personally think that 90% of my projects are complete trash, but I learn something new in every project