[bennyb]

I am trying to create a program to add the number of even numbers up between two numbers inputted by a user - the program works fine as long as the first number entered is smaller than the second. For example entering 1 and 6 would print 12 (this works) but when entering 6 and 1 it prints 0 (should be 12).

I know this code is what is causing the problem but i don't know how to add the fact number 1 maybe bigger then number 2

for (int j = number1; j <= number2; j++) {
if (j % 2 ==0) {

Thanks for your help in advance.

[Dogstopper]

Just add an if statement before the loop. If number1 > number, then switch the values of 1 and 2. Then your loop should work. As it is, it only loops WHILE num1 >= num2.

[CasiOo]

Well you just have to check which of the two numbers are the highest/smallest

public int evenNumbers(int number1, int number2) {
	int smallest = Math.min(number1, number2);
	int highest = Math.max(number1, number2);
	
	for (int j = smallest; j <= highest; j++)
		if (j% 2 == 0)
			...
}

[bennyb]

CasiOo, on 19 January 2012 - 08:16 AM, said:

Well you just have to check which of the two numbers are the highest/smallest

public int evenNumbers(int number1, int number2) {
	int smallest = Math.min(number1, number2);
	int highest = Math.max(number1, number2);
	
	for (int j = smallest; j <= highest; j++)
		if (j% 2 == 0)
			...
}

Thanks a lot, i know what to do now - appreciate your time!

[pbl]

No need to test all elements in the loop, just the smallest once before starting

public int evenNumbers(int number1, int number2) {
	int smallest = Math.min(number1, number2);
	int highest = Math.max(number1, number2);
	
	if(smallest % 2 != 0)
	    ++smallest;

	for (int j = smallest; j <= highest; j += 2)
			...
}

Happy coding

[CasiOo]

Ah yes didn't think about that. That is actually a great one pbl