[scottas]

When I click on the link first time ( when page loads ) then nothing hapens. Bud second, third.... times - everything is working. Here is code:

function showHide ( id )
{
	var
		elementas;
		
	elementas = document.getElementById ( id );
	if ( elementas )
	{
		if ( elementas.style.visibility == "hidden" )
		{
			elementas.style.visibility = "visible";
		}
		else
		{
			elementas.style.visibility = "hidden";
		}
	}
	return false;
}

Html:

Body:
<script type="text/javascript" src="jsscriptai.js"></script>

Code:
<div id = "toolbar"><ul><li><a href = "#" onclick = "showHide('loginmenu');">Prisijungti</a></li></ul></div>

What is wrong with it?

[tlhIn`toq]

Instead of this convulted if...else construct couldn't you just toggle the visiblity?

function showHide ( id )
{
	var elementas;
		
	elementas = document.getElementById ( id );
	if ( elementas )
	{
           elementas.style.visibility = !elementas.style.visibility;
	}
	return false;
}

This post has been edited by tlhIn`toq: 26 January 2012 - 03:25 PM

[scottas]

but then it not works at all

[tlhIn`toq]

Odd. If you place a breakpoint at line 8 and run this, does the execution stop on this line consistently?

[scottas]

I don't know how to use firebug . But I see, that javascript thinks, that element visibility is empty ( elementas.style.visibility == "" )

[tlhIn`toq]

That certainly explains everything!

[scottas]

I found out that when I use javascript 'style' when my css styles declared in stylesheet (file style.css) then style of elemwent returns empty string

[scottas]

the only way to fix it that I know is:

function showHide ( id )
{
	var elementas;
		
	elementas = document.getElementById ( id );
	if ( elementas )
	{
		if ( elementas.style.visibility == "" )
			elementas.style.visibility = "hidden";
		
		if ( elementas.style.visibility == "hidden" )
			elementas.style.visibility = "visible";
		else
			elementas.style.visibility = "hidden";
	}
	return false;
}

Maybe someone has suggestions?