[seker85]

I just want to make a calculation and get the output as a double or float. I'm going to need it to make a case or if-statement.
When I type this in visual studio this error appears: "error C2106: '=' : left operand must be l-value" LINE 268

266  #pragma endregion
267  private: System::Void button1_Click(System::Object^  sender, System::EventArgs^  e) {
268  System::Convert::ToDouble(this->textBox3->Text) = 
System::Convert::ToInt16(this->textBox1->Text) / System::Convert::ToInt16(this->textBox2->Text);
269}

[Macjohn]

Remember to keep programming question the the Programming lounge.

[seker85]

Question: Why do I get the error?
Question: Can anyone help converting this?

[no2pencil]

What language is this for, so that I can move it to the correct sub-forum?

The lounge is not for programming questions.

[seker85]

It's made in Visual Studio and it's C++

[no2pencil]

** Topic moved to C/C++ **

[baavgai]

** Topic moved to CLI C++ **

Because C++ programmers don't know what the hell it is, either.

[tlhIn`toq]

 System::Convert::ToDouble(this->textBox3->Text) =
System::Convert::ToInt16(this->textBox1->Text) / System::Convert::ToInt16(this->textBox2->Text);

The short answer is... The left side of the = sign needs to be a variable or something that you can assign a value to

x = 4

not

convert.todouble.x = blah blah blah

[seker85]

Well this is what I made so far:

 
this->textBox3->Text = System::Convert::ToString(System::Convert::ToDouble(this->textBox1->Text)
/ ((System::Convert::ToDouble(this->textBox2->Text))/10  /((System::Convert::ToDouble(this->textBox2->Text))/100));

and this works but I get the output as a string. When I try to make it a double it says error:
error C2664: 'void System::Windows::Forms::Control::Text::set(System::String ^)' : cannot convert parameter 1 from 'double' to 'System::String ^' in line 2-3

But it's working fine when I replace "Double" with "String" in line 1.

[tlhIn`toq]

While you are still learning, may I suggest you break down the long complex lines into more easily followed statements?

double Alpha = System::Convert::ToDouble(this->textBox1->Text);
double Bravo = ((System::Convert::ToDouble(this->textBox2->Text))/10  
double Charlie = ((System::Convert::ToDouble(this->textBox2->Text))/100));
double Result1 = Alpha/Bravo
double Result2 = Result1/Charlie

Now you have values that you can check at each step along the way.

Next... For the love of Pete rename your textboxes before you start working with them! It is so much easier to follow

tbNumerator/tbDenominator

Update: Here's the full suggestions I give everyone.


Let me also throw in a few tips:

• You have to program as if everything breaks, nothing works, the cyberworld is not perfect, the attached hardware is flakey, the network is slow and unreliable, the harddrive is about to fail, every method will return an error and every user will do their best to break your software. Confirm everything. Range check every value. Make no assumptions or presumptions.
  
  
• Take the extra 3 seconds to rename your controls each time you drag them onto a form. The default names of button1, button2... button54 aren't very helpful. If you rename them right away to something like btnOk, btnCancel, btnSend etc. it helps tremendously when you make the methods for them because they are named after the button by the designer.btnSend_Click(object sender, eventargs e) is a lot easier to maintain than button1_click(object sender, eventargs e)
  
  
• You aren't paying for variable names by the byte. So instead of variables names of a, b, c go ahead and use meaningful names like index, timeOut, row, column and so on. You should avoid 'T' for the timer. Amongst other things 'T' is commonly used throughout C# for Type and this will lead to problems. There are naming guidelines you should follow so your code confirms to industry standards. It makes life much easier on everyone around you, including those of us here to help. If you start using the standards from the beginning you don't have to retrain yourself later.
  You might want to look at some of the naming guidelines. Its a lot easier to start with good habits than to break bad habits later and re-learn.
  
  
  • Guidelines for names
    
  • Naming guidelines
    
  • Design guidelines for classes
  
  
  
• Try to avoid having work actually take place in GUI control event handlers. It is usually better to have the GUI handler call other methods so those methods can be reused and make the code more readible.
  
  Spoiler

  
  

  btnSave(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  SaveMenuItem(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  SaveContextMenu(object sender, eventargs e)
  {
      SavePreferences();
  }
  
  FormMain_Closing(object sender, eventargs e)
  {
      if (IsDirty) SavePreferences();
  }
  

  
  
  
• Don't replace lines of code that don't work. Instead comment them out and put your new attemps below that. This will keep you from re-trying the same ideas over and over. Also, when you come back to us saying "I've tried this 100 different ways and still can't get it", we can actually see what you tried. So often a failed attempt is very very close and just needs a little nudge in the right direction. So if we can say "See what you did in attempt 3... blah blah" it helps a lot
  
  
  Spoiler

  // Try #1 - May 1, 0900hrs
  //    code
  //    code  
  //    code
  // Try #2 - May 2, 1700hrs   Okay, plan B.  What if I do it *this* way
  //    code
  //    code  
  //    code
  // Try #14 - May 3, 0500hrs after 5 cans of RedBull.  Maybe I should get some sleep. I can't think of anything else but this last idea
      code
      code  
      code
  
  

  
  If you are using Visual Studio you can select a block of lines and hit control+k control+c (Kode Comment) to comment it out. control+k control+u (Kode Uncomment) to uncomment a selected block.

This post has been edited by tlhIn`toq: 01 February 2012 - 07:06 AM

[baavgai]

What you offered doesn't really match up, paren wise:

this->textBox3->Text = System::Convert::ToString(
	System::Convert::ToDouble(this->textBox1->Text)
	/ (
		(System::Convert::ToDouble(this->textBox2->Text))/10  / 
		((System::Convert::ToDouble(this->textBox2->Text))/100)
		);
		// missing one ) ...

Take things a step at a time, at first.

Just guessing at what you're aiming for form above, I'd do it like so:

Double d1 = Double::Parse(textBox1->Text);
Double d2 = Double::Parse(textBox2->Text);
Double result = d1 / (d2/10) / (d2/100);
this->textBox3->Text = result.ToString();

Note, the Double::Parse is the same as Convert::ToDouble; I just prefer it. All .NET types have a ToString method, so you might as well get some use out of it. Note that "double" can be quite a different thing than "System::Double" if you're not careful. Stick with caps and .NET number structs to maintain sanity.

Hope this helps.

This post has been edited by baavgai: 01 February 2012 - 07:15 AM

[seker85]

Thanks for the help, it's fine examples you gave. But my issue here is the conversion.

	Double d1 = Double::Parse(textBox1->Text);
	Double d2 = Double::Parse(textBox2->Text);
	Double result = d1 / (d2/10) / (d2/100);
	this->textBox3->Text = result.ToString(); 

I don't want the result to be a string but a double or float so I can use it in a loop.

[baavgai]

The TextBox Text property is a string. So, as you see, the control takes strings and gives strings. To display something in a TextBox, it has to find it's way to string. What you do with a value outside a control is up to you.

In the above example, the variable "result" is type Double, so I'm unsure what the issue is. We only get a string for it so the TextBox can use it.

[seker85]

Thanks, I realized that after taking a good look.