[bwills6]

Hey I am working on a basic encryption and I can get it to encrypt but I can't get it to encrypt a entire string. Any hints. I know its something little I am forgetting. I just don't remember how to take the next token of the input string. Thanks

public static  String userinput = "";
    
    public static void main(String[] args) {
        
        
          System.out.println("Please enter a string");
           Scanner scan = new Scanner(System.in);                        
           userinput = scan.next();
         
            int shift = 1;
            char conversion;
           
           
           for (int i = 0; i<userinput.length();i++)
           {
               conversion = userinput.charAt(i);
               conversion = (char)(conversion + shift);
               System.out.print(conversion);
               
           }

This post has been edited by modi123_1: 06 February 2012 - 06:07 PM
Reason for edit:: please use code tags

[g00se]

Essentially nothing wrong with that code. What's the problem?

[smohd]

Quote

but I can't get it to encrypt a entire string. Any hints .... I just don't remember how to take the next token of the input string

Do you mean to if the string has more than one word here? Then your problem should be here:

userinput = scan.next();

You need nextLine() instead of next()

[bwills6]

Thanks I got it working now. nextLine() is what I was looking for

[smohd]

Glad we could help

[bwills6]

So I cleaned up the code a bit...but now I can't get it to convert the text. I believe its getting stuck in the second for loop. But I don't know what to do or how to fix it. Any help would be awesome.

public class CeaserApp {
    

    public static String userinput = "";
    
    public static void main(String[] args) {
        Scanner scan = new Scanner(System.in);
        System.out.println("Please enter a string to encrypt");
        userinput = scan.nextLine();
        encryption();
        
         }
        
        
        public static void encryption()
        {
            
                String[] temp;
                String parser = " ";
                temp = userinput.split(parser);
                char conversion = 0;
                int key = 1;
          

        for(int i = 0;i<temp.length;i++)
               temp[i] = userinput; 
          
        for(int t = 0; t<userinput.length();t++)
            conversion = userinput.charAt(t); 
            conversion = (char)(conversion + key);
            System.out.print(conversion);         
                           
        }

This post has been edited by smohd: 10 February 2012 - 11:29 AM
Reason for edit:: Code tags added. Please use [code] tags when posting codes

[smohd]

Wait a minute...
What are you doing here?

  for(int i = 0;i<temp.length;i++)
               temp[i] = userinput;

Again looking at your second loop, the only line associated with a loop is the first line, So the last output will be the cipher of the last character only. Use {} to put a block of code with for loop.

Also there is a tutorial on cipher which you may find useful...

[bwills6]

I was using the first one to get all of words from the slit() function. I am not sure if I'm doing that right. But what I'm really trying to do is get that parsed string to a char so I then can do the shit to them by one. But I am having trouble with that.

[smohd]

No, this line puts every word into array:

temp = userinput.split(parser);

So the first loop has no use there.
Look at the first code you posted in the OP, that was a little good, take it to your method now. If you want to skip the spaces not to be shifted, then you have to loop through the array above and in every word do the shifting, you will need a nested loop for that. also try to look at the tutorial I gave above.