[m_wylie85]

Hi I have just published an app i was making. However whilst testing i noticed when i close the app using the Exit button which contains the code below

Application.Exit()

The app still runs, not on my screen it looks like it has close correctly but when i check the task manager to make sure it had stop it was still running. anyone have any ideas what could be the problem. I would post my code however there is way to much to post. Just any ideas that could cause this problem please.

[modi123_1]

Try "me.close" and see where that gets you.

Some reading on "why".

[m_wylie85]

That was got to know about me.close and app.Exit. I see why me.close() is best with App.Exit not executing form closing code and so on. However me.close() still did not stop the process in the task manager any other ideas

[modi123_1]

What's your program doing? Are there unclosed threads?

[m_wylie85]

Yes modi123 there may be unclosed thread i am using multi-threading is there a way to kill all active threads on closing or should i be doing this when i am finished with the thread. However if i wanted to kill the app before i was finish with the active thread. I would still need to kill active threads on closing

[modi123_1]

How are you running your threads? Is there a collection you can poll in the 'closing' event to wait for these threads to stop?

[nK0de]

as far as I know, threads have a method called .Abort

[m_wylie85]

No there is no poll in a closing event. I know i don't have this as i don't know what it is could you please explain "Is there a collection you can poll in the 'closing' event "


I heard that using .Abort is a bad way to do this as it throws expections but i could be wrong

This post has been edited by m_wylie85: 24 February 2012 - 09:37 AM

[modi123_1]

Okay.. show me how you are creating your threads.

[m_wylie85]

Ok this code below is the button call:

    Private Sub btnOpenRoyalFile_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnOpenRoyalFile.Click
        Dim thread As New System.Threading.Thread(AddressOf RoyalRecordSort)
        thread.Start()
    End Sub

Then i have delegate and sub as below:

    Private Delegate Sub DelRoyalPhysicalMerges(ByVal Mystring As String)
    Private Sub SubRoyalPhysicalMerges(ByVal Mystring As String)
        rtbRoyalPhysicalMerge.Text = Mystring
    End Sub

Then i am invoking it as below:

                If rtbRoyalPhysicalMerge.InvokeRequired Then
                    rtbRoyalPhysicalMerge.Invoke(New DelRoyalPhysicalMerges(AddressOf SubRoyalPhysicalMerges), RoyalPhysicalMerges)
                Else
                    rtbRoyalPhysicalMerge.Text = RoyalPhysicalMerges
                End If

[_HAWK_]

Did you tell the thread that it belongs to this process? This is how to do it:

thread.IsBackground = True

[modi123_1]

That's what I thought you were doing.

Okay, and this might just be my personal control freakness gushing forth, but important and odd objects (like threads) I desire to be able to be polled. That means having a collection (if there are more than one) to fill so I have one spot to look for and not a hope and a prayer that I know what they are doing.

In your case it makes me cringe to see a thread being generated in a button click event and not say added to a list(of) or some collection. Hell when your scope ends for the button event you will never ever have the ability to say "thread.ThreadState = Threading.ThreadState.Running" to see if the bastard is running! Also your user might come down with a case of the clickityitus and jam on that button control like they are trying to stress test their mouse's button. You could have hundreds or thousands of threads running around you don't have access too! EEK!

Example:

'-- global collection
    private _threads As New List(Of Thread)

    Private Sub btnOpenRoyalFile_Click(
        _threads.Add(New System.Threading.Thread(AddressOf SubRoyalPhysicalMerges))
	_threads(_threads.Count - 1).Start()
    End Sub

Now in your closing you can do a myriad of things to wait until you thread closes or kill them off directly.

Example:

    Private Sub Form_FormClosing(sender As Object, e As System.Windows.Forms.FormClosingEventArgs) Handles Me.FormClosing
        For Each temp As Thread In _threads
            If temp.ThreadState = ThreadState.Running Then '-- o noes!  mah thread is running!  Let's not close!
                e.Cancel = True
                Exit For
            End If
        Next
    End Sub

So yes.. my theory is threads are like children - you may have created them but damn if you aren't going to take care of them. Except for the ginger ones. Those go to the orphenariums.

[m_wylie85]

Ha Ha Modi true i wonder about double clicking and so (clickityitus) but i am still pretty new to multi-thread thanks for all the help.

Ps (Except for the ginger ones. Those go to the orphenariums. ) made me lol

Thanks again i will try to implement your suggestions and get back to you

[m_wylie85]

hey i am tring to understand what modi pointed out above i have rewrote some of his ideas and i have done it as so:

    Public Function threadHold()
        _threads.Add(New System.Threading.Thread(AddressOf RoyalRecordSort))
        Return _threads
    End Function
    Private Sub CheckRunningThreads(ByVal sender As System.Object, ByVal e As System.Windows.Forms.FormClosingEventArgs) Handles MyBase.FormClosing
        For Each temp As Thread In _threads
            If temp.ThreadState = ThreadState.Running Then '-- o noes!  mah thread is running!  Let's not close!
                e.Cancel = True
                Exit For
            End If
        Next
    End Sub
#Region "Buttons"
    Private Sub btnOpenRoyalFile_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnOpenRoyalFile.Click
        'Dim thread As New System.Threading.Thread(AddressOf RoyalRecordSort)
        'thread.Start()
        threadHold()
        _threads(_threads.Count - 1).Start()
    End Sub

I took this line out and put it into it's own function:

_threads.Add(New System.Threading.Thread(AddressOf RoyalRecordSort))

i done this because if i left it in the button click i would lose scope by the time i call the for closing event. Now that it is in a function i can keep scope until i need it. So what i am asking is am i going about this in the right way.

[modi123_1]

Quote

i done this because if i left it in the button click i would lose scope by the time i call the for closing event. Now that it is in a function i can keep scope until i need it. So what i am asking is am i going about this in the right way.

Wait, what? That doesn't make sense.