[Simon818]

Hi,

I am having a real problem implementing a Binary search/AVL tree.

The search tree should contain details of known criminals. The criminal object which i have coded is below

Spoiler

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Assignment3
{
    class Criminal : IComparable
    {
        private string name;
        private int age;
        private float height;
        private string address;
        private LinkedList<string> offences;

        public Criminal(string Name, int Age, float Height, string Address, LinkedList<string> Offences)
        {
            name = Name;
            age = Age;
            height = Height;
            offences = Offences;
            address = Address;
        }

        public string name
        {
            get { return name; }
            set { name = value; }
        }
        public int age
        {
            get { return age; }
            set { age = value; }
        }
        public float height
        {
            get { return height; }
            set { height = value; }
        }
        public string address
        {
            get { return address; }
            set { address = value; }
        }

        public void setName(string Name)
        {

        }

        public void setAge(int Age)
        {

        }

        public void setHeight(float Height)
        {

        }

        public void setAddress(string Address)
        {

        }

        public void getName()
        {
            return name
        }

        public void getAge()
        {
            return age
        }

        public void getHeight()
        {
            return height
        }

        public void getAddress()
        {
            return address
        }
    }
}

I have attempted to piece together an attempt at implementing an AVL/tree from what i have read in my notes and from the internet.

Spoiler

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Assignment3
{
    class AVLTree<T> where T:IComparable
    {
        private void insertItem(T item, ref Node<T> tree)
        {   
            if (tree==null)
                tree = new Node<T>(item);
            else if (item.CompareTo(tree.Data)<0)
                insertItem(item, ref tree.Left);
            else if (item.CompareTo(tree.Data)>0)
                insertItem(item, ref tree.Right);
            tree.BalanceFactor = height(tree.Left) - height(tree.Right);
            if (tree.BalanceFactor <= -2)      rotateLeft(ref tree);
            if (tree.BalanceFactor>=2)       rotateRight(ref tree);
        }
   private void rotateLeft(ref Node<T> tree)
  {
     if (tree.Right.BalanceFactor > 0)  //double rotate
                rotateRight(ref tree.Right);
       
   }
class Node<T> where T : IComparable
    {
        private T data;
        private int balanceFactor = 0; //added for AVLTree
        public Node<T> Left, Right;
     
public int BalanceFactor
        {
            set { balanceFactor = value; }
            get { return balanceFactor; }
        }

Any advice as to where i am going wrong will be appreaciated. If i have broke any rules please inform me and i will take it down. I feel stupid for asking as i know it is something quite simple which i have over looked

[Curtis Rutland]

First, we really can't help with such a general question. We can't do much with a "here's my code, what's wrong with it?" question. Please explain what is and isn't working, and what you've tried to do to fix it. Then we can work on resolving it together.

Also, that code looks quite familiar. Are you in the same class as this guy?

[Simon818]

Firstly thank you for replying. It seems as though i am in his class, yes.

That is the problem i'm having i dont really know what is wrong with my code. I'm finding the binary search trees very confusing. The object Criminal is correct i believe. I just cant seem to figure out how to store that object within a binary tree.

Again apologies if i have broken the rules and understand why you are not able to provide me with an answer