[javanewbie99]

I am trying to call the objects from my Room class in my Hotel class. It compiles, but only returns default values. Can someone explain why?

Here is my Room class:

import java.lang.String;

public class Room
{	
	private int getRoomNum;
	private String getBedType;
	private double getRoomRate;
	private char getSmoking;
	private String getOccupant;
	private String notOccupied;
	public String q;
	public String k;
	private String occupantName;

		
	public Room(int roomNum, String bedType, double rate, char smoking, String occupantName)
	{
		roomNum = 0;
		bedType = "";
		rate = 0;
		smoking = ' ';
		occupantName = "";
		
	}
	
	public String getBedType(String bedType)
	{
		
		if(bedType == "q")
		{
			bedType = "Queen";
		}
		else if (bedType == "k")
		{
			bedType = "King";
		}
		else 
		{
			bedType = "Twin";
		}
		return bedType;
	}
	
	public char getSmoking(char smoking)
	{
		
		if(smoking == 's')
		{
			smoking = 's';
		}
		else
		{
			smoking = 'n';
		}
		return smoking;
		
	}
	
	public int getRoomNum(int roomNum)
	{
		return roomNum;	
	}
	
	public double getRoomRate(double rate)
	{
		return rate;
	}
	
	public String getOccupant(String occupantName)
	{
		return occupantName;
	}
	
	public String setOccupied(boolean isOccupied)
	{
		notOccupied = "Not Occupied";
		if(isOccupied)
		{
			return occupantName;
		}
		else
		{
			return notOccupied;
		}
		
	}
	
	public String setOccupant(String occupantName)
	{
		this.occupantName = occupantName;
		return occupantName;
	}

	public boolean isOccupied(boolean occupied)
	{	
	

		if(occupantName == "Not Occupied")
		{
			return false;
		}
		else
		{
			return true;
		}		
	}
	
	public String toString()
	{
		String showRoom = "Room Number: " + getRoomNum + "\n" + "Occupant Name: " + getOccupant + "\n" + "Smoking Room: " + getSmoking + "\n" + "Bed Type: " + getBedType + "\n" + "Rate: " + getRoomRate;
		return showRoom; 
	}
}

and Hotel class:

import java.util.ArrayList;

public class Hotel
{
	
	ArrayList<Room> theRooms = new ArrayList<Room>();
	
	public void addRoom()
	{
		theRooms.add(new Room(101, "q", 99.99, 's', "Sally Fields")); 
	}
}

[GregBrannon]

And how are you driving what you've shown us? Do you have a class with a main() method somewhere?

[teQuiero]

	public ArrayList geValues(){
	 return this.theRooms;
	}

[karabasf]

public class Hotel
{
	
	ArrayList<Room> theRooms = new ArrayList<Room>();
	
	public void addRoom()
	{
		theRooms.add(new Room(101, "q", 99.99, 's', "Sally Fields")); 
	}
}

This is a default method, entering default values for the room object when no arguments are used for addRoom. Do you also have another the overloaded method, which takes arguments for the room object, e.g.

//Method to add an user defined room
public void addRoom(int roomNum, String bedType, double rate, char smoking, String occupantName){
    //Add the room to the array list
     theRooms.add(new Room(roomNum, bedType, rate, smoking, occupantName))
}

There is a high possibility that this is the problem. If you already have such a method, post your public static void main(|String[] args) from your test class and we will try to help you further.

Edit: the subject of this topic looks awfully familiar with one of the topics I've seen earlier these days.

This post has been edited by karabasf: 08 April 2012 - 09:32 AM

[codeMonkey_1066]

Look at your constructor.

javanewbie99, on 08 April 2012 - 09:07 AM, said:

	public Room(int roomNum, String bedType, double rate, char smoking, String occupantName)
	{
		roomNum = 0;
		bedType = "";
		rate = 0;
		smoking = ' ';
		occupantName = "";
		
	}

you don't assign any of the parameter values to those of the objects fields.
What you want is code of the form

public class Room
{
 private int roomNumuber = 0 ; // sets the default value.

 public Room(int roomNumber)
 {
  // set the room number of THIS new Room object to the value of the variable that is passed in.
  this.roomNumber = roomNumber ;
 }
}

This post has been edited by codeMonkey_1066: 08 April 2012 - 09:30 AM

[javanewbie99]

I apologize. I forgot to add the test class that I was using.

public class RoomTest
{
	private String q;
	
	public static void main(String[]args)
	{
		
		
		Room r1 = new Room(101, "q", 99.99, 's', "Sally Fields");
		System.out.println(r1.toString());
	
		
		
	}
}

I could not determine how to test it directly from the Hotel class, so I copied and pasted the code directly into a RoomTest class. This is the first time that I've ever tried to use code from one class in another class and then test it in a third class, so I'm totally confused.

Thanks for your response.

[codeMonkey_1066]

A couple of extra comments.

As a room can be smoking or non smoking ( only two options ) your far better off using a boolean to record it.

Also having too many parameters to your constructor ( or any method for that method ) is bad practice.
Try to limit the parameters to only those that are different for every instance of the class and create set methods for the other fields.
For example

 private int roomNumber = 0 ;
 private double rate = 0.0;
 private boolean smoking = false ;

 public Room(int roomNumer)
 {
  this.roomNumber = roomNumber ;
 }

 public void setRate(double rate)
 {
  this.rate = rate ;
 }

 ...

 Room room = new Room(101);
 room.setRate(10.20);
 room.setSmoking(true);
 ...
 
 theRooms.add(room);
 

For simple classes it may seem like a lot of work but it's a habit that will stand you in good stead when you start working on more complicated code.

[GregBrannon]

As I think has been suggested, your Room constructor:

public Room(int roomNum, String bedType, double rate, char smoking, String occupantName)
    {
        roomNum = 0;
        bedType = "";
        rate = 0;
        smoking = ' ';
        occupantName = "";
        
    }

needs to incorporate the values being passed by the new Room() statement in your RoomTest class. The beginning of the updated Room class and constructor would look like:

public class Room
{   
    private int roomNum;
    private String bedType;
    private double rate;
    private char smoking;
    private String occupantName;
    private String notOccupied;
    public String q;
    public String k;
        
    public Room(int roomNum, String bedType, double rate, char smoking, String occupantName)
    {
        this.roomNum = roomNum;
        this.bedType = bedType;
        this.rate = rate;
        this.smoking = smoking;
        this.occupantName = occupantName;
        
    }
. . . and on

Then your toString() method output needs to be changed:

        String showRoom = "Room Number: " + roomNum + "\n" + "Occupant Name: " 
                    + occupantName + "\n" + "Smoking Room: " + 
                smoking + "\n" + "Bed Type: " + bedType + "\n" + "Rate: " 
                    + rate;

That will give you the results you're hoping for.

[javanewbie99]

Thank you so much! I tried this.roomNum and changing the toString() method. I just didn't try them both at the same time. I truly appreciate it!

[GregBrannon]

Now that you've seen how to do it, I want to comment on what you were trying to do. From the original names you'd given your Room class instance variables, it appeared that you had a concept of the right idea, but you applied it in the wrong place.

In another class (like RoomTest), to access the variables of an instance of the class Room called room, you'd do something like:

int roomNumber = room.getRoomNum();
String bedType = room.getBedType();

etc. . .

That's why you wrote those 'getters' in the class Room.