0 Replies - 14512 Views - Last Post: 17 April 2012 - 07:38 AM

#1 codeprada  Icon User is offline

  • Changed Man With Different Priorities
  • member icon

Reputation: 944
  • View blog
  • Posts: 2,353
  • Joined: 15-February 11

[Results] PHP Challenge - Morse Code Translator

Post icon  Posted 17 April 2012 - 07:38 AM

I judged the submissions based on four areas each worth 5pts:
  • Accuracy - How accurate are the results
  • Error Handling - Proper error handling
  • Readability - Proper Comments, Indentation, Code not rambled into just two functions, How easy it is to follow your code
  • Efficiency - Results of benchmark


A Few Comments
There are a few things I noticed. One was no one checked whether the parameter passed was a string or not. You also shouldn't output "Invalid Character" in the results or kill the entire script when an invalid character is met. Throwing exceptions are better since they can be handled and debugged appropriately.


Atli
  • Accuracy - 5
  • Error Handling - 4
  • Readability - 4
  • Efficiency - 3


CTphpnwb
  • Accuracy - 5
  • Error Handling - 3
  • Readability - 3.5
  • Efficiency - 5


Duckington
  • Accuracy - 5
  • Error Handling - 3
  • Readability - 3.5
  • Efficiency - 3


gm04030276
  • Accuracy - 5
  • Error Handling - 3
  • Readability - 3.5
  • Efficiency - 5


hiddenghost
  • Accuracy - 2.5
  • Error Handling - 2.5
  • Readability - 2.5
  • Efficiency - 3


JackOfAllTrades
  • Accuracy - 3.5
  • Error Handling - 3
  • Readability - 4
  • Efficiency - 4.5


McSick
  • Accuracy - 5
  • Error Handling - 2
  • Readability - 3
  • Efficiency - 4.5


sBorg
  • Accuracy - 5
  • Error Handling - 2
  • Readability - 4
  • Efficiency - 4.5


snoj
  • Accuracy - 5
  • Error Handling - 2
  • Readability - 3.5
  • Efficiency - 3.5


xxxjj18
  • Accuracy - 4
  • Error Handling - 3.5
  • Readability - 3.5
  • Efficiency - 2.5


  • sBorg
    Spoiler

  • CTphpnwb
    Spoiler

  • snoj
    Spoiler

  • gm04030276
    Spoiler

  • hiddenghost
    Spoiler

  • Duckington
    Spoiler

  • McSick
    Spoiler

  • JackOfAllTrades
    Spoiler

  • xxxjj18
    Spoiler

  • Atli
    Spoiler

  • Dormilich
    Spoiler


We also have submissions in other languages.

  • GunnerInc - Assembly
    Spoiler

  • AdamSpeight2008 - VB.net (.net 4.5)
    Spoiler

This post has been edited by codeprada: 19 April 2012 - 04:21 PM


Is This A Good Question/Topic? 3
  • +

Page 1 of 1