[buddyboy123]

Hello i really need help with some stuff about JComboBox let me just show you the code.

import javax.swing.JComboBox;


public class PlayerSkill {
	
   public int damage = 0;
   public int manaCost = 0;
   public int ID = 0;
   
   public static int skills[]={0,0,0,0};
   public static String skillName[]={"skills", "", "", "", ""};
   private JComboBox skillList = new JComboBox(skillName);
	
	public PlayerSkill(int damage, int manaCost, int ID){
		
		Gui.f.add(skillList);
		
		skillList.setBounds(100,100,200,200);
		
		this.damage = damage;
		this.manaCost = manaCost;
		this.ID = ID;
	}
	
	public void addNewItem(){
		
		for(int i = 1; i < skills.length; i++){
			
			if(skills[i] == 0 && skillName[i] == ""){
				
					skillList.insertItemAt(skillName(), i);
					skills[i] = ID;
					
					return;
			}
			System.out.println("Test1" + i);
		}
	}
	
	//Translates item IDs into item names.
	public String skillName(){
		
		switch(ID){
		case 0: return "epic smile";
		case 1: return "rain bow blast";
		case 2: return "bro hoof";
		case 3: return "gooby pls";
		}
		
		return "";
	}
}

and here is this code

Player.playerRace = "EPIC_FACE";
							PlayerSkill epic_smile1 = new PlayerSkill(4,1,1);
							PlayerSkill epic_smile = new PlayerSkill(4,1,0);
							epic_smile.addNewItem();
							epic_smile1.addNewItem();

It should be printing: skill, epic smile, rain bow blast. But it only prints: skill, and rain bow blast.

Any help would be nice:) Thank you, I really need this done:(

[pbl]

skillName[i] == ""){

You can't compare Object (and String are object) withh the == operator
You need to use the equals() method

skillName[i].equals(""){

or faster in that case: skillName[i].length() == 0)

[buddyboy123]

Did this

	public void addNewItem(){
		
		for(int i = 1; i < skills.length; i++){
			
			if(skills[i] == 0 && skillName[i].equals("")){
				
					skillList.insertItemAt(skillName(), i);
					skills[i] = ID;
					
					return;
			}
			System.out.println("Test1" + i);
		}
	}

Still did not work.

[letthecolorsrumble]

I haven't checked it but your for-loop starts from i=1!

[buddyboy123]

letthecolorsrumble, on 08 June 2012 - 12:22 PM, said:

I haven't checked it but your for-loop starts from i=1!

Sorry yes i just fixed that/: And still does not work:( Thanks for pointing it out tho!

[letthecolorsrumble]

Are you passing the ID value to the skillName() method for the ID? (for switch case)

I'm really sorry I do not have an IDE on this machine so can't really help you as quickly as I could.

This post has been edited by letthecolorsrumble: 08 June 2012 - 12:31 PM

[buddyboy123]

No but i do not think i need too.

[letthecolorsrumble]

True, you don't need to, its public. My Bad!

[buddyboy123]

Its fine I just wish i could get this to work;(

[letthecolorsrumble]

Just a guess, but could the error be in

line 29
if(skills[i] == 0

line 32
skills[i] = ID;


hope that helps!

[buddyboy123]

letthecolorsrumble, on 08 June 2012 - 01:57 PM, said:

Just a guess, but could the error be in

line 29
if(skills[i] == 0

line 32
skills[i] = ID;


hope that helps!

I don't think that could be it cause in if statements you need to do == and just regular you do =.

[buddyboy123]

Will any one help me to fix this please:(

[pbl]

Why don't you rather tell us what you are trying to do ?
Why filling a ComboBox with empty String "" ?

When you insertItemAt() you insert there but you push down the empty String

Why do you need a skills[] and a skillName[] array ? Why are they static ?