[nigelmichael]

Hey guys, I have been awake all night for 9 hours straight without rest trying to figure out what loop to use and I cant seen to get it even though how hard I try. Well, I am supposed to
create a program that computes Voltage and Power of a circuit. I have everything up and running except for the looping part. I need to run the program for infinite times, until I enter 0, which will then calculate and sum everything up.

I need the result something like this:

printf ("+------------+------------+------------+------------+------------+\n");
printf ("| No of              | Total               | Average          | Total              | Average           |\n");
printf ("| Circuits:          | Voltage:          | Voltage:          | Power:           | Power:             |\n");
printf ("|	                    |		             |		              |	                      |	                       |\n");
printf ("|		12	  	 48.91mV	           4.07mV           292.02mW            24.34mW  |\n");
printf ("+------------+------------+------------+------------+------------+\n");

And for now, this is all I got.

#include <stdio.h>

int main ()
{

	int circuit;


{


{
	printf ("Please enter the type of circuits being tested.\nPlease enter 1 for Serial, 2 for Parallel.\n");
	scanf ("%d", &circuit);
}	

while (circuit != 1 && circuit != 2)
{
	printf ("Invalid input.\n");
	printf ("Please re-enter the type of circuits being tested. 1 for Serial, 2 for Parallel.");
	scanf ("%d", &circuit);

}


	if (circuit==1)
	{
	printf ("You have chosen: Serial.\n");
	}

	else
	{
	printf ("You have chosen: Parallel.\n");
	goto parallel;
	}

}

{
float current;
float resistor1;
float resistor2;
float resistor3;	


	printf ("Please enter the current value of the circuit: ");
	scanf ("%f", &current);


while (current > 500 || current < 5)
{
	printf ("Please re-enter the current value: ");
	scanf ("%f", &current);
}


	printf ("Now, enter the first resistor value: ");
	scanf ("%f", &resistor1);
	printf ("Now, enter the second resistor value (If not applicable, type 0): ");
	scanf ("%f", &resistor2);
	printf ("Now, enter the third resistor value (If not applicable, type 0): ");
	scanf ("%f", &resistor3);

float voltage;
float power;

	voltage=current*(resistor1+resistor2+resistor3);
	power=current*voltage;
	
	printf ("The voltage of the circuit is %.2fmV.\n", voltage);
	printf ("The power of the circuit is %.2fmW.\n", power);

return 0;
}


	parallel:
{
float current;
float resistor1;
float resistor2;
float resistor3;


	printf ("Please enter the current value of the circuit: ");
	scanf ("%f", &current);


while (current > 500 || current < 5)
{
	printf ("Please re-enter the current value: ");
	scanf ("%f", &current);
}


	printf ("Now, enter the first resistor value: ");
	scanf ("%f", &resistor1);
	printf ("Now, enter the second resistor value (If not applicable, type 0): ");
	scanf ("%f", &resistor2);
	printf ("Now, enter the third resistor value (If not applicable, type 0): ");
	scanf ("%f", &resistor3);

float voltage;
float power;


if (resistor1 == 0)
{
voltage=current*(1/((1/resistor2)+(1/resistor3)));
power=current*voltage;
	printf ("The voltage of the circuit is %.2fmV.\n", voltage);
	printf ("The power of the circuit is %.2fmW.\n", power);
}


else if (resistor2 == 0)
{
voltage=current*(1/((1/resistor1)+(1/resistor3)));
power=current*voltage;
	printf ("The voltage of the circuit is %.2fmV.\n", voltage);
	printf ("The power of the circuit is %.2fmW.\n", power);
}


else if (resistor3 == 0)
{
voltage=current*(1/((1/resistor1)+(1/resistor2)));
power=current*voltage;
	printf ("The voltage of the circuit is %.2fmV.\n", voltage);
	printf ("The power of the circuit is %.2fmW.\n", power);
}


else
{
voltage=current*(1/((1/resistor1)+(1/resistor2)+(1/resistor3)));
power=current*voltage;
	printf ("The voltage of the circuit is %.2fmV.\n", voltage);
	printf ("The power of the circuit is %.2fmW.\n", power);	
}


return 0;
}
}

This post has been edited by jimblumberg: 12 July 2012 - 01:44 PM
Reason for edit:: Added missing Code Tags, Please learn to use them.

[jimblumberg]

First use code tags when posting code.



Next does this program even compile? If not post the complete error messages exactly as they appear in your development environment.

And you need to find an indentation style and use it consistently. This will make your code much easier to read and troubleshoot.

Jim

[nigelmichael]

Yes, it does compile, but only for a single circuit. I need to get it to compute all the circuit types entered, and find the average out of the number of circuits entered.

[totgeburt]

so make a sentinel controlled loop since you are entering an arbitrary amount of data, and make the sentinel = 0. that way, when you enter zero, viola! it stops the loop. just as you described
something like while(input != 0) or whatever

as for the average, you'll need a variable to hold a total and a variable to be a counter, then divide total by counter and you'll get your average

This post has been edited by totgeburt: 12 July 2012 - 02:01 PM

[jimblumberg]

First properly indent your code, then I suggest you rework your code to remove all the goto statements. Learn to use one of the other looping statements like while(), do/while() or the for loop. Using goto makes following your logic very difficult and they are considered a bad programming practice.


Jim

[DoNotWant]

while (circuit != 1 && circuit != 2)
Lol wut? Line 17.

[snoopy11]

Hi NigelMichael,

I take it your an electrical engineering student ?

anyway to your problem ...

Your whole program needs to optimised... for functions.

goto as has been said should be avoided.

link to explanation of function calls

I know this is a different way of thinking... so...
I will give you this..

#include <stdio.h>

/*Function prototypes*/
void parallel();
void serial();
void Details(float *current, float *resistor1, float *resistor2, float *resistor3);
void Table(int totalcircuits);
/*Globals*/
float TotalPower;
float TotalVoltage;

int main ()
{

    int circuit;
    int totalcircuits;

    printf ("Please enter the total amount of circuits being tested.\n");
    scanf ("%d", &totalcircuits);

    while (circuit != 1 && circuit != 2)
    {
        printf ("Please enter the type of circuits being tested.\nPlease enter 1 for Serial, 2 for Parallel.\n");
        scanf ("%d", &circuit);
        if (circuit != 1 && circuit != 2)
        {
          printf ("Invalid input.\n");
        }

    }


    if (circuit==1)
    {
        int x;

        printf ("You have chosen: Serial.\n");
        for (x=0; x < totalcircuits; x++)
        {
        printf("Circuit No. %d\n",x+1);
        serial();
        }
    }

    else
    {
        int x;
        printf ("You have chosen: Parallel.\n");
        for (x=0; x < totalcircuits; x++)
        {
        printf("Circuit No. %d\n",x+1);
        parallel();
        }
    }
    printf("\n");
    printf("The Table \n\n");
    Table(totalcircuits);
    return 0;

}

Now all you have to do is write the functions for this program...

Best Wishes

Snoopy.

This post has been edited by snoopy11: 13 July 2012 - 11:43 AM

[totgeburt]

you're such a nice guy snoopy