[Tailean]

Basically, I am trying to check and see if a player types in a cretin command such as "!help" it will write some text to the console. I could use help with Syntax..and even logic..as I am not sure my method is the easiest/best. Here is what I have:

    class Commands
    {
        public void cmd()
        {
        string help = "!help";
        string attack = "!attack";
        string equipment = "!equipment";
        string clothing = "!clothing";
        string estates = "!estates";
        string location = "!location";
        string work = "!work";
        string train = "!train";
        string go = "!go";
        string track = "!track";
        string powers = "!powers";
        string money = "!money";
        string stats = "!stats";
        string skills = "!skills";
        string eat = "!eat";
        string armor = "!armor";
        string north = "!north";
        string south = "!south";
        string east = "!east";
        string west = "!west";
        string yes = "!yes";
        string no = "!no";

        for (; ; )
        {
            // statements
            string holdValue = "";
        if (Console.ReadLine() == "!help")
        {
            Console.WriteLine(help);
            
        }

        if (Console.ReadLine() == "!attack")
        {
            Console.WriteLine("You are Attacking!");
            
        }
        }
        }

Then in my main I have this:

static void Main(string[] args)
        {
            Commands commands = new Commands();
            commands.cmd();
        }

the problem is sometimes when I type in !attack it will say you are attacking and sometimes it wont..not sure why I am getting this outcome. If anyone is curious..its just a lil Mini mud game.

[Nakor]

It's because you have 2 console.readline commands. If you type !attack twice in a row, it will match on the if that checks for attack but not on the one that checks for help.

[Momerath]

You are accepting input on two different lines (32 and 38). When the program is on line 32, it only recognizes the "!help" command, and when on line 38 it only recognizes the "!attack" command.

Otherwise, your code is going to become a nightmare very quickly. I'd look around for tutorials on arrays and enumerated values.

[Tailean]

Okay, well let me ask this: How do I constantly check for input, and then if it matches a cretin string typed then it outputs a certain set of strings.

[Nakor]

you could do something like

string holdValue = string.Empty;

for (;;)/>
{
    holdValue = Console.ReadLine();
    // rest of code
}

Then just check the value of holdValue

This post has been edited by Nakor: 19 July 2012 - 07:27 PM

[Tailean]

ya, I dont think that would work for me cause I would need a Console.ReadLine(); for each command and that puts me back where I started ;/.

[Skydiver]

Tailean, on 20 July 2012 - 01:01 AM, said:

ya, I dont think that would work for me cause I would need a Console.ReadLine(); for each command and that puts me back where I started ;/.

I beg to differ... You don't need a Console.ReadLine() for each command.

Consider this code:

var code = new List<string>();
bool quit = false;
while(!quit)
{
    Console.WriteLine("Ready.");
    string command = Console.ReadLine();
    switch(command)
    {
    case "quit":
        quit = true;
        break;

    case "list":
        foreach(var line in code)
            Console.WriteLine(line);
        break;

    case "run":
        Console.WriteLine("Can't run code yet.");
        break;

    default:
        code.Add(command);
        break;
    }
}

One Console.ReadLine(), but so far the code above has 3 commands. It's brute force code. A more elegant solution would use a chain of responsibility pattern to find the command, and a strategy pattern to run the command.

This post has been edited by Skydiver: 20 July 2012 - 01:24 AM

[Tailean]

Point taken.. my in experience with Syntax is getting the better of me..thanks for your post.