[fgatlin]

Hi everyone,

I am quite a newbie at PHP, but I am trying to write a piece of code that will do something IF the zip-code is true,
ELSE do something else if false.

However, I have a list of about 50 local zip-codes to use.

if($stZip == 33762){
$locDeliv = $inpOpts['loc_ch_av'];
}else {
$locDeliv = $inpOpts['loc_unch_av'];
}

Works well, but I need to include multiple zip-codes.

$zips[]= "33762";
$zips[]= "33716";
$zips[]= "33634";
if($stZip == $zips){
$locDeliv = $inpOpts['loc_ch_av'];
}else {
$locDeliv = $inpOpts['loc_unch_av'];
}

The above code does NOT work, and only displays the variable $zips (not an actual zip-code)

Any thoughts?

[Slice]

So you have one zip code ($stZip) and you want to check through an array of multiple zips to see if any match it? Try a foreach loop like this:

<?php
$zips = array();
$zips[]= "33762";
$zips[]= "33716";
$zips[]= "33634";

foreach($zips as $zip)
{
	if($stZip == $zip)
	{
		$zipmatch = true;
	}
}

if($zipmatch){
	$locDeliv = $inpOpts['loc_ch_av'];
}else {
	$locDeliv = $inpOpts['loc_unch_av'];
}
?>

If there are no zip codes in the array that match $stZip then it will return false.

[JackOfAllTrades]

Or

<?php

$zips[]= "33762";
$zips[]= "33716";
$zips[]= "33634";
if (in_array("33716", $zips)) {
	print("Found it\n");
} else {
	print("Not found\n");
}

?>

[fgatlin]

Worked PERFECT Slice! Thank you.

[Loopzle]

Although this may not help for the current topic (which has been solved), just a note for next time:

if($stZip == 33762){
$locDeliv = $inpOpts['loc_ch_av'];
}else {
$locDeliv = $inpOpts['loc_unch_av'];
}

can be shortened to

$locDeliv = ($stZip == 33762) ? $inpOpts['loc_ch_av'] : $inpOpts['loc_unch_av'];

[Duckington]

Let's not try to get him running before he can walk..

[Atli]

@Loopzle. A huge downside to that, however, is that ternary conditions tend to be a lot more difficult to read. Sure, you save 20 characters, but in return you have to bunch the whole thing up in a single line, forcing you to have to scan the line for the ? and : characters in order to separate the condition and the return values. - It's even worse if you try to spread it over multiple lines, or if there are multiple conditions. Or the horror of using multiple, nested ternary operators.

Reducing the number of lines of code means far less than improving readability. Not that using the ternary operator always means reduced readability, but in my experience, an overwhelming majority of the times it does.

// This is fine.
$value = $cond == 'value' ? $iftrue : $otherwise;

// This is bearable, I suppose.
$value = isset($_GET['inputParam']) ? $_GET['inputParam'] : $defaultValue;

// Now it's getting a bit out of hand.
$user = User::Validate($_POST['username'], $_POST['password']) ? new User($_POST['username']) : null;

// And this is just plain ridiculous.
$ip = isset($_SERVER['HTTP_CLIENT_IP']) ? $_SERVER['HTTP_CLIENT_IP'] : (isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : $_SERVER['REMOTE_ADDR']);

[CTphpnwb]

If we're going to make things readable (and we certainly should) then let's not forget about proper indenting:

if($stZip == 33762){
	$locDeliv = $inpOpts['loc_ch_av'];
}else {
	$locDeliv = $inpOpts['loc_unch_av'];
}