[ersaan]

I have a problem with this mssq_fetch_array() could anyone help me to fix the problem or tell me how to fix it i will be thankfull to everyone who would like to help me ..
HERE IS THE CODE :

<?php

$FName = $_POST['FName'];
$LName = $_POST['LName'];
$PHON = $_POST['PHON'];

$myServer = "ERSAAN-PC\SQLEXPRESS";
$myUser = "";
$myPass = "";
$myDB = "Project1";


//connection to the database
$dbhandle = mssql_connect($myServer, $myUser, $myPass)
  or die("Couldn't connect to SQL Server on $myServer"); 
  

//select a database to work with
$selected = mssql_select_db($myDB, $dbhandle)
  or die("Couldn't open database $myDB");
  
  $query="INSERT INTO dbo.Table1 (ID,FName,LName,PHON) VALUES (NULL,".$FName.",".$LName.",".$PHON.")";
  
[color="#00FFFF"]//here is the problem i don't know how to fix it[/color] 
while($row = mssql_fetch_array($query))
	{
  echo "ID:".$row['ID']."First Name:".$row['FName']."LastName:".$row['LName']."Phone:".$row['PHON'];
	}

mssql_close($dbhandle);

?>

[Dormilich]

mssql expects a PHP resource to be given (the result of the query), not just the SQL string.

[ToshNeox]

You should make $query a real query:

$query = mssql_query("Query here");

Then it will work.

This post has been edited by ToshNeox: 23 August 2012 - 11:31 AM

[no2pencil]

I would actually suggest not passing the query straight into the command. If it fails, you can always output the variable & visually inspect the query.

$sql = "Select * from whatever";
$result = $mssql_query($sql);
if(!$result) {
  echo "<p>The following sql failed : ".$sql."</p>";
}

Since most new members seem to like to feed variables unchecked right into their sql, it's a nice way of saying "this is why it failed".

[JackOfAllTrades]

And common frigging sense.

[no2pencil]

Common sense is not so common.

Unfortunately "Warning: Mssql_fetch_array(): Supplied Argument Is Not A Valid SQL-" is! lol

[JackOfAllTrades]

Well, it just seems like "my SQL query failed" should be followed immediately by the thought "I wonder why it failed? What is the error?", followed immediately by -- if the query is constructed from variables, not 'SELECT * FROM users' -- "what is the query I'm submitting?"

I agree the error message is less than optimal in this case; but a conscientious programmer would never hit that because they would check whether their SQL call succeeded.

[no2pencil]

JackOfAllTrades, on 23 August 2012 - 03:07 PM, said:

but a conscientious programmer would never hit that because....

because they would validate their variables before introducing them to the database

[JackOfAllTrades]

That too Validate client side, then server side, then submit.

But one step at a time...

[no2pencil]

JackOfAllTrades, on 23 August 2012 - 04:14 PM, said:

But one step at a time...

So this is bad?

$result = $mssql_query("SELECT * FROM TABLE WHERE ID = ".isset($_GET['id']));

Can you do OR statements in the text? (lol)

$result = $mssql_query("SELECT * FROM TABLE WHERE ID = ".isset($_GET['id']||!is_null($_GET['id']));

[Dormilich]

yes, this is bad since isset() and is_null() return booleans, which I doubt you intend to use here.

PS. it’s mssql_query() not $mssql_query()

[ersaan]

Can u tell me how to fix it cuz i'm tired of this i don't know how to make it work ... : )

[Dormilich]

do it like in the Manual: http://www.php.net/mssql-query

PS. if you’re too tired, make a break. it helps, trust me.