[snowingCa]

I have this program in C++, it count sum of one thread,I don't know how to make a sum of multi thread with a program divide the numbers from 1 to N into T groups of consecutive numbers.
For example, it has a 4 group, with N = 15, G = 4. TG1 = (1,2,3,4), G2 = (5,6,7,8), G3 = (9,10,11,12) and G4 = (13,14,15).
The output is ./sum 15 4
Thread 1 (1,4)
Thread 2 (5,8)
Thread 3 (9,12)
Thread 4 (13, 15)
Sum (1,15) = 120
Can anyone help me, please!.
Thanks in advance

--------------------------------------------

#include <pthread.h>
#include <iostream>
#include <cstdlib>

using namespace std;

// The adder thread that will add the number from 1 to n
void *adder(void * number);

// The sum variable that will be updated by all threads
unsigned long sum;

int main(int argc, char *argv[])
{
    if (argc != 2) {
        cerr << "Usage: sum <integer value>" << endl;
        exit(1);
    }

    unsigned long number = atol(argv[1]);
    if (number < 0) {
        cerr << "Argument " << number << " must be non-negative." << endl;
        exit(1);
    }
    
    pthread_t tid; // the thread identifierier
    pthread_attr_t attr; // set of attributes for the thread
    
    // get the default attributes
    pthread_attr_init(&attr);

    // create the thread
    pthread_create(&tid,&attr,adder,(void *) number);
    
    // Wait for the thread to exit
    pthread_join(tid,NULL);
    
    cout << "Sum(" << 1 << ", " << number << ") = " << sum << endl;
    
    return 0;
}

// Add the numbers from 1 to n
void *adder(void * number) 
{
    cout << "Thread ID = " << pthread_self() << endl;

    unsigned long num = (unsigned long) number;
    for (int i = 1; i <= num; i++)
    {
        sum += i;
    }
    
    pthread_exit(0);
}

This post has been edited by jimblumberg: 04 October 2012 - 02:50 PM
Reason for edit:: Added missing Code Tags, Please learn to use them.

[jimblumberg]

Please avoid creating duplicate posts, and when posting code use code tags:


Jim

[Salem_c]

> Can anyone help me, please!.
So what is your real question?

Your simple code would need to solve these problems
- splitting your total into sub-ranges
- passing multiple parameters to a thread
- starting multiple threads
- collecting results from a thread without using global variables.

Well, here is an example of parameter passing and result returning involving threads.
You should study the use of new and delete carefully.

#include <pthread.h>
#include <iostream>
#include <cstdlib>

using namespace std;

struct twonum {
    int from, to;
    twonum(int f, int t): from(f), to(t) { }
};

// The adder thread that will add the number from 1 to n
void *adder(void * number);

int main(int argc, char *argv[])
{
    pthread_t tid; // the thread identifierier
    pthread_attr_t attr; // set of attributes for the thread
    
    // get the default attributes
    pthread_attr_init(&attr);

    twonum *p = new twonum(5,10);
    // create the thread
    pthread_create(&tid,&attr,adder,(void *)p);
    
    // Wait for the thread to exit
    int *sum;
    pthread_join(tid,(void**)&sum);
    cout << "Result=" << *sum << endl;
    delete sum;

    return 0;
}

// Add the numbers from 1 to n
void *adder(void * number) 
{
    twonum *p = (twonum*)number;
    cout << "Thread ID = " << pthread_self() << endl;
    cout << "Input=" << p->from << " " << p->to << endl;
    int *result = new int;
    *result = p->from + p->to;
    delete p;
    pthread_exit((void*)result);
}