[deery5000]

Hi guys,

im tryng to search for a value in an xml and edit it. I can get the first vale but not all of them

  'Music composers, loop cast until job is Music Composer. Update value and exit for
            For Each p In movieData.<OpenSearchDescription>.<movies>.<movie>.<cast> 
              
  If p.<job>.Value = "Original Music Composer" Then
                    'Music composer
                    p.<name>.Value = Form1.musicComposerTextBox.Text
                    Exit For
                End If


            Next

I can get this string, its the first of 10, but i can only get the first one, how do i loop threw them?

  <person name="Wilhelm von Homburg" character="Vigo" job="Actor" id="27585" thumb="" department="Actors" url="http://www.themoviedb.org/person/27585" order="12" cast_id="23" /> 

Kevin

This post has been edited by deery5000: 05 October 2012 - 03:34 PM

[_HAWK_]

You need to get the right elements.

movieData...<person>

Then check the name attribute.

[AdamSpeight2008]

<person name="Wilhelm von Homburg" character="Vigo" job="Actor" id="27585" thumb="" department="Actors" url="http://www.themoviedb.org/person/27585" order="12" cast_id="23" />

In that snippet the job is an attribute, so use p.@job = "actor" .

[AdamSpeight2008]

Or you can still use the .Where extension method, to further filter the data.

For Each p In movieData.<OpenSearchDescription>.<movies>.<movie>.<cast>.Where(Function(p) p.@job = "Original Music Composer")
 p.@name = Form1.musicComposerTextBox.Text
Next

or in query style

For Each p in (From m in movieDate.<OpenSearchDescription>.<movies>.<movie>
               From cm in m
               Where cm.@job ="Original Music Composer"
               Select m)
  p.@name = Form1.musicComposerTextBox.Text
Next 

This post has been edited by AdamSpeight2008: 05 October 2012 - 05:02 PM

[deery5000]

HAWK you were right i needed to specify the .<person> in my search then i could traverse them

Heres the revised code

'Music composers, loop cast until job is Music Composer. Update value and exit for  
            For Each p In movieData.<OpenSearchDescription>.<movies>.<movie>.<cast>.<person>

                If p.@job = "Original Music Composer" Then

                    'Music composer  
                    p.@name = Form1.musicComposerTextBox.Text

                    Exit For

                End If
            Next

Thanks for you help, i live ling to xml, very powerful tool

Kevin

[AdamSpeight2008]

What a waste of a for each loop.

[deery5000]

Yes your are correct, this has been revised. the for each loop has been used like this

 For Each p In movieData.<OpenSearchDescription>.<movies>.<movie>.<cast>.<person>

                'Music composers
                If p.@job = "Original Music Composer" Then

                    'Update Music composer value
                    p.@name = Form1.musicComposerTextBox.Text

                End If

                'Screenplay
                If p.@job = "Screenplay" Then

                    'Update Music composer value
                    p.@name = screenNames(j)
                    j = j + 1
                End If

  
                'Directors
                If p.@job = "Director" Then

                    'Update Music composer value
                    p.@name = directorNames(k)
                    k = k + 1
                End If

                'Actors
                If p.@job = "Actor" Then

                    If i = 7 Then Exit For

                    p.@name = actorNames(i)
                    i = i + 1
                End If

            Next

does that suit you better, im always open to criticism.

This post has been edited by deery5000: 06 October 2012 - 03:41 PM

[lucky3]

You might want to switch from multiple If clauses to Select Case.

[AdamSpeight2008]

Seem like a lot a of similar stuff there, wouldn't that suggest writing method. Also the code doesn't convey it's intent, very well.

Sub ReplaceNameBasedOnJob(of T)(byref x As T, JobTitle As String, ReplacedName As Func(Of String)) As T
 If x.@job = JobTitle Then x.@name = ReplacedName()
End Sub

Sub ReplaceComposorWithNameFromComposerTextBox(of T)(byref x As T)
 ReplaceNameBasedOnJob(of T)(x, "Original Music Composer",
  Function()
    Return Form1.musicComposerTextBox.Text
  End Function)
End Sub
etc

Seem like Data and GUI is tightly coupled, separation helps.

This post has been edited by AdamSpeight2008: 06 October 2012 - 04:19 PM

[deery5000]

the idea of the function is to allow the user to manipulate the data on the form and ill update the xml file.

thanks for all the suggestions

kevin