[George Rex]

I have tried creating a database table in sql server and to insert records.
But Every time I run the codes, it just don't do anything. It only shows the msgbox prompt which I put to indicate confirmation.
I have 2 text boxes and 3 combo boxes. how do I add records into the sql table.
I simply want to add records from the form to the sql database table
emphasis should also be laid on the combo boxes too... what properties should be used when adding records to a database table?
Below are the codes i have used

'If txtAddID.Text = "" Then
'            MsgBox("Abeg Complete d Form b4 I break ur head!", MsgBoxStyle.Information)
'        Else
'            On Error Resume Next
'            Dim MyMsg
'            Dim con As New SqlConnection("server = REXYSPY\SQLEXPRESS;Initial Catalog=master;Integrated Security=True")
'            Dim cmd As New SqlCommand("insert into dbo.tblSchools values ('" + txtAddID.Text + "','" + txtAddInstitution.Text + "','" + cboAddInstituteState.Text + "','" + cboAddInstituteRegion.Text + "','" + cboAddInstituteType.Text + "')")
'            cmd.Connection = con
'            con.Open()
'            cmd.Parameters.AddWithValue("@ID", Me.txtAddID.Text)
'            cmd.Parameters.AddWithValue("@Sname", Me.txtAddInstitution.Text)
'            cmd.Parameters.AddWithValue("@Sstate", Me.cboAddInstituteState.Text)
'            cmd.Parameters.AddWithValue("@Sregion", Me.cboAddInstituteRegion.Text)
'            cmd.Parameters.AddWithValue("@Stype", Me.cboAddInstituteType.Text)
'            Dim reader As SqlDataReader = Nothing
'            cmd.ExecuteNonQuery()
'
'           con.Close()
'           MyMsg = MsgBox("Your Information don enta. You wan enta again", 4, "Confirmation!")
'           If MyMsg = 7 Then
'               Me.Close()
'               Input.Show()
'           End If
'       End If

[trevster344]

First did you check your connection string, I'm almost certain it's your connection string that is the problem. Make sure your SQL Server is at least of 2012. Build Connection Strings With the release of SQL Server 2012, so many issues went away. Before that even when you'd do things right you had a really good chance of crap going wrong. So make sure you've got the most recent SQL Server installed.

Second, is your table actually called dbo.tblschools?

Third, I strongly urge that you use the & operator instead of the + operator as you cannot add a string, but you can concatenate it(glue it on to the next one lol).

Fourth, is your paramenter @ID to establish an id for the record in the table? If so, there is already an easy way to do that, without having to do it yourself, that can be established with the sql database and the server.

This post has been edited by trevster344: 09 October 2012 - 04:37 PM

[CharlieMay]

First it's a good practice to put the fields in your insert statement.

Second, why are you concatenating into the string but defining parameters (use the parameters)

Now you insert statement would be

"insert into dbo.tblSchools (put your fields here) values (@ID, @Sname, @Sstate, @Sregion, @Stype)"
             cmd.Parameters.AddWithValue("@ID", Me.txtAddID.Text)
             cmd.Parameters.AddWithValue("@Sname", Me.txtAddInstitution.Text)
             cmd.Parameters.AddWithValue("@Sstate", Me.cboAddInstituteState.Text)
             cmd.Parameters.AddWithValue("@Sregion", Me.cboAddInstituteRegion.Text)
             cmd.Parameters.AddWithValue("@Stype", Me.cboAddInstituteType.Text)

Then you use the ExecuteNonQuery method against the command object.

Also, for readability it is good practice to use all uppercase keywords in your statements.
"INSERT INTO dbo.tblSchools (put your fields here) VALUES (@ID, @Sname, @Sstate, @Sregion, @Stype)"